[INFO] crate meter_proxy 0.2.3 is already in cache [INFO] extracting crate meter_proxy 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/meter_proxy/0.2.3 [INFO] extracting crate meter_proxy 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/meter_proxy/0.2.3 [INFO] validating manifest of meter_proxy-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of meter_proxy-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing meter_proxy-0.2.3 [INFO] finished frobbing meter_proxy-0.2.3 [INFO] frobbed toml for meter_proxy-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/meter_proxy/0.2.3/Cargo.toml [INFO] started frobbing meter_proxy-0.2.3 [INFO] finished frobbing meter_proxy-0.2.3 [INFO] frobbed toml for meter_proxy-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/meter_proxy/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting meter_proxy-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/meter_proxy/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 155e7386b4497388fb37d9eb83b8f9a985ee71b80a10c3d9cd4a3e2287a7d695 [INFO] running `"docker" "start" "-a" "155e7386b4497388fb37d9eb83b8f9a985ee71b80a10c3d9cd4a3e2287a7d695"` [INFO] [stderr] Checking meter_proxy v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proxy/async/mod.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Yellow` [INFO] [stderr] --> src/proxy/sync/mod.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | use ansi_term::Colour::{Red, Yellow}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `SocketAddr` [INFO] [stderr] --> src/proxy/sync/mod.rs:15:50 [INFO] [stderr] | [INFO] [stderr] 15 | use std::net::{TcpListener, TcpStream, Shutdown, SocketAddr,IpAddr}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `str` [INFO] [stderr] --> src/proxy/sync/mod.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | use std::{thread, str}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc::setrlimit` [INFO] [stderr] --> src/proxy/sync/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use libc::setrlimit; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/proxy/sync/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/sync/mod.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return sum as f64/time_vec.len() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum as f64/time_vec.len() as f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/sync/mod.rs:193:6 [INFO] [stderr] | [INFO] [stderr] 193 | return NUM_BYTES.get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NUM_BYTES.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/sync/mod.rs:197:6 [INFO] [stderr] | [INFO] [stderr] 197 | return TIME_TABLE.get_avg_value() / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TIME_TABLE.get_avg_value() / 1000000.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/proxy/sync/mod.rs:197:42 [INFO] [stderr] | [INFO] [stderr] 197 | return TIME_TABLE.get_avg_value() / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000.0f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/proxy/async/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `IpAddr` [INFO] [stderr] --> src/proxy/async/mod.rs:6:28 [INFO] [stderr] | [INFO] [stderr] 6 | use std::net::{SocketAddr, IpAddr}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/proxy/async/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Timeout` [INFO] [stderr] --> src/proxy/async/mod.rs:15:41 [INFO] [stderr] | [INFO] [stderr] 15 | use tokio_core::reactor::{Core, Handle, Timeout}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Window`, `read_exact`, `write_all` [INFO] [stderr] --> src/proxy/async/mod.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RwLock` [INFO] [stderr] --> src/proxy/async/mod.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | use std::sync::{Arc, Mutex, RwLock}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/async/mod.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | return *n_bytes as f64 / 1024.0f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*n_bytes as f64 / 1024.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/async/mod.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return *n_resp as f64 / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*n_resp as f64 / 1000000.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/proxy/async/mod.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | return *n_resp as f64 / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::read_exact': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::write_all': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:38 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Window': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:49 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/proxy/sync/mod.rs:369:10 [INFO] [stderr] | [INFO] [stderr] 369 | drop(back); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Io` [INFO] [stderr] --> src/proxy/async/mod.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/proxy/sync/mod.rs:262:22 [INFO] [stderr] | [INFO] [stderr] 262 | Err(ref err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `seq_number` [INFO] [stderr] --> src/proxy/sync/mod.rs:316:14 [INFO] [stderr] | [INFO] [stderr] 316 | let mut seq_number = 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_seq_number` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/proxy/sync/mod.rs:321:22 [INFO] [stderr] | [INFO] [stderr] 321 | Err(ref err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/proxy/sync/mod.rs:341:8 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(r) => { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `RecvError` [INFO] [stderr] --> src/proxy/sync/mod.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | RecvError => {}, [INFO] [stderr] | ^^^^^^^^^ help: consider using `_RecvError` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/proxy/async/mod.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | Err(e) => {; [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `core` [INFO] [stderr] --> src/proxy/async/mod.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | let mut core = Core::new().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_core` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pool` [INFO] [stderr] --> src/proxy/async/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | let pool = self.pool.clone(); [INFO] [stderr] | ^^^^ help: consider using `_pool` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let mut time_vec = self.0.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:155:26 [INFO] [stderr] | [INFO] [stderr] 155 | let mut stream_c = stream.try_clone().unwrap(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:204:10 [INFO] [stderr] | [INFO] [stderr] 204 | let mut back = match TcpStream::connect((targ_addr, target_port)) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:316:10 [INFO] [stderr] | [INFO] [stderr] 316 | let mut seq_number = 0; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/async/mod.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut core = Core::new().unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num_bytes` [INFO] [stderr] --> src/proxy/async/mod.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | num_bytes: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num_resp` [INFO] [stderr] --> src/proxy/async/mod.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | num_resp: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `other` [INFO] [stderr] --> src/proxy/async/mod.rs:378:1 [INFO] [stderr] | [INFO] [stderr] 378 | fn other(desc: &str) -> io::Error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/proxy/sync/mod.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | SharedCounter(Arc::new(Mutex::new(0))) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/proxy/sync/mod.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | *counter = *counter + quantity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += quantity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/proxy/sync/mod.rs:91:54 [INFO] [stderr] | [INFO] [stderr] 91 | static ref ERROR: Arc> = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/proxy/sync/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | if *reset_lock_flag_c.read().unwrap() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*reset_lock_flag_c.read().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | stream_c2.set_read_timeout(Some(Duration::new(3, 0))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:188:6 [INFO] [stderr] | [INFO] [stderr] 188 | TcpStream::connect((targ_addr, self.front_port)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/proxy/sync/mod.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | if *err == false { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:215:14 [INFO] [stderr] | [INFO] [stderr] 215 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut` should have a snake case name such as `timed_out` [INFO] [stderr] --> src/proxy/sync/mod.rs:227:10 [INFO] [stderr] | [INFO] [stderr] 227 | let timedOut = Arc::new(AtomicBool::new(false)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut_c` should have a snake case name such as `timed_out_c` [INFO] [stderr] --> src/proxy/sync/mod.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | let timedOut_c = timedOut.clone(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut` should have a snake case name such as `timed_out` [INFO] [stderr] --> src/proxy/sync/mod.rs:252:31 [INFO] [stderr] | [INFO] [stderr] 252 | timedOut: Arc, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:255:6 [INFO] [stderr] | [INFO] [stderr] 255 | front.set_read_timeout(Some(Duration::new(1000, 0))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:272:18 [INFO] [stderr] | [INFO] [stderr] 272 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/proxy/sync/mod.rs:286:10 [INFO] [stderr] | [INFO] [stderr] 286 | match back.write(&buf[0..read]) { [INFO] [stderr] | _____________^ [INFO] [stderr] 287 | | Err(..) => { [INFO] [stderr] 288 | | timedOut.store(true, Ordering::Release); [INFO] [stderr] 289 | | // normal errors, just stop [INFO] [stderr] ... | [INFO] [stderr] 296 | | Ok(..) => (), [INFO] [stderr] 297 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | if let Err(..) = back.write(&buf[0..read]) { [INFO] [stderr] 287 | timedOut.store(true, Ordering::Release); [INFO] [stderr] 288 | // normal errors, just stop [INFO] [stderr] 289 | front.shutdown(Shutdown::Both); [INFO] [stderr] 290 | back.shutdown(Shutdown::Both); [INFO] [stderr] 291 | drop(front); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:290:18 [INFO] [stderr] | [INFO] [stderr] 290 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:291:18 [INFO] [stderr] | [INFO] [stderr] 291 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut` should have a snake case name such as `timed_out` [INFO] [stderr] --> src/proxy/sync/mod.rs:309:31 [INFO] [stderr] | [INFO] [stderr] 309 | timedOut: Arc, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:312:6 [INFO] [stderr] | [INFO] [stderr] 312 | back.set_read_timeout(Some(Duration::new(1000, 0))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:330:18 [INFO] [stderr] | [INFO] [stderr] 330 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:331:18 [INFO] [stderr] | [INFO] [stderr] 331 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `RecvError` should have a snake case name such as `recv_error` [INFO] [stderr] --> src/proxy/sync/mod.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | RecvError => {}, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/proxy/sync/mod.rs:353:10 [INFO] [stderr] | [INFO] [stderr] 353 | match front.write(&buf[0..read]) { [INFO] [stderr] | _____________^ [INFO] [stderr] 354 | | Err(..) => { [INFO] [stderr] 355 | | timedOut.store(true, Ordering::Release); [INFO] [stderr] 356 | | // normal errors, just stop [INFO] [stderr] ... | [INFO] [stderr] 363 | | Ok(..) => (), [INFO] [stderr] 364 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 353 | if let Err(..) = front.write(&buf[0..read]) { [INFO] [stderr] 354 | timedOut.store(true, Ordering::Release); [INFO] [stderr] 355 | // normal errors, just stop [INFO] [stderr] 356 | front.shutdown(Shutdown::Both); [INFO] [stderr] 357 | back.shutdown(Shutdown::Both); [INFO] [stderr] 358 | drop(back); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:357:22 [INFO] [stderr] | [INFO] [stderr] 357 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:358:22 [INFO] [stderr] | [INFO] [stderr] 358 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/proxy/async/mod.rs:22:51 [INFO] [stderr] | [INFO] [stderr] 22 | static ref ERROR: Arc> = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Yellow` [INFO] [stderr] --> src/proxy/sync/mod.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | use ansi_term::Colour::{Red, Yellow}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `SocketAddr` [INFO] [stderr] --> src/proxy/sync/mod.rs:15:50 [INFO] [stderr] | [INFO] [stderr] 15 | use std::net::{TcpListener, TcpStream, Shutdown, SocketAddr,IpAddr}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `str` [INFO] [stderr] --> src/proxy/sync/mod.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | use std::{thread, str}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `libc::setrlimit` [INFO] [stderr] --> src/proxy/sync/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use libc::setrlimit; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/proxy/sync/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/sync/mod.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return sum as f64/time_vec.len() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum as f64/time_vec.len() as f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/sync/mod.rs:193:6 [INFO] [stderr] | [INFO] [stderr] 193 | return NUM_BYTES.get(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NUM_BYTES.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/sync/mod.rs:197:6 [INFO] [stderr] | [INFO] [stderr] 197 | return TIME_TABLE.get_avg_value() / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TIME_TABLE.get_avg_value() / 1000000.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/proxy/sync/mod.rs:197:42 [INFO] [stderr] | [INFO] [stderr] 197 | return TIME_TABLE.get_avg_value() / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000.0f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/proxy/async/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `IpAddr` [INFO] [stderr] --> src/proxy/async/mod.rs:6:28 [INFO] [stderr] | [INFO] [stderr] 6 | use std::net::{SocketAddr, IpAddr}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/proxy/async/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Timeout` [INFO] [stderr] --> src/proxy/async/mod.rs:15:41 [INFO] [stderr] | [INFO] [stderr] 15 | use tokio_core::reactor::{Core, Handle, Timeout}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Window`, `read_exact`, `write_all` [INFO] [stderr] --> src/proxy/async/mod.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RwLock` [INFO] [stderr] --> src/proxy/async/mod.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | use std::sync::{Arc, Mutex, RwLock}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/async/mod.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | return *n_bytes as f64 / 1024.0f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*n_bytes as f64 / 1024.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/proxy/async/mod.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return *n_resp as f64 / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*n_resp as f64 / 1000000.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/proxy/async/mod.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | return *n_resp as f64 / 1000000.0f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000.0f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Io': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::read_exact': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:26 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::write_all': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:38 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_core::io::Window': moved to the `tokio-io` crate [INFO] [stderr] --> src/proxy/async/mod.rs:17:49 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/proxy/sync/mod.rs:369:10 [INFO] [stderr] | [INFO] [stderr] 369 | drop(back); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Io` [INFO] [stderr] --> src/proxy/async/mod.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | use tokio_core::io::{Io, read_exact, write_all, Window}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/proxy/sync/mod.rs:262:22 [INFO] [stderr] | [INFO] [stderr] 262 | Err(ref err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `seq_number` [INFO] [stderr] --> src/proxy/sync/mod.rs:316:14 [INFO] [stderr] | [INFO] [stderr] 316 | let mut seq_number = 0; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_seq_number` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/proxy/sync/mod.rs:321:22 [INFO] [stderr] | [INFO] [stderr] 321 | Err(ref err) => { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/proxy/sync/mod.rs:341:8 [INFO] [stderr] | [INFO] [stderr] 341 | Ok(r) => { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `RecvError` [INFO] [stderr] --> src/proxy/sync/mod.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | RecvError => {}, [INFO] [stderr] | ^^^^^^^^^ help: consider using `_RecvError` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/proxy/async/mod.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | Err(e) => {; [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `core` [INFO] [stderr] --> src/proxy/async/mod.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | let mut core = Core::new().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_core` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pool` [INFO] [stderr] --> src/proxy/async/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | let pool = self.pool.clone(); [INFO] [stderr] | ^^^^ help: consider using `_pool` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let mut time_vec = self.0.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:155:26 [INFO] [stderr] | [INFO] [stderr] 155 | let mut stream_c = stream.try_clone().unwrap(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:204:10 [INFO] [stderr] | [INFO] [stderr] 204 | let mut back = match TcpStream::connect((targ_addr, target_port)) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/sync/mod.rs:316:10 [INFO] [stderr] | [INFO] [stderr] 316 | let mut seq_number = 0; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/proxy/async/mod.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | let mut core = Core::new().unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num_bytes` [INFO] [stderr] --> src/proxy/async/mod.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | num_bytes: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num_resp` [INFO] [stderr] --> src/proxy/async/mod.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | num_resp: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `other` [INFO] [stderr] --> src/proxy/async/mod.rs:378:1 [INFO] [stderr] | [INFO] [stderr] 378 | fn other(desc: &str) -> io::Error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/proxy/sync/mod.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | SharedCounter(Arc::new(Mutex::new(0))) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/proxy/sync/mod.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | *counter = *counter + quantity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += quantity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/proxy/sync/mod.rs:91:54 [INFO] [stderr] | [INFO] [stderr] 91 | static ref ERROR: Arc> = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/proxy/sync/mod.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | if *reset_lock_flag_c.read().unwrap() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*reset_lock_flag_c.read().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | stream_c2.set_read_timeout(Some(Duration::new(3, 0))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:188:6 [INFO] [stderr] | [INFO] [stderr] 188 | TcpStream::connect((targ_addr, self.front_port)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/proxy/sync/mod.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | if *err == false { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:215:14 [INFO] [stderr] | [INFO] [stderr] 215 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut` should have a snake case name such as `timed_out` [INFO] [stderr] --> src/proxy/sync/mod.rs:227:10 [INFO] [stderr] | [INFO] [stderr] 227 | let timedOut = Arc::new(AtomicBool::new(false)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut_c` should have a snake case name such as `timed_out_c` [INFO] [stderr] --> src/proxy/sync/mod.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | let timedOut_c = timedOut.clone(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut` should have a snake case name such as `timed_out` [INFO] [stderr] --> src/proxy/sync/mod.rs:252:31 [INFO] [stderr] | [INFO] [stderr] 252 | timedOut: Arc, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:255:6 [INFO] [stderr] | [INFO] [stderr] 255 | front.set_read_timeout(Some(Duration::new(1000, 0))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:271:18 [INFO] [stderr] | [INFO] [stderr] 271 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:272:18 [INFO] [stderr] | [INFO] [stderr] 272 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/proxy/sync/mod.rs:286:10 [INFO] [stderr] | [INFO] [stderr] 286 | match back.write(&buf[0..read]) { [INFO] [stderr] | _____________^ [INFO] [stderr] 287 | | Err(..) => { [INFO] [stderr] 288 | | timedOut.store(true, Ordering::Release); [INFO] [stderr] 289 | | // normal errors, just stop [INFO] [stderr] ... | [INFO] [stderr] 296 | | Ok(..) => (), [INFO] [stderr] 297 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | if let Err(..) = back.write(&buf[0..read]) { [INFO] [stderr] 287 | timedOut.store(true, Ordering::Release); [INFO] [stderr] 288 | // normal errors, just stop [INFO] [stderr] 289 | front.shutdown(Shutdown::Both); [INFO] [stderr] 290 | back.shutdown(Shutdown::Both); [INFO] [stderr] 291 | drop(front); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:290:18 [INFO] [stderr] | [INFO] [stderr] 290 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:291:18 [INFO] [stderr] | [INFO] [stderr] 291 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `timedOut` should have a snake case name such as `timed_out` [INFO] [stderr] --> src/proxy/sync/mod.rs:309:31 [INFO] [stderr] | [INFO] [stderr] 309 | timedOut: Arc, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:312:6 [INFO] [stderr] | [INFO] [stderr] 312 | back.set_read_timeout(Some(Duration::new(1000, 0))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:330:18 [INFO] [stderr] | [INFO] [stderr] 330 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:331:18 [INFO] [stderr] | [INFO] [stderr] 331 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `RecvError` should have a snake case name such as `recv_error` [INFO] [stderr] --> src/proxy/sync/mod.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | RecvError => {}, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/proxy/sync/mod.rs:353:10 [INFO] [stderr] | [INFO] [stderr] 353 | match front.write(&buf[0..read]) { [INFO] [stderr] | _____________^ [INFO] [stderr] 354 | | Err(..) => { [INFO] [stderr] 355 | | timedOut.store(true, Ordering::Release); [INFO] [stderr] 356 | | // normal errors, just stop [INFO] [stderr] ... | [INFO] [stderr] 363 | | Ok(..) => (), [INFO] [stderr] 364 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 353 | if let Err(..) = front.write(&buf[0..read]) { [INFO] [stderr] 354 | timedOut.store(true, Ordering::Release); [INFO] [stderr] 355 | // normal errors, just stop [INFO] [stderr] 356 | front.shutdown(Shutdown::Both); [INFO] [stderr] 357 | back.shutdown(Shutdown::Both); [INFO] [stderr] 358 | drop(back); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:357:22 [INFO] [stderr] | [INFO] [stderr] 357 | front.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/proxy/sync/mod.rs:358:22 [INFO] [stderr] | [INFO] [stderr] 358 | back.shutdown(Shutdown::Both); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/proxy/async/mod.rs:22:51 [INFO] [stderr] | [INFO] [stderr] 22 | static ref ERROR: Arc> = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.26s [INFO] running `"docker" "inspect" "155e7386b4497388fb37d9eb83b8f9a985ee71b80a10c3d9cd4a3e2287a7d695"` [INFO] running `"docker" "rm" "-f" "155e7386b4497388fb37d9eb83b8f9a985ee71b80a10c3d9cd4a3e2287a7d695"` [INFO] [stdout] 155e7386b4497388fb37d9eb83b8f9a985ee71b80a10c3d9cd4a3e2287a7d695