[INFO] crate metagoblin 0.1.1 is already in cache [INFO] extracting crate metagoblin 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/metagoblin/0.1.1 [INFO] extracting crate metagoblin 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metagoblin/0.1.1 [INFO] validating manifest of metagoblin-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of metagoblin-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing metagoblin-0.1.1 [INFO] finished frobbing metagoblin-0.1.1 [INFO] frobbed toml for metagoblin-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/metagoblin/0.1.1/Cargo.toml [INFO] started frobbing metagoblin-0.1.1 [INFO] finished frobbing metagoblin-0.1.1 [INFO] frobbed toml for metagoblin-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metagoblin/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting metagoblin-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/metagoblin/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4cfed3cb02fc3dad6e1750504b78e98a0ab3216949bc2d6d71137b4e14b714b [INFO] running `"docker" "start" "-a" "e4cfed3cb02fc3dad6e1750504b78e98a0ab3216949bc2d6d71137b4e14b714b"` [INFO] [stderr] Compiling scroll_derive v0.9.5 [INFO] [stderr] Checking scroll v0.9.2 [INFO] [stderr] Checking goblin v0.0.19 [INFO] [stderr] Checking metagoblin v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / if let &Some(ref name) = &self.name { [INFO] [stderr] 38 | | Some(name) [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | None [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(ref name) = self.name { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match goblin { [INFO] [stderr] 180 | | &Object::Elf(ref elf) => { [INFO] [stderr] 181 | | for phdr in &elf.program_headers { [INFO] [stderr] 182 | | let range = phdr.file_range(); [INFO] [stderr] ... | [INFO] [stderr] 203 | | _ => (), [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | if let &Object::Elf(ref elf) = goblin { [INFO] [stderr] 180 | for phdr in &elf.program_headers { [INFO] [stderr] 181 | let range = phdr.file_range(); [INFO] [stderr] 182 | let vmrange = phdr.vm_range(); [INFO] [stderr] 183 | let tag: MetaData = phdr.into(); [INFO] [stderr] 184 | debug!("{:?}", range); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match goblin { [INFO] [stderr] 180 | | &Object::Elf(ref elf) => { [INFO] [stderr] 181 | | for phdr in &elf.program_headers { [INFO] [stderr] 182 | | let range = phdr.file_range(); [INFO] [stderr] ... | [INFO] [stderr] 203 | | _ => (), [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *goblin { [INFO] [stderr] 180 | Object::Elf(ref elf) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / if let &Some(ref name) = &self.name { [INFO] [stderr] 38 | | Some(name) [INFO] [stderr] 39 | | } else { [INFO] [stderr] 40 | | None [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(ref name) = self.name { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match goblin { [INFO] [stderr] 180 | | &Object::Elf(ref elf) => { [INFO] [stderr] 181 | | for phdr in &elf.program_headers { [INFO] [stderr] 182 | | let range = phdr.file_range(); [INFO] [stderr] ... | [INFO] [stderr] 203 | | _ => (), [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | if let &Object::Elf(ref elf) = goblin { [INFO] [stderr] 180 | for phdr in &elf.program_headers { [INFO] [stderr] 181 | let range = phdr.file_range(); [INFO] [stderr] 182 | let vmrange = phdr.vm_range(); [INFO] [stderr] 183 | let tag: MetaData = phdr.into(); [INFO] [stderr] 184 | debug!("{:?}", range); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match goblin { [INFO] [stderr] 180 | | &Object::Elf(ref elf) => { [INFO] [stderr] 181 | | for phdr in &elf.program_headers { [INFO] [stderr] 182 | | let range = phdr.file_range(); [INFO] [stderr] ... | [INFO] [stderr] 203 | | _ => (), [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *goblin { [INFO] [stderr] 180 | Object::Elf(ref elf) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.27s [INFO] running `"docker" "inspect" "e4cfed3cb02fc3dad6e1750504b78e98a0ab3216949bc2d6d71137b4e14b714b"` [INFO] running `"docker" "rm" "-f" "e4cfed3cb02fc3dad6e1750504b78e98a0ab3216949bc2d6d71137b4e14b714b"` [INFO] [stdout] e4cfed3cb02fc3dad6e1750504b78e98a0ab3216949bc2d6d71137b4e14b714b