[INFO] crate metadeps 1.1.2 is already in cache
[INFO] extracting crate metadeps 1.1.2 into work/ex/clippy-test-run/sources/stable/reg/metadeps/1.1.2
[INFO] extracting crate metadeps 1.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metadeps/1.1.2
[INFO] validating manifest of metadeps-1.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of metadeps-1.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing metadeps-1.1.2
[INFO] finished frobbing metadeps-1.1.2
[INFO] frobbed toml for metadeps-1.1.2 written to work/ex/clippy-test-run/sources/stable/reg/metadeps/1.1.2/Cargo.toml
[INFO] started frobbing metadeps-1.1.2
[INFO] finished frobbing metadeps-1.1.2
[INFO] frobbed toml for metadeps-1.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metadeps/1.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting metadeps-1.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/metadeps/1.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9d17df9d12bf3e52ed561acd343652afc5b17582bd6efaf6bfd44c5ed4a80ec3
[INFO] running `"docker" "start" "-a" "9d17df9d12bf3e52ed561acd343652afc5b17582bd6efaf6bfd44c5ed4a80ec3"`
[INFO] [stderr]     Checking toml v0.2.1
[INFO] [stderr]     Checking pkg-config v0.3.14
[INFO] [stderr]     Checking error-chain v0.10.0
[INFO] [stderr]     Checking metadeps v1.1.2 (/opt/crater/workdir)
[INFO] [stderr] error: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:50:38
[INFO] [stderr]    |
[INFO] [stderr] 50 |       let meta = try!(toml.lookup(key).ok_or(
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 51 | |         format!("No {} in {}", key, path.display())
[INFO] [stderr] 52 | |     ));
[INFO] [stderr]    | |_____^ help: try this: `ok_or_else(|| format!("No {} in {}", key, path.display()))`
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | #![deny(missing_docs, warnings)]
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:53:38
[INFO] [stderr]    |
[INFO] [stderr] 53 |       let table = try!(meta.as_table().ok_or(
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 54 | |         format!("{} not a table in {}", key, path.display())
[INFO] [stderr] 55 | |     ));
[INFO] [stderr]    | |_____^ help: try this: `ok_or_else(|| format!("{} not a table in {}", key, path.display()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/lib.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let ref version = match value {
[INFO] [stderr]    |             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | #![deny(missing_docs, warnings)]
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::toplevel_ref_arg)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let version = &(match value {
[INFO] [stderr] 59 |             &toml::Value::String(ref s) => s,
[INFO] [stderr] 60 |             &toml::Value::Table(ref t) => {
[INFO] [stderr] 61 |                 let mut feature = None;
[INFO] [stderr] 62 |                 let mut version = None;
[INFO] [stderr] 63 |                 for (tname, tvalue) in t {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:58:27
[INFO] [stderr]    |
[INFO] [stderr] 58 |           let ref version = match value {
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 59 | |             &toml::Value::String(ref s) => s,
[INFO] [stderr] 60 | |             &toml::Value::Table(ref t) => {
[INFO] [stderr] 61 | |                 let mut feature = None;
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |             _ => bail!("{}.{} not a string or table", key, name),
[INFO] [stderr] 79 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | #![deny(missing_docs, warnings)]
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::match_ref_pats)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let ref version = match *value {
[INFO] [stderr] 59 |             toml::Value::String(ref s) => s,
[INFO] [stderr] 60 |             toml::Value::Table(ref t) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:76:30
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 try!(version.ok_or(format!("No version in {}.{}", key, name)))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("No version in {}.{}", key, name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `metadeps`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:50:38
[INFO] [stderr]    |
[INFO] [stderr] 50 |       let meta = try!(toml.lookup(key).ok_or(
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 51 | |         format!("No {} in {}", key, path.display())
[INFO] [stderr] 52 | |     ));
[INFO] [stderr]    | |_____^ help: try this: `ok_or_else(|| format!("No {} in {}", key, path.display()))`
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | #![deny(missing_docs, warnings)]
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:53:38
[INFO] [stderr]    |
[INFO] [stderr] 53 |       let table = try!(meta.as_table().ok_or(
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 54 | |         format!("{} not a table in {}", key, path.display())
[INFO] [stderr] 55 | |     ));
[INFO] [stderr]    | |_____^ help: try this: `ok_or_else(|| format!("{} not a table in {}", key, path.display()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/lib.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let ref version = match value {
[INFO] [stderr]    |             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | #![deny(missing_docs, warnings)]
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::toplevel_ref_arg)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let version = &(match value {
[INFO] [stderr] 59 |             &toml::Value::String(ref s) => s,
[INFO] [stderr] 60 |             &toml::Value::Table(ref t) => {
[INFO] [stderr] 61 |                 let mut feature = None;
[INFO] [stderr] 62 |                 let mut version = None;
[INFO] [stderr] 63 |                 for (tname, tvalue) in t {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] error: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:58:27
[INFO] [stderr]    |
[INFO] [stderr] 58 |           let ref version = match value {
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 59 | |             &toml::Value::String(ref s) => s,
[INFO] [stderr] 60 | |             &toml::Value::Table(ref t) => {
[INFO] [stderr] 61 | |                 let mut feature = None;
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |             _ => bail!("{}.{} not a string or table", key, name),
[INFO] [stderr] 79 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:13:23
[INFO] [stderr]    |
[INFO] [stderr] 13 | #![deny(missing_docs, warnings)]
[INFO] [stderr]    |                       ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::match_ref_pats)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let ref version = match *value {
[INFO] [stderr] 59 |             toml::Value::String(ref s) => s,
[INFO] [stderr] 60 |             toml::Value::Table(ref t) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:76:30
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 try!(version.ok_or(format!("No version in {}.{}", key, name)))
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("No version in {}.{}", key, name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `metadeps`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "9d17df9d12bf3e52ed561acd343652afc5b17582bd6efaf6bfd44c5ed4a80ec3"`
[INFO] running `"docker" "rm" "-f" "9d17df9d12bf3e52ed561acd343652afc5b17582bd6efaf6bfd44c5ed4a80ec3"`
[INFO] [stdout] 9d17df9d12bf3e52ed561acd343652afc5b17582bd6efaf6bfd44c5ed4a80ec3