[INFO] crate metacpan_api 0.4.0 is already in cache [INFO] extracting crate metacpan_api 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/metacpan_api/0.4.0 [INFO] extracting crate metacpan_api 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metacpan_api/0.4.0 [INFO] validating manifest of metacpan_api-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of metacpan_api-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing metacpan_api-0.4.0 [INFO] finished frobbing metacpan_api-0.4.0 [INFO] frobbed toml for metacpan_api-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/metacpan_api/0.4.0/Cargo.toml [INFO] started frobbing metacpan_api-0.4.0 [INFO] finished frobbing metacpan_api-0.4.0 [INFO] frobbed toml for metacpan_api-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metacpan_api/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting metacpan_api-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/metacpan_api/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6572e279340cd5d3fd7ec75f9ad8c90a6942955ca2ec27f984b6a3e4899aafa [INFO] running `"docker" "start" "-a" "c6572e279340cd5d3fd7ec75f9ad8c90a6942955ca2ec27f984b6a3e4899aafa"` [INFO] [stderr] Checking metacpan_api v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `SyncClient` [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn new() -> Self { [INFO] [stderr] 101 | | SyncClient { [INFO] [stderr] 102 | | client: reqwest::Client::new(), [INFO] [stderr] 103 | | base_url: Url::parse("https://fastapi.metacpan.org/v1/").unwrap(), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | impl Default for SyncClient { [INFO] [stderr] 97 | fn default() -> Self { [INFO] [stderr] 98 | Self::new() [INFO] [stderr] 99 | } [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:146:39 [INFO] [stderr] | [INFO] [stderr] 146 | let url = self.base_url.join(&("module/".to_string() + &name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `SyncClient` [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | / pub fn new() -> Self { [INFO] [stderr] 101 | | SyncClient { [INFO] [stderr] 102 | | client: reqwest::Client::new(), [INFO] [stderr] 103 | | base_url: Url::parse("https://fastapi.metacpan.org/v1/").unwrap(), [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | impl Default for SyncClient { [INFO] [stderr] 97 | fn default() -> Self { [INFO] [stderr] 98 | Self::new() [INFO] [stderr] 99 | } [INFO] [stderr] 100 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:146:39 [INFO] [stderr] | [INFO] [stderr] 146 | let url = self.base_url.join(&("module/".to_string() + &name))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | assert!(perl_info.unwrap().name.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!perl_info.unwrap().name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.65s [INFO] running `"docker" "inspect" "c6572e279340cd5d3fd7ec75f9ad8c90a6942955ca2ec27f984b6a3e4899aafa"` [INFO] running `"docker" "rm" "-f" "c6572e279340cd5d3fd7ec75f9ad8c90a6942955ca2ec27f984b6a3e4899aafa"` [INFO] [stdout] c6572e279340cd5d3fd7ec75f9ad8c90a6942955ca2ec27f984b6a3e4899aafa