[INFO] crate message_verifier 1.1.0 is already in cache [INFO] extracting crate message_verifier 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/message_verifier/1.1.0 [INFO] extracting crate message_verifier 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/message_verifier/1.1.0 [INFO] validating manifest of message_verifier-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of message_verifier-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing message_verifier-1.1.0 [INFO] finished frobbing message_verifier-1.1.0 [INFO] frobbed toml for message_verifier-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/message_verifier/1.1.0/Cargo.toml [INFO] started frobbing message_verifier-1.1.0 [INFO] finished frobbing message_verifier-1.1.0 [INFO] frobbed toml for message_verifier-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/message_verifier/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting message_verifier-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/message_verifier/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f227dda7b0f84d2afc4bf6890aff5db7acfae6f65996649861bab427b60d5bc [INFO] running `"docker" "start" "-a" "7f227dda7b0f84d2afc4bf6890aff5db7acfae6f65996649861bab427b60d5bc"` [INFO] [stderr] Checking message_verifier v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/lib.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:142:35 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn create_derived_keys(salts: &Vec<&str>, secret: &str, key_params: DerivedKeyParams) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match self.is_valid_message(encoded_data, signature) { [INFO] [stderr] 201 | | true => Ok(encoded_data.from_base64()?), [INFO] [stderr] 202 | | false => bail!(ErrorKind::InvalidSignature) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_valid_message(encoded_data, signature) { Ok(encoded_data.from_base64()?) } else { bail!(ErrorKind::InvalidSignature) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:285:41 [INFO] [stderr] | [INFO] [stderr] 285 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:315:42 [INFO] [stderr] | [INFO] [stderr] 315 | cipher_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:369:93 [INFO] [stderr] | [INFO] [stderr] 369 | let mut decryptor = AesGcm::new(self.key_size, &self.secret_key[0..32], &iv[0..12], &vec![0; 0]); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[0; 0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | / match decryptor.decrypt(&cipher_text, &mut output, &auth_tag) { [INFO] [stderr] 373 | | true => Ok(output), [INFO] [stderr] 374 | | false => bail!(ErrorKind::InvalidMessage) [INFO] [stderr] 375 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if decryptor.decrypt(&cipher_text, &mut output, &auth_tag) { Ok(output) } else { bail!(ErrorKind::InvalidMessage) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:142:35 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn create_derived_keys(salts: &Vec<&str>, secret: &str, key_params: DerivedKeyParams) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match self.is_valid_message(encoded_data, signature) { [INFO] [stderr] 201 | | true => Ok(encoded_data.from_base64()?), [INFO] [stderr] 202 | | false => bail!(ErrorKind::InvalidSignature) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.is_valid_message(encoded_data, signature) { Ok(encoded_data.from_base64()?) } else { bail!(ErrorKind::InvalidSignature) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:285:41 [INFO] [stderr] | [INFO] [stderr] 285 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:315:42 [INFO] [stderr] | [INFO] [stderr] 315 | cipher_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:369:93 [INFO] [stderr] | [INFO] [stderr] 369 | let mut decryptor = AesGcm::new(self.key_size, &self.secret_key[0..32], &iv[0..12], &vec![0; 0]); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[0; 0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:372:9 [INFO] [stderr] | [INFO] [stderr] 372 | / match decryptor.decrypt(&cipher_text, &mut output, &auth_tag) { [INFO] [stderr] 373 | | true => Ok(output), [INFO] [stderr] 374 | | false => bail!(ErrorKind::InvalidMessage) [INFO] [stderr] 375 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if decryptor.decrypt(&cipher_text, &mut output, &auth_tag) { Ok(output) } else { bail!(ErrorKind::InvalidMessage) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/aead_decrypt.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | Err(_) => panic!("Read failed"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> examples/verify_decrypt.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("Read failed") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.75s [INFO] running `"docker" "inspect" "7f227dda7b0f84d2afc4bf6890aff5db7acfae6f65996649861bab427b60d5bc"` [INFO] running `"docker" "rm" "-f" "7f227dda7b0f84d2afc4bf6890aff5db7acfae6f65996649861bab427b60d5bc"` [INFO] [stdout] 7f227dda7b0f84d2afc4bf6890aff5db7acfae6f65996649861bab427b60d5bc