[INFO] crate merkle_tree 0.1.0 is already in cache [INFO] extracting crate merkle_tree 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/merkle_tree/0.1.0 [INFO] extracting crate merkle_tree 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/merkle_tree/0.1.0 [INFO] validating manifest of merkle_tree-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of merkle_tree-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing merkle_tree-0.1.0 [INFO] finished frobbing merkle_tree-0.1.0 [INFO] frobbed toml for merkle_tree-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/merkle_tree/0.1.0/Cargo.toml [INFO] started frobbing merkle_tree-0.1.0 [INFO] finished frobbing merkle_tree-0.1.0 [INFO] frobbed toml for merkle_tree-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/merkle_tree/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting merkle_tree-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/merkle_tree/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c8af341dc80c2b0ad1a4c7a3899041f91769dddcade9c4f51ea811ed1cdf466 [INFO] running `"docker" "start" "-a" "5c8af341dc80c2b0ad1a4c7a3899041f91769dddcade9c4f51ea811ed1cdf466"` [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking merkle_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/merkle_tree.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/merkle_tree.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/merkle_tree.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/merkle_tree.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/merkle_tree.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | layers: layers, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/merkle_tree.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/merkle_tree.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if layers_last_index >= current_layer_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::int_plus_one)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 166 | if layers_last_index > current_layer_index { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/merkle_tree.rs:207:20 [INFO] [stderr] | [INFO] [stderr] 207 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 208 | | if self.layers[layer_index].len() % 2 == 1 { [INFO] [stderr] 209 | | let last_node_index = self.layers[layer_index].len() - 1; [INFO] [stderr] 210 | | let last_node = self.layers[layer_index][last_node_index]; [INFO] [stderr] ... | [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | } else if self.layers[layer_index].len() % 2 == 1 { [INFO] [stderr] 208 | let last_node_index = self.layers[layer_index].len() - 1; [INFO] [stderr] 209 | let last_node = self.layers[layer_index][last_node_index]; [INFO] [stderr] 210 | let new_node = hash_leaf(&last_node); [INFO] [stderr] 211 | self.layers[layer_index + 1].push(new_node); [INFO] [stderr] 212 | self.recursive_repair_branch(layer_index + 1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/merkle_tree.rs:268:17 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(vec![root_hash]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec![root_hash])` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/merkle_tree.rs:270:17 [INFO] [stderr] | [INFO] [stderr] 270 | return Err("Tree invalidate."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Tree invalidate.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/merkle_tree.rs:317:17 [INFO] [stderr] | [INFO] [stderr] 317 | return Err("Tree invalidate."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Tree invalidate.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `merkle_tree`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/merkle_tree.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if layers_last_index >= current_layer_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::int_plus_one)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 166 | if layers_last_index > current_layer_index { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/merkle_tree.rs:207:20 [INFO] [stderr] | [INFO] [stderr] 207 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 208 | | if self.layers[layer_index].len() % 2 == 1 { [INFO] [stderr] 209 | | let last_node_index = self.layers[layer_index].len() - 1; [INFO] [stderr] 210 | | let last_node = self.layers[layer_index][last_node_index]; [INFO] [stderr] ... | [INFO] [stderr] 231 | | } [INFO] [stderr] 232 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 207 | } else if self.layers[layer_index].len() % 2 == 1 { [INFO] [stderr] 208 | let last_node_index = self.layers[layer_index].len() - 1; [INFO] [stderr] 209 | let last_node = self.layers[layer_index][last_node_index]; [INFO] [stderr] 210 | let new_node = hash_leaf(&last_node); [INFO] [stderr] 211 | self.layers[layer_index + 1].push(new_node); [INFO] [stderr] 212 | self.recursive_repair_branch(layer_index + 1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/merkle_tree.rs:268:17 [INFO] [stderr] | [INFO] [stderr] 268 | return Ok(vec![root_hash]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec![root_hash])` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/merkle_tree.rs:270:17 [INFO] [stderr] | [INFO] [stderr] 270 | return Err("Tree invalidate."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Tree invalidate.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/merkle_tree.rs:317:17 [INFO] [stderr] | [INFO] [stderr] 317 | return Err("Tree invalidate."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Tree invalidate.")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `merkle_tree`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5c8af341dc80c2b0ad1a4c7a3899041f91769dddcade9c4f51ea811ed1cdf466"` [INFO] running `"docker" "rm" "-f" "5c8af341dc80c2b0ad1a4c7a3899041f91769dddcade9c4f51ea811ed1cdf466"` [INFO] [stdout] 5c8af341dc80c2b0ad1a4c7a3899041f91769dddcade9c4f51ea811ed1cdf466