[INFO] crate merkle-sha3 0.1.0 is already in cache [INFO] extracting crate merkle-sha3 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/merkle-sha3/0.1.0 [INFO] extracting crate merkle-sha3 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/merkle-sha3/0.1.0 [INFO] validating manifest of merkle-sha3-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of merkle-sha3-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing merkle-sha3-0.1.0 [INFO] finished frobbing merkle-sha3-0.1.0 [INFO] frobbed toml for merkle-sha3-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/merkle-sha3/0.1.0/Cargo.toml [INFO] started frobbing merkle-sha3-0.1.0 [INFO] finished frobbing merkle-sha3-0.1.0 [INFO] frobbed toml for merkle-sha3-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/merkle-sha3/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting merkle-sha3-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/merkle-sha3/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75717b210849eeba90a688e4db47922bfa8ac2efeee1cefa4521404be9e8877d [INFO] running `"docker" "start" "-a" "75717b210849eeba90a688e4db47922bfa8ac2efeee1cefa4521404be9e8877d"` [INFO] [stderr] Checking merkle-sha3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | count: count [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | root_hash: root_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | lemma: lemma, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lemma` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | sibling_hash: sibling_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sibling_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | algorithm: algorithm, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `algorithm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/merkletree.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | count: count [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | root_hash: root_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | lemma: lemma, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lemma` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/proof.rs:134:21 [INFO] [stderr] | [INFO] [stderr] 134 | sibling_hash: sibling_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sibling_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | zero_values: zero_values, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zero_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tests.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | one_values: one_values [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `one_values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tests.rs:55:49 [INFO] [stderr] | [INFO] [stderr] 55 | let root_hash: [u8; 32] = digest.hash_leaf(&"hello, world".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello, world"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in values.enumerate()` or similar iterators [INFO] [stderr] --> src/tests.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | for value in values { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/tests.rs:194:19 [INFO] [stderr] | [INFO] [stderr] 194 | let iter = tree.iter().map(|x| x.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tree.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/tests.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | let iter = tree.into_iter().map(|x| x.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tree.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error[E0464]: multiple matching crates for `rand` [INFO] [stderr] --> benches/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | extern crate rand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: candidates: [INFO] [stderr] crate `rand`: /opt/crater/rustup-home/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librand-8bce58946f7738c6.rlib [INFO] [stderr] crate `rand`: /opt/crater/rustup-home/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/librand-f36230025ea6075e.rlib [INFO] [stderr] [INFO] [stderr] error[E0463]: can't find crate for `rand` [INFO] [stderr] --> benches/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | extern crate rand; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0463, E0464. [INFO] [stderr] For more information about an error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `merkle-sha3`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "75717b210849eeba90a688e4db47922bfa8ac2efeee1cefa4521404be9e8877d"` [INFO] running `"docker" "rm" "-f" "75717b210849eeba90a688e4db47922bfa8ac2efeee1cefa4521404be9e8877d"` [INFO] [stdout] 75717b210849eeba90a688e4db47922bfa8ac2efeee1cefa4521404be9e8877d