[INFO] crate mercury 0.1.0 is already in cache [INFO] extracting crate mercury 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mercury/0.1.0 [INFO] extracting crate mercury 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mercury/0.1.0 [INFO] validating manifest of mercury-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mercury-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mercury-0.1.0 [INFO] finished frobbing mercury-0.1.0 [INFO] frobbed toml for mercury-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mercury/0.1.0/Cargo.toml [INFO] started frobbing mercury-0.1.0 [INFO] finished frobbing mercury-0.1.0 [INFO] frobbed toml for mercury-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mercury/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mercury-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mercury/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86171039b64bfe16788c95d4771966d6aca99e348ceb0a448b5881759258e7f5 [INFO] running `"docker" "start" "-a" "86171039b64bfe16788c95d4771966d6aca99e348ceb0a448b5881759258e7f5"` [INFO] [stderr] Checking mercury v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | const ENDPOINT: &'static str = "https://mercury.postlight.com/parser"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:278:44 [INFO] [stderr] | [INFO] [stderr] 278 | #[cfg_attr(feature = "cargo-clippy", allow(large_enum_variant))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | const ENDPOINT: &'static str = "https://mercury.postlight.com/parser"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `large_enum_variant` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:278:44 [INFO] [stderr] | [INFO] [stderr] 278 | #[cfg_attr(feature = "cargo-clippy", allow(large_enum_variant))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::large_enum_variant` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::handle' [INFO] [stderr] --> src/lib.rs:159:23 [INFO] [stderr] | [INFO] [stderr] 159 | self.client().handle() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item '>::handle' [INFO] [stderr] --> src/lib.rs:159:23 [INFO] [stderr] | [INFO] [stderr] 159 | self.client().handle() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/article.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn is_ltr(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/article.rs:96:19 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn is_rtl(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/article.rs:73:19 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn is_ltr(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/article.rs:96:19 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn is_rtl(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.20s [INFO] running `"docker" "inspect" "86171039b64bfe16788c95d4771966d6aca99e348ceb0a448b5881759258e7f5"` [INFO] running `"docker" "rm" "-f" "86171039b64bfe16788c95d4771966d6aca99e348ceb0a448b5881759258e7f5"` [INFO] [stdout] 86171039b64bfe16788c95d4771966d6aca99e348ceb0a448b5881759258e7f5