[INFO] crate memmem 0.1.1 is already in cache [INFO] extracting crate memmem 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/memmem/0.1.1 [INFO] extracting crate memmem 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/memmem/0.1.1 [INFO] validating manifest of memmem-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of memmem-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing memmem-0.1.1 [INFO] finished frobbing memmem-0.1.1 [INFO] frobbed toml for memmem-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/memmem/0.1.1/Cargo.toml [INFO] started frobbing memmem-0.1.1 [INFO] finished frobbing memmem-0.1.1 [INFO] frobbed toml for memmem-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/memmem/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting memmem-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/memmem/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9793a1551245781acb9211781bb6a785ccc5a9f32d7471dcce11b2e3c6666b9c [INFO] running `"docker" "start" "-a" "9793a1551245781acb9211781bb6a785ccc5a9f32d7471dcce11b2e3c6666b9c"` [INFO] [stderr] Checking memmem v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | crit_pos: crit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `crit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | period: period, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | crit_pos: crit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `crit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | crit_pos: crit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `crit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | period: period, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/two_way.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | crit_pos: crit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `crit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/two_way.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'b>(needle: &'b [u8]) -> TwoWaySearcher<'b> { [INFO] [stderr] 137 | | if needle.is_empty() { [INFO] [stderr] 138 | | return TwoWaySearcher { [INFO] [stderr] 139 | | needle: needle, [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/two_way.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if &needle[..crit_pos] == &needle[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 166 | if needle[..crit_pos] == needle[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] ... [INFO] [stderr] 23 | search!(empty_1, "", "", Some(0)); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] ... [INFO] [stderr] 23 | search!(empty_1, "", "", Some(0)); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] ... [INFO] [stderr] 24 | search!(empty_2, "", "something", Some(0)); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"something"` [INFO] [stderr] ... [INFO] [stderr] 24 | search!(empty_2, "", "something", Some(0)); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaaaaaaa"` [INFO] [stderr] ... [INFO] [stderr] 26 | search!(periodic_1, "aaaaaaaa", "aaaaaabaaaaaabaaaaaabaaaaaaaa", Some(21)); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaaaaabaaaaaabaaaaaabaaaaaaaa"` [INFO] [stderr] ... [INFO] [stderr] 26 | search!(periodic_1, "aaaaaaaa", "aaaaaabaaaaaabaaaaaabaaaaaaaa", Some(21)); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaaaaaaa"` [INFO] [stderr] ... [INFO] [stderr] 27 | search!(periodic_2, "aaaaaaaa", "aaaaaabaaaaaabaaaaaabaaaaaaab", None); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaaaaabaaaaaabaaaaaabaaaaaaab"` [INFO] [stderr] ... [INFO] [stderr] 27 | search!(periodic_2, "aaaaaaaa", "aaaaaabaaaaaabaaaaaabaaaaaaab", None); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcabc"` [INFO] [stderr] ... [INFO] [stderr] 28 | search!(periodic_3, "abcabc", "abcabaabcabaabcabaabcabc", Some(18)); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcabaabcabaabcabaabcabc"` [INFO] [stderr] ... [INFO] [stderr] 28 | search!(periodic_3, "abcabc", "abcabaabcabaabcabaabcabc", Some(18)); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcabc"` [INFO] [stderr] ... [INFO] [stderr] 29 | search!(periodic_4, "abcabc", "abcabaabcabaabcabaabcabd", None); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcabaabcabaabcabaabcabd"` [INFO] [stderr] ... [INFO] [stderr] 29 | search!(periodic_4, "abcabc", "abcabaabcabaabcabaabcabd", None); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abcabcabc"` [INFO] [stderr] ... [INFO] [stderr] 30 | search!(periodic_5, "abcabcabc", "bbcabcabcabc", Some(3)); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"bbcabcabcabc"` [INFO] [stderr] ... [INFO] [stderr] 30 | search!(periodic_5, "abcabcabc", "bbcabcabcabc", Some(3)); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"dog"` [INFO] [stderr] ... [INFO] [stderr] 32 | search!(aperiodic_1, "dog", "The quick brown fox jumped over the lazy dog.", Some(41)); [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"The quick brown fox jumped over the lazy dog."` [INFO] [stderr] ... [INFO] [stderr] 32 | search!(aperiodic_1, "dog", "The quick brown fox jumped over the lazy dog.", Some(41)); [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"doggy"` [INFO] [stderr] ... [INFO] [stderr] 33 | search!(aperiodic_2, "doggy", "The quick brown fox jumped over the lazy dog.", None); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"The quick brown fox jumped over the lazy dog."` [INFO] [stderr] ... [INFO] [stderr] 33 | search!(aperiodic_2, "doggy", "The quick brown fox jumped over the lazy dog.", None); [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:16:48 [INFO] [stderr] | [INFO] [stderr] 16 | let searcher = TwoWaySearcher::new($needle.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaaaaaaa"` [INFO] [stderr] ... [INFO] [stderr] 35 | search!(skip, "aaaaaaaa", "aaaaaaabaaaaaaabaaaaaaab", None); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/tests.rs:18:43 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(searcher.search_in($hay.as_bytes()), $result); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"aaaaaaabaaaaaaabaaaaaaab"` [INFO] [stderr] ... [INFO] [stderr] 35 | search!(skip, "aaaaaaaa", "aaaaaaabaaaaaaabaaaaaaab", None); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/two_way.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'b>(needle: &'b [u8]) -> TwoWaySearcher<'b> { [INFO] [stderr] 137 | | if needle.is_empty() { [INFO] [stderr] 138 | | return TwoWaySearcher { [INFO] [stderr] 139 | | needle: needle, [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/two_way.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if &needle[..crit_pos] == &needle[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 166 | if needle[..crit_pos] == needle[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.94s [INFO] running `"docker" "inspect" "9793a1551245781acb9211781bb6a785ccc5a9f32d7471dcce11b2e3c6666b9c"` [INFO] running `"docker" "rm" "-f" "9793a1551245781acb9211781bb6a785ccc5a9f32d7471dcce11b2e3c6666b9c"` [INFO] [stdout] 9793a1551245781acb9211781bb6a785ccc5a9f32d7471dcce11b2e3c6666b9c