[INFO] crate median_three_quicksort 0.0.1 is already in cache [INFO] extracting crate median_three_quicksort 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/median_three_quicksort/0.0.1 [INFO] extracting crate median_three_quicksort 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/median_three_quicksort/0.0.1 [INFO] validating manifest of median_three_quicksort-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of median_three_quicksort-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing median_three_quicksort-0.0.1 [INFO] finished frobbing median_three_quicksort-0.0.1 [INFO] frobbed toml for median_three_quicksort-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/median_three_quicksort/0.0.1/Cargo.toml [INFO] started frobbing median_three_quicksort-0.0.1 [INFO] finished frobbing median_three_quicksort-0.0.1 [INFO] frobbed toml for median_three_quicksort-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/median_three_quicksort/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting median_three_quicksort-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/median_three_quicksort/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 674966d113338a226775e17f2be801b86e458832da2f4d615ce10060526a6a62 [INFO] running `"docker" "start" "-a" "674966d113338a226775e17f2be801b86e458832da2f4d615ce10060526a6a62"` [INFO] [stderr] Checking median_three_quicksort v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/quicksort.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pivot [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/quicksort.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let pivot = match pivot { [INFO] [stderr] | _________________^ [INFO] [stderr] 50 | | 0 => 1, [INFO] [stderr] 51 | | _ => pivot [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/quicksort.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | for i in left+1..right+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left+1..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/quicksort.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | pivot [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/quicksort.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let pivot = match pivot { [INFO] [stderr] | _________________^ [INFO] [stderr] 50 | | 0 => 1, [INFO] [stderr] 51 | | _ => pivot [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/quicksort.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | for i in left+1..right+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left+1..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "674966d113338a226775e17f2be801b86e458832da2f4d615ce10060526a6a62"` [INFO] running `"docker" "rm" "-f" "674966d113338a226775e17f2be801b86e458832da2f4d615ce10060526a6a62"` [INFO] [stdout] 674966d113338a226775e17f2be801b86e458832da2f4d615ce10060526a6a62