[INFO] crate median 0.3.0 is already in cache [INFO] extracting crate median 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/median/0.3.0 [INFO] extracting crate median 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/median/0.3.0 [INFO] validating manifest of median-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of median-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing median-0.3.0 [INFO] finished frobbing median-0.3.0 [INFO] frobbed toml for median-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/median/0.3.0/Cargo.toml [INFO] started frobbing median-0.3.0 [INFO] finished frobbing median-0.3.0 [INFO] frobbed toml for median-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/median/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting median-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/median/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6a9c359cb14fb233fa3860f787d8f4017a683cc23af1ee22ed4aabf5eff3b22 [INFO] running `"docker" "start" "-a" "d6a9c359cb14fb233fa3860f787d8f4017a683cc23af1ee22ed4aabf5eff3b22"` [INFO] [stderr] Checking arraydeque v0.4.3 [INFO] [stderr] Checking median v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/heap.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `heap::Filter` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/heap.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Filter [INFO] [stderr] 44 | | where [INFO] [stderr] 45 | | T: Clone + PartialOrd, [INFO] [stderr] 46 | | { [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/heap.rs:168:42 [INFO] [stderr] | [INFO] [stderr] 168 | (index + 1 == self.len()) || !(v < value) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stack.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | cursor: self.cursor.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stack.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | head: self.head.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stack.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | median: self.median.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.median` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: item `stack::Filter` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/stack.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | / impl Filter [INFO] [stderr] 81 | | where [INFO] [stderr] 82 | | T: Clone + PartialOrd, [INFO] [stderr] 83 | | N: ArrayLength>, [INFO] [stderr] ... | [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stack::Filter` [INFO] [stderr] --> src/stack.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> Self { [INFO] [stderr] 87 | | let buffer = unsafe { [INFO] [stderr] 88 | | let mut builder = ArrayBuilder::new(); [INFO] [stderr] 89 | | { [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | impl Default for stack::Filter { [INFO] [stderr] 81 | fn default() -> Self { [INFO] [stderr] 82 | Self::new() [INFO] [stderr] 83 | } [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/stack.rs:92:47 [INFO] [stderr] | [INFO] [stderr] 92 | while let Some(destination) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for destination in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/stack.rs:214:42 [INFO] [stderr] | [INFO] [stderr] 214 | (index + 1 == self.len()) || !(v < value) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/heap.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type or module `fmt` [INFO] [stderr] --> benches/main.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | A::Item: PartialOrd + Clone + fmt::Debug, [INFO] [stderr] | ^^^ use of undeclared type or module `fmt` [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0433, E0554. [INFO] [stderr] For more information about an error, try `rustc --explain E0433`. [INFO] [stderr] error: Could not compile `median`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `heap::Filter` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/heap.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl Filter [INFO] [stderr] 44 | | where [INFO] [stderr] 45 | | T: Clone + PartialOrd, [INFO] [stderr] 46 | | { [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/heap.rs:168:42 [INFO] [stderr] | [INFO] [stderr] 168 | (index + 1 == self.len()) || !(v < value) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/heap.rs:421:22 [INFO] [stderr] | [INFO] [stderr] 421 | for input in vec![70, 50, 30, 10, 20, 40, 60] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[70, 50, 30, 10, 20, 40, 60]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stack.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | cursor: self.cursor.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stack.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | head: self.head.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.head` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/stack.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | median: self.median.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.median` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: item `stack::Filter` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/stack.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | / impl Filter [INFO] [stderr] 81 | | where [INFO] [stderr] 82 | | T: Clone + PartialOrd, [INFO] [stderr] 83 | | N: ArrayLength>, [INFO] [stderr] ... | [INFO] [stderr] 334 | | } [INFO] [stderr] 335 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stack::Filter` [INFO] [stderr] --> src/stack.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn new() -> Self { [INFO] [stderr] 87 | | let buffer = unsafe { [INFO] [stderr] 88 | | let mut builder = ArrayBuilder::new(); [INFO] [stderr] 89 | | { [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | impl Default for stack::Filter { [INFO] [stderr] 81 | fn default() -> Self { [INFO] [stderr] 82 | Self::new() [INFO] [stderr] 83 | } [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/stack.rs:92:47 [INFO] [stderr] | [INFO] [stderr] 92 | while let Some(destination) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for destination in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/stack.rs:214:42 [INFO] [stderr] | [INFO] [stderr] 214 | (index + 1 == self.len()) || !(v < value) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/stack.rs:469:22 [INFO] [stderr] | [INFO] [stderr] 469 | for input in vec![70, 50, 30, 10, 20, 40, 60] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[70, 50, 30, 10, 20, 40, 60]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "d6a9c359cb14fb233fa3860f787d8f4017a683cc23af1ee22ed4aabf5eff3b22"` [INFO] running `"docker" "rm" "-f" "d6a9c359cb14fb233fa3860f787d8f4017a683cc23af1ee22ed4aabf5eff3b22"` [INFO] [stdout] d6a9c359cb14fb233fa3860f787d8f4017a683cc23af1ee22ed4aabf5eff3b22