[INFO] crate media-type 0.4.0-unstable is already in cache [INFO] extracting crate media-type 0.4.0-unstable into work/ex/clippy-test-run/sources/stable/reg/media-type/0.4.0-unstable [INFO] extracting crate media-type 0.4.0-unstable into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/media-type/0.4.0-unstable [INFO] validating manifest of media-type-0.4.0-unstable on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of media-type-0.4.0-unstable on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing media-type-0.4.0-unstable [INFO] removed 0 missing tests [INFO] finished frobbing media-type-0.4.0-unstable [INFO] frobbed toml for media-type-0.4.0-unstable written to work/ex/clippy-test-run/sources/stable/reg/media-type/0.4.0-unstable/Cargo.toml [INFO] started frobbing media-type-0.4.0-unstable [INFO] removed 0 missing tests [INFO] finished frobbing media-type-0.4.0-unstable [INFO] frobbed toml for media-type-0.4.0-unstable written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/media-type/0.4.0-unstable/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting media-type-0.4.0-unstable against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/media-type/0.4.0-unstable:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45d11547947124b52a5e03234d369a42cf3f3c43e5975d77f3495994a492d1e5 [INFO] running `"docker" "start" "-a" "45d11547947124b52a5e03234d369a42cf3f3c43e5975d77f3495994a492d1e5"` [INFO] [stderr] Checking quoted-string v0.6.0 [INFO] [stderr] Checking lut v0.1.0-unstable [INFO] [stderr] Checking media-type-impl-utils v0.3.0-unstable [INFO] [stderr] Checking media-type v0.4.0-unstable (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spec/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / return Err(ErrorKind::UnquotedParamValue { [INFO] [stderr] 160 | | pos, cause: CoreError::InvalidChar [INFO] [stderr] 161 | | }.with_input(input)); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 159 | Err(ErrorKind::UnquotedParamValue { [INFO] [stderr] 160 | pos, cause: CoreError::InvalidChar [INFO] [stderr] 161 | }.with_input(input)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parse/parse_cfws.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / if input.as_bytes().get(offset + 1) == Some(&b'\n') { [INFO] [stderr] 165 | | if input.as_bytes().get(offset + 2).map(|bt|is_ws(*bt)).unwrap_or(false) { [INFO] [stderr] 166 | | return Ok(offset + 3) [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | if input.as_bytes().get(offset + 1) == Some(&b'\n') && input.as_bytes().get(offset + 2).map(|bt|is_ws(*bt)).unwrap_or(false) { [INFO] [stderr] 165 | return Ok(offset + 3) [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | return name == other_name && value == other_value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name == other_name && value == other_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:350:25 [INFO] [stderr] | [INFO] [stderr] 350 | / return value1 == other_value1 [INFO] [stderr] 351 | | && name2 == other_name2 && value2 == other_value2 [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 350 | value1 == other_value1 [INFO] [stderr] 351 | && name2 == other_name2 && value2 == other_value2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:353:25 [INFO] [stderr] | [INFO] [stderr] 353 | / return [INFO] [stderr] 354 | | name1 == other_name2 && value1 == other_value2 [INFO] [stderr] 355 | | && name2 == other_name1 && value2 == other_value1 [INFO] [stderr] | |_________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 353 | name1 == other_name2 && value1 == other_value2 [INFO] [stderr] 354 | && name2 == other_name1 && value2 == other_value1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spec/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / return Err(ErrorKind::UnquotedParamValue { [INFO] [stderr] 160 | | pos, cause: CoreError::InvalidChar [INFO] [stderr] 161 | | }.with_input(input)); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 159 | Err(ErrorKind::UnquotedParamValue { [INFO] [stderr] 160 | pos, cause: CoreError::InvalidChar [INFO] [stderr] 161 | }.with_input(input)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/parse/parse_cfws.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / if input.as_bytes().get(offset + 1) == Some(&b'\n') { [INFO] [stderr] 165 | | if input.as_bytes().get(offset + 2).map(|bt|is_ws(*bt)).unwrap_or(false) { [INFO] [stderr] 166 | | return Ok(offset + 3) [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | if input.as_bytes().get(offset + 1) == Some(&b'\n') && input.as_bytes().get(offset + 2).map(|bt|is_ws(*bt)).unwrap_or(false) { [INFO] [stderr] 165 | return Ok(offset + 3) [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | return name == other_name && value == other_value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name == other_name && value == other_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:350:25 [INFO] [stderr] | [INFO] [stderr] 350 | / return value1 == other_value1 [INFO] [stderr] 351 | | && name2 == other_name2 && value2 == other_value2 [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 350 | value1 == other_value1 [INFO] [stderr] 351 | && name2 == other_name2 && value2 == other_value2 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/media_type.rs:353:25 [INFO] [stderr] | [INFO] [stderr] 353 | / return [INFO] [stderr] 354 | | name1 == other_name2 && value1 == other_value2 [INFO] [stderr] 355 | | && name2 == other_name1 && value2 == other_value1 [INFO] [stderr] | |_________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 353 | name1 == other_name2 && value1 == other_value2 [INFO] [stderr] 354 | && name2 == other_name1 && value2 == other_value1 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match self { [INFO] [stderr] 68 | | &QuotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] 69 | | &UnquotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] 70 | | _ => None [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *self { [INFO] [stderr] 68 | QuotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] 69 | UnquotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/mod.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | let pos = end_idx.unwrap_or(input.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| input.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/impl_spec.rs:126:10 [INFO] [stderr] | [INFO] [stderr] 126 | .unwrap_or(input.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| input.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse/mod.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / let param_end_idx; [INFO] [stderr] 88 | | if input.as_bytes().get(param_value_start) == Some(&b'"') { [INFO] [stderr] 89 | | param_end_idx = at_pos!(param_value_start do S::parse_quoted_string | input); [INFO] [stderr] 90 | | } else { [INFO] [stderr] 91 | | param_end_idx = at_pos!(param_value_start do S::parse_unquoted_value | input); [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let param_end_idx = if input.as_bytes().get(param_value_start) == Some(&b'"') { $pfn(&$input[$offset..])? + $offset } else { $pfn(&$input[$offset..])? + $offset };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/media_type.rs:380:12 [INFO] [stderr] | [INFO] [stderr] 380 | if pres.params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pres.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error[E0463]: can't find crate for `mime` [INFO] [stderr] --> benches/parse.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | extern crate mime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `media-type`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0463]: can't find crate for `mime` [INFO] [stderr] --> benches/fmt.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | extern crate mime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ can't find crate [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0463`. [INFO] [stderr] error: Could not compile `media-type`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/cmp.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `media-type`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match self { [INFO] [stderr] 68 | | &QuotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] 69 | | &UnquotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] 70 | | _ => None [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *self { [INFO] [stderr] 68 | QuotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] 69 | UnquotedParamValue { ref cause, ..} => Some(cause as &StdError), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/spec/mod.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | let pos = end_idx.unwrap_or(input.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| input.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/impl_spec.rs:126:10 [INFO] [stderr] | [INFO] [stderr] 126 | .unwrap_or(input.len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| input.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parse/mod.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / let param_end_idx; [INFO] [stderr] 88 | | if input.as_bytes().get(param_value_start) == Some(&b'"') { [INFO] [stderr] 89 | | param_end_idx = at_pos!(param_value_start do S::parse_quoted_string | input); [INFO] [stderr] 90 | | } else { [INFO] [stderr] 91 | | param_end_idx = at_pos!(param_value_start do S::parse_unquoted_value | input); [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let param_end_idx = if input.as_bytes().get(param_value_start) == Some(&b'"') { $pfn(&$input[$offset..])? + $offset } else { $pfn(&$input[$offset..])? + $offset };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/media_type.rs:380:12 [INFO] [stderr] | [INFO] [stderr] 380 | if pres.params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pres.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "45d11547947124b52a5e03234d369a42cf3f3c43e5975d77f3495994a492d1e5"` [INFO] running `"docker" "rm" "-f" "45d11547947124b52a5e03234d369a42cf3f3c43e5975d77f3495994a492d1e5"` [INFO] [stdout] 45d11547947124b52a5e03234d369a42cf3f3c43e5975d77f3495994a492d1e5