[INFO] crate measure 1.1.3 is already in cache [INFO] extracting crate measure 1.1.3 into work/ex/clippy-test-run/sources/stable/reg/measure/1.1.3 [INFO] extracting crate measure 1.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/measure/1.1.3 [INFO] validating manifest of measure-1.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of measure-1.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing measure-1.1.3 [INFO] finished frobbing measure-1.1.3 [INFO] frobbed toml for measure-1.1.3 written to work/ex/clippy-test-run/sources/stable/reg/measure/1.1.3/Cargo.toml [INFO] started frobbing measure-1.1.3 [INFO] finished frobbing measure-1.1.3 [INFO] frobbed toml for measure-1.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/measure/1.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting measure-1.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/measure/1.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 291441eeac02a59397c954562a1e0a523e61aa879605eaa77f355ec726134b0a [INFO] running `"docker" "start" "-a" "291441eeac02a59397c954562a1e0a523e61aa879605eaa77f355ec726134b0a"` [INFO] [stderr] Checking measure v1.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/unit.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(Amount::auto_detect(1234567.0).unit, Unit::Mega); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_234_567.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/unit.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(Amount::auto_detect(1234567890.0).unit, Unit::Giga); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_234_567_890.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/unit.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(Amount::auto_detect(1234567890123.0).unit, Unit::Tera); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_234_567_890_123.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/unit.rs:122:54 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(format!("{}", Amount::auto_detect(200124.42)), "195.4 KiB"); [INFO] [stderr] | ^^^^^^^^^ help: consider: `200_124.42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/unit.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | Tera = 1 << 40, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unit.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | fn to_value(&self) -> UnitValue { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/unit.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | amount = amount / 1024.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount /= 1024.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `measure`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/unit.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | Tera = 1 << 40, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unit.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | fn to_value(&self) -> UnitValue { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/unit.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | amount = amount / 1024.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount /= 1024.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/unit.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(amount.bytes, 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/unit.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | assert_eq!(amount.bytes, 100.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `measure`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "291441eeac02a59397c954562a1e0a523e61aa879605eaa77f355ec726134b0a"` [INFO] running `"docker" "rm" "-f" "291441eeac02a59397c954562a1e0a523e61aa879605eaa77f355ec726134b0a"` [INFO] [stdout] 291441eeac02a59397c954562a1e0a523e61aa879605eaa77f355ec726134b0a