[INFO] crate mdt8 0.1.1 is already in cache
[INFO] extracting crate mdt8 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/mdt8/0.1.1
[INFO] extracting crate mdt8 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdt8/0.1.1
[INFO] validating manifest of mdt8-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mdt8-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mdt8-0.1.1
[INFO] finished frobbing mdt8-0.1.1
[INFO] frobbed toml for mdt8-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/mdt8/0.1.1/Cargo.toml
[INFO] started frobbing mdt8-0.1.1
[INFO] finished frobbing mdt8-0.1.1
[INFO] frobbed toml for mdt8-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdt8/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mdt8-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mdt8/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 74fd58f10680f038e68c6443520be2d0b8be51b626eef99d2cdddbee18c3c7c9
[INFO] running `"docker" "start" "-a" "74fd58f10680f038e68c6443520be2d0b8be51b626eef99d2cdddbee18c3c7c9"`
[INFO] [stderr]     Checking mdt8 v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/state.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/state.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         s
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/state.rs:132:17
[INFO] [stderr]     |
[INFO] [stderr] 132 |           let s = if goal.num_hours() < 1 {
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 133 | |             format!("{} minutes", goal.num_minutes())
[INFO] [stderr] 134 | |         } else {
[INFO] [stderr] 135 | |             format!("{} hours and {} minutes", goal.num_hours(), goal.num_minutes() - (goal.num_hours() * 60))
[INFO] [stderr] 136 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/state.rs:153:9
[INFO] [stderr]     |
[INFO] [stderr] 153 |         s
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/state.rs:148:17
[INFO] [stderr]     |
[INFO] [stderr] 148 |           let s = if today.num_hours() < 1 {
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 149 | |             format!("{} minutes", today.num_minutes())
[INFO] [stderr] 150 | |         } else {
[INFO] [stderr] 151 | |             format!("{} hours and {} minutes", today.num_hours(), today.num_minutes() - (today.num_hours() * 60))
[INFO] [stderr] 152 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/state.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/state.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         s
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/state.rs:132:17
[INFO] [stderr]     |
[INFO] [stderr] 132 |           let s = if goal.num_hours() < 1 {
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 133 | |             format!("{} minutes", goal.num_minutes())
[INFO] [stderr] 134 | |         } else {
[INFO] [stderr] 135 | |             format!("{} hours and {} minutes", goal.num_hours(), goal.num_minutes() - (goal.num_hours() * 60))
[INFO] [stderr] 136 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/state.rs:153:9
[INFO] [stderr]     |
[INFO] [stderr] 153 |         s
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/state.rs:148:17
[INFO] [stderr]     |
[INFO] [stderr] 148 |           let s = if today.num_hours() < 1 {
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 149 | |             format!("{} minutes", today.num_minutes())
[INFO] [stderr] 150 | |         } else {
[INFO] [stderr] 151 | |             format!("{} hours and {} minutes", today.num_hours(), today.num_minutes() - (today.num_hours() * 60))
[INFO] [stderr] 152 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/state.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match self.current_session_start {
[INFO] [stderr] 42 | |             Some(_) => true,
[INFO] [stderr] 43 | |             None => false
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^ help: try this: `self.current_session_start.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:52:12
[INFO] [stderr]    |
[INFO] [stderr] 52 |       if let Some(_) = matches.subcommand_matches("status") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 53 | |         return (config, Command::Status);
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("status").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:55:12
[INFO] [stderr]    |
[INFO] [stderr] 55 |       if let Some(_) = matches.subcommand_matches("start") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 56 | |         return (config, Command::Start);
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("start").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:58:12
[INFO] [stderr]    |
[INFO] [stderr] 58 |       if let Some(_) = matches.subcommand_matches("stop") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 59 | |         return (config, Command::Stop);
[INFO] [stderr] 60 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("stop").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:61:12
[INFO] [stderr]    |
[INFO] [stderr] 61 |       if let Some(_) = matches.subcommand_matches("cancel") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 62 | |         return (config, Command::Cancel);
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("cancel").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/state.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match self.current_session_start {
[INFO] [stderr] 42 | |             Some(_) => true,
[INFO] [stderr] 43 | |             None => false
[INFO] [stderr] 44 | |         }
[INFO] [stderr]    | |_________^ help: try this: `self.current_session_start.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:52:12
[INFO] [stderr]    |
[INFO] [stderr] 52 |       if let Some(_) = matches.subcommand_matches("status") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 53 | |         return (config, Command::Status);
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("status").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:55:12
[INFO] [stderr]    |
[INFO] [stderr] 55 |       if let Some(_) = matches.subcommand_matches("start") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 56 | |         return (config, Command::Start);
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("start").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:58:12
[INFO] [stderr]    |
[INFO] [stderr] 58 |       if let Some(_) = matches.subcommand_matches("stop") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 59 | |         return (config, Command::Stop);
[INFO] [stderr] 60 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("stop").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/cli.rs:61:12
[INFO] [stderr]    |
[INFO] [stderr] 61 |       if let Some(_) = matches.subcommand_matches("cancel") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 62 | |         return (config, Command::Cancel);
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("cancel").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.83s
[INFO] running `"docker" "inspect" "74fd58f10680f038e68c6443520be2d0b8be51b626eef99d2cdddbee18c3c7c9"`
[INFO] running `"docker" "rm" "-f" "74fd58f10680f038e68c6443520be2d0b8be51b626eef99d2cdddbee18c3c7c9"`
[INFO] [stdout] 74fd58f10680f038e68c6443520be2d0b8be51b626eef99d2cdddbee18c3c7c9