[INFO] crate mdns 0.3.0 is already in cache [INFO] extracting crate mdns 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/mdns/0.3.0 [INFO] extracting crate mdns 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdns/0.3.0 [INFO] validating manifest of mdns-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mdns-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mdns-0.3.0 [INFO] finished frobbing mdns-0.3.0 [INFO] frobbed toml for mdns-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/mdns/0.3.0/Cargo.toml [INFO] started frobbing mdns-0.3.0 [INFO] finished frobbing mdns-0.3.0 [INFO] frobbed toml for mdns-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdns/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mdns-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mdns/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe08c38774662aaf32e8070f19c123fbf940ad81a1010eb32bb934347eb3b010 [INFO] running `"docker" "start" "-a" "fe08c38774662aaf32e8070f19c123fbf940ad81a1010eb32bb934347eb3b010"` [INFO] [stderr] Checking dns-parser v0.8.0 [INFO] [stderr] Checking ifaces v0.1.0 [INFO] [stderr] Checking mdns v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mdns.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | const MULTICAST_ADDR: &'static str = "224.0.0.251"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mdns.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | const MULTICAST_ADDR: &'static str = "224.0.0.251"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mdns.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | fn new(interface_addr: &Ipv4Addr, io: &mut Io) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/response.rs:87:72 [INFO] [stderr] | [INFO] [stderr] 87 | RData::A(dns::rdata::a::Record(ref addr)) => RecordKind::A(addr.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/response.rs:88:81 [INFO] [stderr] | [INFO] [stderr] 88 | RData::AAAA(dns::rdata::aaaa::Record(ref addr)) => RecordKind::AAAA(addr.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mdns.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | fn new(interface_addr: &Ipv4Addr, io: &mut Io) -> Result { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/response.rs:87:72 [INFO] [stderr] | [INFO] [stderr] 87 | RData::A(dns::rdata::a::Record(ref addr)) => RecordKind::A(addr.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/response.rs:88:81 [INFO] [stderr] | [INFO] [stderr] 88 | RData::AAAA(dns::rdata::aaaa::Record(ref addr)) => RecordKind::AAAA(addr.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/chromecast_discovery.rs:6:22 [INFO] [stderr] | [INFO] [stderr] 6 | const SERVICE_NAME: &'static str = "_googlecast._tcp.local"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.89s [INFO] running `"docker" "inspect" "fe08c38774662aaf32e8070f19c123fbf940ad81a1010eb32bb934347eb3b010"` [INFO] running `"docker" "rm" "-f" "fe08c38774662aaf32e8070f19c123fbf940ad81a1010eb32bb934347eb3b010"` [INFO] [stdout] fe08c38774662aaf32e8070f19c123fbf940ad81a1010eb32bb934347eb3b010