[INFO] crate mdl 1.0.4 is already in cache [INFO] extracting crate mdl 1.0.4 into work/ex/clippy-test-run/sources/stable/reg/mdl/1.0.4 [INFO] extracting crate mdl 1.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdl/1.0.4 [INFO] validating manifest of mdl-1.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mdl-1.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mdl-1.0.4 [INFO] finished frobbing mdl-1.0.4 [INFO] frobbed toml for mdl-1.0.4 written to work/ex/clippy-test-run/sources/stable/reg/mdl/1.0.4/Cargo.toml [INFO] started frobbing mdl-1.0.4 [INFO] finished frobbing mdl-1.0.4 [INFO] frobbed toml for mdl-1.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdl/1.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mdl-1.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mdl/1.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e2ada44ca236bc69d0a18f6e8887849f367b39cdcc73721a923f91cb1086d99 [INFO] running `"docker" "start" "-a" "2e2ada44ca236bc69d0a18f6e8887849f367b39cdcc73721a923f91cb1086d99"` [INFO] [stderr] Compiling lmdb-sys v0.8.0 [INFO] [stderr] Checking lmdb v0.8.0 [INFO] [stderr] Checking mdl v1.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/store.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | .map_err(|_| err_msg(format!("error reading from db")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"error reading from db".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cache.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(dbs[name].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dbs[name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/cache.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | .or(Err(err_msg(format!("error opening the db {}", name))))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(err_msg(format!("error opening the db {}", name))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cache.rs:66:44 [INFO] [stderr] | [INFO] [stderr] 66 | self.dbs.borrow_mut().insert(name, db.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/bcache.rs:49:44 [INFO] [stderr] | [INFO] [stderr] 49 | let rdata = map.get(&newk).ok_or(err_msg(format!("Not found, pull {}", newk)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(format!("Not found, pull {}", newk)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/bcache.rs:65:57 [INFO] [stderr] | [INFO] [stderr] 65 | .filter(|(k, _v)| { k.len() >= l && &k[..l] == &newk }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 65 | .filter(|(k, _v)| { k.len() >= l && k[..l] == newk }); [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/bcache.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | map.remove(&newk).ok_or(err_msg(format!("Not found, rm {}", newk)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(format!("Not found, rm {}", newk)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/model.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(out) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 46 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/model.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | Ok(out) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 62 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/signal.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | fn base<'a>(&'a self) -> &'a SigBase; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signal::SigBase` [INFO] [stderr] --> src/signal.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn new() -> SigBase { [INFO] [stderr] 115 | | let (tx, rv) = channel::(); [INFO] [stderr] 116 | | let main = Some(tx); [INFO] [stderr] 117 | | let recv = Arc::new(Mutex::new(rv)); [INFO] [stderr] 118 | | let id = Arc::new(Mutex::new(1)); [INFO] [stderr] 119 | | SigBase{id, recv, main} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | impl Default for signal::SigBase { [INFO] [stderr] 114 | fn default() -> Self { [INFO] [stderr] 115 | Self::new() [INFO] [stderr] 116 | } [INFO] [stderr] 117 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signal::SignalerAsync` [INFO] [stderr] --> src/signal.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> SignalerAsync { [INFO] [stderr] 125 | | let callbacks = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] 126 | | let base = SigBase::new(); [INFO] [stderr] 127 | | SignalerAsync { base, callbacks } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | impl Default for signal::SignalerAsync { [INFO] [stderr] 124 | fn default() -> Self { [INFO] [stderr] 125 | Self::new() [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signal::SignalerSync` [INFO] [stderr] --> src/signal.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn new() -> SignalerSync { [INFO] [stderr] 177 | | let callbacks = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] 178 | | let base = SigBase::new(); [INFO] [stderr] 179 | | SignalerSync { base, callbacks } [INFO] [stderr] 180 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | impl Default for signal::SignalerSync { [INFO] [stderr] 176 | fn default() -> Self { [INFO] [stderr] 177 | Self::new() [INFO] [stderr] 178 | } [INFO] [stderr] 179 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/signal.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | fn base<'a>(&'a self) -> &'a SigBase { &self.base } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/signal.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | fn base<'a>(&'a self) -> &'a SigBase { &self.base } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/store.rs:46:34 [INFO] [stderr] | [INFO] [stderr] 46 | .map_err(|_| err_msg(format!("error reading from db")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"error reading from db".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cache.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(dbs[name].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dbs[name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/cache.rs:64:14 [INFO] [stderr] | [INFO] [stderr] 64 | .or(Err(err_msg(format!("error opening the db {}", name))))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(err_msg(format!("error opening the db {}", name))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cache.rs:66:44 [INFO] [stderr] | [INFO] [stderr] 66 | self.dbs.borrow_mut().insert(name, db.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/bcache.rs:49:44 [INFO] [stderr] | [INFO] [stderr] 49 | let rdata = map.get(&newk).ok_or(err_msg(format!("Not found, pull {}", newk)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(format!("Not found, pull {}", newk)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/bcache.rs:65:57 [INFO] [stderr] | [INFO] [stderr] 65 | .filter(|(k, _v)| { k.len() >= l && &k[..l] == &newk }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 65 | .filter(|(k, _v)| { k.len() >= l && k[..l] == newk }); [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/bcache.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | map.remove(&newk).ok_or(err_msg(format!("Not found, rm {}", newk)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg(format!("Not found, rm {}", newk)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/model.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(out) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 46 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/model.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | Ok(out) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 62 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/signal.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | fn base<'a>(&'a self) -> &'a SigBase; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signal::SigBase` [INFO] [stderr] --> src/signal.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / pub fn new() -> SigBase { [INFO] [stderr] 115 | | let (tx, rv) = channel::(); [INFO] [stderr] 116 | | let main = Some(tx); [INFO] [stderr] 117 | | let recv = Arc::new(Mutex::new(rv)); [INFO] [stderr] 118 | | let id = Arc::new(Mutex::new(1)); [INFO] [stderr] 119 | | SigBase{id, recv, main} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | impl Default for signal::SigBase { [INFO] [stderr] 114 | fn default() -> Self { [INFO] [stderr] 115 | Self::new() [INFO] [stderr] 116 | } [INFO] [stderr] 117 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signal::SignalerAsync` [INFO] [stderr] --> src/signal.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> SignalerAsync { [INFO] [stderr] 125 | | let callbacks = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] 126 | | let base = SigBase::new(); [INFO] [stderr] 127 | | SignalerAsync { base, callbacks } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | impl Default for signal::SignalerAsync { [INFO] [stderr] 124 | fn default() -> Self { [INFO] [stderr] 125 | Self::new() [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `signal::SignalerSync` [INFO] [stderr] --> src/signal.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn new() -> SignalerSync { [INFO] [stderr] 177 | | let callbacks = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] 178 | | let base = SigBase::new(); [INFO] [stderr] 179 | | SignalerSync { base, callbacks } [INFO] [stderr] 180 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | impl Default for signal::SignalerSync { [INFO] [stderr] 176 | fn default() -> Self { [INFO] [stderr] 177 | Self::new() [INFO] [stderr] 178 | } [INFO] [stderr] 179 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/signal.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | fn base<'a>(&'a self) -> &'a SigBase { &self.base } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/signal.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | fn base<'a>(&'a self) -> &'a SigBase { &self.base } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.94s [INFO] running `"docker" "inspect" "2e2ada44ca236bc69d0a18f6e8887849f367b39cdcc73721a923f91cb1086d99"` [INFO] running `"docker" "rm" "-f" "2e2ada44ca236bc69d0a18f6e8887849f367b39cdcc73721a923f91cb1086d99"` [INFO] [stdout] 2e2ada44ca236bc69d0a18f6e8887849f367b39cdcc73721a923f91cb1086d99