[INFO] crate mdbook-epub 0.1.0 is already in cache [INFO] extracting crate mdbook-epub 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mdbook-epub/0.1.0 [INFO] extracting crate mdbook-epub 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdbook-epub/0.1.0 [INFO] validating manifest of mdbook-epub-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mdbook-epub-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mdbook-epub-0.1.0 [INFO] finished frobbing mdbook-epub-0.1.0 [INFO] frobbed toml for mdbook-epub-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mdbook-epub/0.1.0/Cargo.toml [INFO] started frobbing mdbook-epub-0.1.0 [INFO] finished frobbing mdbook-epub-0.1.0 [INFO] frobbed toml for mdbook-epub-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdbook-epub/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mdbook-epub-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mdbook-epub/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c795a0b96bd5f7c5202c5e3aca284ec4ed97b4954b535959c403c63de4cccbd [INFO] running `"docker" "start" "-a" "6c795a0b96bd5f7c5202c5e3aca284ec4ed97b4954b535959c403c63de4cccbd"` [INFO] [stderr] Compiling crossbeam v0.2.12 [INFO] [stderr] Compiling home v0.3.4 [INFO] [stderr] Compiling hex v0.2.0 [INFO] [stderr] Compiling shell-escape v0.1.4 [INFO] [stderr] Compiling termcolor v0.3.6 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling socket2 v0.3.8 [INFO] [stderr] Compiling memchr v1.0.2 [INFO] [stderr] Compiling filetime v0.1.15 [INFO] [stderr] Compiling fs2 v0.4.3 [INFO] [stderr] Compiling jobserver v0.1.12 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling serde_ignored v0.0.4 [INFO] [stderr] Compiling toml v0.4.10 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Compiling tar v0.4.20 [INFO] [stderr] Compiling flate2 v0.2.20 [INFO] [stderr] Compiling curl-sys v0.4.16 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Checking structopt v0.1.7 [INFO] [stderr] Compiling crypto-hash v0.3.3 [INFO] [stderr] Compiling globset v0.2.1 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Compiling docopt v0.8.3 [INFO] [stderr] Checking elasticlunr-rs v2.3.4 [INFO] [stderr] Checking toml-query v0.6.0 [INFO] [stderr] Checking zip v0.2.8 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Compiling curl v0.4.19 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Compiling git2 v0.6.11 [INFO] [stderr] Checking epub v1.2.0 [INFO] [stderr] Compiling ignore v0.2.2 [INFO] [stderr] Checking epub-builder v0.3.0 [INFO] [stderr] Checking html5ever v0.22.5 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Compiling crates-io v0.13.0 [INFO] [stderr] Checking ammonia v1.2.0 [INFO] [stderr] Compiling git2-curl v0.7.0 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Compiling cargo v0.24.0 [INFO] [stderr] Checking notify v4.0.7 [INFO] [stderr] Checking mdbook v0.1.8 [INFO] [stderr] Compiling mdbook-epub v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resources.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | location_on_disk: location_on_disk, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `location_on_disk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resources.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | location_on_disk: location_on_disk, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `location_on_disk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | pub const MDBOOK_VERSION: &'static str = env!("MDBOOK_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:20:61 [INFO] [stderr] | [INFO] [stderr] 20 | Some(table) => table.clone().try_into().map_err(|e| Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/resources.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match event { [INFO] [stderr] 66 | | Event::Start(Tag::Image(dest, _)) => { [INFO] [stderr] 67 | | found.push(dest.to_owned()); [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Event::Start(Tag::Image(dest, _)) = event { [INFO] [stderr] 66 | found.push(dest.to_owned()); [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | pub const MDBOOK_VERSION: &'static str = env!("MDBOOK_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/mdbook-epub.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | destination: destination, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/mdbook-epub.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | destination: destination, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:20:61 [INFO] [stderr] | [INFO] [stderr] 20 | Some(table) => table.clone().try_into().map_err(|e| Error::from(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/resources.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match event { [INFO] [stderr] 66 | | Event::Start(Tag::Image(dest, _)) => { [INFO] [stderr] 67 | | found.push(dest.to_owned()); [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | _ => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Event::Start(Tag::Image(dest, _)) = event { [INFO] [stderr] 66 | found.push(dest.to_owned()); [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/bin/mdbook-epub.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | for cause in e.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/mdbook-epub.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | if let Ok(_) = env::var("RUST_BACKTRACE") { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 32 | | eprintln!(); [INFO] [stderr] 33 | | eprintln!("{}", e.backtrace()); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________- help: try this: `if env::var("RUST_BACKTRACE").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'failure::Error::causes': please use the 'iter_chain()' method instead [INFO] [stderr] --> src/bin/mdbook-epub.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | for cause in e.causes().skip(1) { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/mdbook-epub.rs:31:16 [INFO] [stderr] | [INFO] [stderr] 31 | if let Ok(_) = env::var("RUST_BACKTRACE") { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 32 | | eprintln!(); [INFO] [stderr] 33 | | eprintln!("{}", e.backtrace()); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________- help: try this: `if env::var("RUST_BACKTRACE").is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 20s [INFO] running `"docker" "inspect" "6c795a0b96bd5f7c5202c5e3aca284ec4ed97b4954b535959c403c63de4cccbd"` [INFO] running `"docker" "rm" "-f" "6c795a0b96bd5f7c5202c5e3aca284ec4ed97b4954b535959c403c63de4cccbd"` [INFO] [stdout] 6c795a0b96bd5f7c5202c5e3aca284ec4ed97b4954b535959c403c63de4cccbd