[INFO] crate mdbook 0.2.2 is already in cache [INFO] extracting crate mdbook 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/mdbook/0.2.2 [INFO] extracting crate mdbook 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdbook/0.2.2 [INFO] validating manifest of mdbook-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mdbook-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mdbook-0.2.2 [INFO] finished frobbing mdbook-0.2.2 [INFO] frobbed toml for mdbook-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/mdbook/0.2.2/Cargo.toml [INFO] started frobbing mdbook-0.2.2 [INFO] finished frobbing mdbook-0.2.2 [INFO] frobbed toml for mdbook-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mdbook/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mdbook-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mdbook/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c9fcd6db242368c79a90d762a97c6d34bb750861b9a7236da74f003514c85c5 [INFO] running `"docker" "start" "-a" "8c9fcd6db242368c79a90d762a97c6d34bb750861b9a7236da74f003514c85c5"` [INFO] [stderr] Checking pulldown-cmark v0.2.0 [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Compiling strum_macros v0.11.0 [INFO] [stderr] Checking ws v0.7.9 [INFO] [stderr] Checking toml-query v0.7.0 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Checking staticfile v0.5.0 [INFO] [stderr] Checking pulldown-cmark-to-cmark v1.2.0 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling markup5ever v0.7.5 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking elasticlunr-rs v2.3.4 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking html5ever v0.22.5 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking ammonia v1.2.0 [INFO] [stderr] Checking mdbook v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/book.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/book.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | parent_names: parent_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/book/init.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/summary.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | book: book, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `book` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | build: build, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `build` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/book.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/book.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | parent_names: parent_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_names` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:166:62 [INFO] [stderr] | [INFO] [stderr] 166 | LinkType::IncludeRangeFrom(path, RangeFrom { start: start }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:178:67 [INFO] [stderr] | [INFO] [stderr] 178 | Some(end) => LinkType::IncludeRangeTo(path, RangeTo { end: end }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/book/init.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/summary.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | is_index: is_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:304:13 [INFO] [stderr] | [INFO] [stderr] 304 | book: book, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `book` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | build: build, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `build` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | book: book, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `book` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:166:62 [INFO] [stderr] | [INFO] [stderr] 166 | LinkType::IncludeRangeFrom(path, RangeFrom { start: start }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/mod.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | enabled: enabled, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `enabled` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/preprocess/links.rs:178:67 [INFO] [stderr] | [INFO] [stderr] 178 | Some(end) => LinkType::IncludeRangeTo(path, RangeTo { end: end }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | is_index: is_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | book: book, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `book` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/mod.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils/mod.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | enabled: enabled, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `enabled` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/book/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod book; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/book/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod book; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/book/book.rs:304:23 [INFO] [stderr] | [INFO] [stderr] 304 | const DUMMY_SRC: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:556:28 [INFO] [stderr] | [INFO] [stderr] 556 | const COMPLEX_CONFIG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:101:48 [INFO] [stderr] | [INFO] [stderr] 101 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/book/book.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / if let &mut BookItem::Chapter(ref mut ch) = item { [INFO] [stderr] 120 | | for_each_mut(func, &mut ch.sub_items); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | if let BookItem::Chapter(ref mut ch) = *item { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/book/book.rs:213:59 [INFO] [stderr] | [INFO] [stderr] 213 | load_chapter(link, src_dir, parent_names).map(|c| BookItem::Chapter(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BookItem::Chapter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/book/mod.rs:431:35 [INFO] [stderr] | [INFO] [stderr] 431 | return explicit_renderers.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn from_str(src: &str) -> Result { [INFO] [stderr] 81 | | toml::from_str(src).chain_err(|| Error::from("Invalid configuration file")) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::index::IndexPreprocessor` [INFO] [stderr] --> src/preprocess/index.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | IndexPreprocessor [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preprocess/index.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | let parent_dir = index_path.as_ref().parent().unwrap_or(index_path.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| index_path.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::links::LinkPreprocessor` [INFO] [stderr] --> src/preprocess/links.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | LinkPreprocessor [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/preprocess/links.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | / Range { [INFO] [stderr] 171 | | start: start, [INFO] [stderr] 172 | | end: start + 1, [INFO] [stderr] 173 | | }, [INFO] [stderr] | |_____________________^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/preprocess/links.rs:261:45 [INFO] [stderr] | [INFO] [stderr] 261 | .map(|s| take_lines(&s, range.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match *item { [INFO] [stderr] 34 | | BookItem::Chapter(ref ch) => { [INFO] [stderr] 35 | | let content = ch.content.clone(); [INFO] [stderr] 36 | | let content = utils::render_markdown(&content, ctx.html_config.curly_quotes); [INFO] [stderr] ... | [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let BookItem::Chapter(ref ch) = *item { [INFO] [stderr] 34 | let content = ch.content.clone(); [INFO] [stderr] 35 | let content = utils::render_markdown(&content, ctx.html_config.curly_quotes); [INFO] [stderr] 36 | print_content.push_str(&content); [INFO] [stderr] 37 | [INFO] [stderr] 38 | // Update the context with data for this file [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/renderer/html_handlebars/helpers/navigation.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | base_path: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/renderer/html_handlebars/helpers/navigation.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | current_path: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renderer/html_handlebars/helpers/navigation.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &Target::Next => { [INFO] [stderr] 28 | | let previous_path = previous_item [INFO] [stderr] 29 | | .get("path") [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | Target::Next => { [INFO] [stderr] 28 | let previous_path = previous_item [INFO] [stderr] 29 | .get("path") [INFO] [stderr] 30 | .ok_or_else(|| RenderError::new("No path found for chapter in JSON data"))?; [INFO] [stderr] 31 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | let url = if let &Some(ref id) = section_id { [INFO] [stderr] | _______________^ [INFO] [stderr] 58 | | Cow::Owned(format!("{}#{}", anchor_base, id)) [INFO] [stderr] 59 | | } else { [INFO] [stderr] 60 | | Cow::Borrowed(anchor_base) [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | let url = if let Some(ref id) = *section_id { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | let chapter = match item { [INFO] [stderr] | ___________________^ [INFO] [stderr] 78 | | &BookItem::Chapter(ref ch) => ch, [INFO] [stderr] 79 | | _ => return Ok(()), [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | let chapter = match *item { [INFO] [stderr] 78 | BookItem::Chapter(ref ch) => ch, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | let max_section_depth = search_config.heading_split_level as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(search_config.heading_split_level)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | if heading.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!heading.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:158:8 [INFO] [stderr] | [INFO] [stderr] 158 | if heading.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!heading.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/utils/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn collapse_whitespace<'a>(text: &'a str) -> Cow<'a, str> { [INFO] [stderr] 18 | | lazy_static! { [INFO] [stderr] 19 | | static ref RE: Regex = Regex::new(r"\s\s+").unwrap(); [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | RE.replace_all(text, " ") [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/book/book.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / if let &mut BookItem::Chapter(ref mut ch) = item { [INFO] [stderr] 120 | | for_each_mut(func, &mut ch.sub_items); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | if let BookItem::Chapter(ref mut ch) = *item { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/book/book.rs:213:59 [INFO] [stderr] | [INFO] [stderr] 213 | load_chapter(link, src_dir, parent_names).map(|c| BookItem::Chapter(c)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BookItem::Chapter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/book/book.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / File::create(&chapter_path) [INFO] [stderr] 319 | | .unwrap() [INFO] [stderr] 320 | | .write(DUMMY_SRC.as_bytes()) [INFO] [stderr] 321 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/book/book.rs:336:24 [INFO] [stderr] | [INFO] [stderr] 336 | .write_all("Hello World!".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello World!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/book/mod.rs:431:35 [INFO] [stderr] | [INFO] [stderr] 431 | return explicit_renderers.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn from_str(src: &str) -> Result { [INFO] [stderr] 81 | | toml::from_str(src).chain_err(|| Error::from("Invalid configuration file")) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/config.rs:594:15 [INFO] [stderr] | [INFO] [stderr] 594 | ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> src/config.rs:648:13 [INFO] [stderr] | [INFO] [stderr] 648 | let baz: Vec = cfg.get_deserialized("output.random.baz").unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/config.rs:776:58 [INFO] [stderr] | [INFO] [stderr] 776 | let value = json!({"array": [1, 2, 3], "number": 3.14}); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::index::IndexPreprocessor` [INFO] [stderr] --> src/preprocess/index.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | IndexPreprocessor [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preprocess/index.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | let parent_dir = index_path.as_ref().parent().unwrap_or(index_path.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| index_path.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::links::LinkPreprocessor` [INFO] [stderr] --> src/preprocess/links.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | LinkPreprocessor [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/preprocess/links.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | / Range { [INFO] [stderr] 171 | | start: start, [INFO] [stderr] 172 | | end: start + 1, [INFO] [stderr] 173 | | }, [INFO] [stderr] | |_____________________^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/preprocess/links.rs:261:45 [INFO] [stderr] | [INFO] [stderr] 261 | .map(|s| take_lines(&s, range.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match *item { [INFO] [stderr] 34 | | BookItem::Chapter(ref ch) => { [INFO] [stderr] 35 | | let content = ch.content.clone(); [INFO] [stderr] 36 | | let content = utils::render_markdown(&content, ctx.html_config.curly_quotes); [INFO] [stderr] ... | [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let BookItem::Chapter(ref ch) = *item { [INFO] [stderr] 34 | let content = ch.content.clone(); [INFO] [stderr] 35 | let content = utils::render_markdown(&content, ctx.html_config.curly_quotes); [INFO] [stderr] 36 | print_content.push_str(&content); [INFO] [stderr] 37 | [INFO] [stderr] 38 | // Update the context with data for this file [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/renderer/html_handlebars/helpers/navigation.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | base_path: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/renderer/html_handlebars/helpers/navigation.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | current_path: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renderer/html_handlebars/helpers/navigation.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match self { [INFO] [stderr] 27 | | &Target::Next => { [INFO] [stderr] 28 | | let previous_path = previous_item [INFO] [stderr] 29 | | .get("path") [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *self { [INFO] [stderr] 27 | Target::Next => { [INFO] [stderr] 28 | let previous_path = previous_item [INFO] [stderr] 29 | .get("path") [INFO] [stderr] 30 | .ok_or_else(|| RenderError::new("No path found for chapter in JSON data"))?; [INFO] [stderr] 31 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:57:15 [INFO] [stderr] | [INFO] [stderr] 57 | let url = if let &Some(ref id) = section_id { [INFO] [stderr] | _______________^ [INFO] [stderr] 58 | | Cow::Owned(format!("{}#{}", anchor_base, id)) [INFO] [stderr] 59 | | } else { [INFO] [stderr] 60 | | Cow::Borrowed(anchor_base) [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | let url = if let Some(ref id) = *section_id { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | let chapter = match item { [INFO] [stderr] | ___________________^ [INFO] [stderr] 78 | | &BookItem::Chapter(ref ch) => ch, [INFO] [stderr] 79 | | _ => return Ok(()), [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | let chapter = match *item { [INFO] [stderr] 78 | BookItem::Chapter(ref ch) => ch, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | let max_section_depth = search_config.heading_split_level as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(search_config.heading_split_level)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | if heading.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!heading.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:158:8 [INFO] [stderr] | [INFO] [stderr] 158 | if heading.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!heading.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/utils/fs.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | Err(_) => panic!("Could not create a temp dir"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | if let Err(_) = fs::File::create(&tmp.path().join("file.txt")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 204 | | panic!("Could not create file.txt") [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.txt")).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | if let Err(_) = fs::File::create(&tmp.path().join("file.md")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 207 | | panic!("Could not create file.md") [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.md")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | if let Err(_) = fs::File::create(&tmp.path().join("file.png")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 210 | | panic!("Could not create file.png") [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.png")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:212:16 [INFO] [stderr] | [INFO] [stderr] 212 | if let Err(_) = fs::create_dir(&tmp.path().join("sub_dir")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 213 | | panic!("Could not create sub_dir") [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("sub_dir")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:215:16 [INFO] [stderr] | [INFO] [stderr] 215 | if let Err(_) = fs::File::create(&tmp.path().join("sub_dir/file.png")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 216 | | panic!("Could not create sub_dir/file.png") [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("sub_dir/file.png")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:218:16 [INFO] [stderr] | [INFO] [stderr] 218 | if let Err(_) = fs::create_dir(&tmp.path().join("sub_dir_exists")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 219 | | panic!("Could not create sub_dir_exists") [INFO] [stderr] 220 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("sub_dir_exists")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | if let Err(_) = fs::File::create(&tmp.path().join("sub_dir_exists/file.txt")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 222 | | panic!("Could not create sub_dir_exists/file.txt") [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("sub_dir_exists/file.txt")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:226:16 [INFO] [stderr] | [INFO] [stderr] 226 | if let Err(_) = fs::create_dir(&tmp.path().join("output")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 227 | | panic!("Could not create output") [INFO] [stderr] 228 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("output")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:229:16 [INFO] [stderr] | [INFO] [stderr] 229 | if let Err(_) = fs::create_dir(&tmp.path().join("output/sub_dir_exists")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 230 | | panic!("Could not create output/sub_dir_exists") [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("output/sub_dir_exists")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils/fs.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | / match copy_files_except_ext(&tmp.path(), &tmp.path().join("output"), true, &["md"]) { [INFO] [stderr] 234 | | Err(e) => panic!("Error while executing the function:\n{:?}", e), [INFO] [stderr] 235 | | Ok(_) => {} [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = copy_files_except_ext(&tmp.path(), &tmp.path().join("output"), true, &["md"]) { panic!("Error while executing the function:\n{:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/utils/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn collapse_whitespace<'a>(text: &'a str) -> Cow<'a, str> { [INFO] [stderr] 18 | | lazy_static! { [INFO] [stderr] 19 | | static ref RE: Regex = Regex::new(r"\s\s+").unwrap(); [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | RE.replace_all(text, " ") [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mdbook`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/rendered_output.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | const BOOK_ROOT: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/tests/dummy_book"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/rendered_output.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | const TOC_TOP_LEVEL: &[&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/rendered_output.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | const TOC_SECOND_LEVEL: &[&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/rendered_output.rs:375:49 [INFO] [stderr] | [INFO] [stderr] 375 | assert_doesnt_contain_strings(&first_index, &vec!["README.html"]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["README.html"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/rendered_output.rs:413:46 [INFO] [stderr] | [INFO] [stderr] 413 | let index = index.trim_right_matches(";"); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/rendered_output.rs:438:9 [INFO] [stderr] | [INFO] [stderr] 438 | assert_eq!(textidx["docs"][&first_chapter]["tf"], 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/rendered_output.rs:438:9 [INFO] [stderr] | [INFO] [stderr] 438 | assert_eq!(textidx["docs"][&first_chapter]["tf"], 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/rendered_output.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | assert_eq!(textidx["docs"][&introduction]["tf"], 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/rendered_output.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | assert_eq!(textidx["docs"][&introduction]["tf"], 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mdbook`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | const NAME: &'static str = "mdBook"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | const VERSION: &'static str = concat!("v", crate_version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: The function/method `watch::trigger_on_change` doesn't need a mutable reference [INFO] [stderr] --> src/cmd/serve.rs:117:30 [INFO] [stderr] | [INFO] [stderr] 117 | watch::trigger_on_change(&mut book, move |path, book_dir| { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | const NAME: &'static str = "mdBook"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | const VERSION: &'static str = concat!("v", crate_version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: The function/method `watch::trigger_on_change` doesn't need a mutable reference [INFO] [stderr] --> src/cmd/serve.rs:117:30 [INFO] [stderr] | [INFO] [stderr] 117 | watch::trigger_on_change(&mut book, move |path, book_dir| { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8c9fcd6db242368c79a90d762a97c6d34bb750861b9a7236da74f003514c85c5"` [INFO] running `"docker" "rm" "-f" "8c9fcd6db242368c79a90d762a97c6d34bb750861b9a7236da74f003514c85c5"` [INFO] [stdout] 8c9fcd6db242368c79a90d762a97c6d34bb750861b9a7236da74f003514c85c5