[INFO] crate mcpat 0.9.0 is already in cache [INFO] extracting crate mcpat 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/mcpat/0.9.0 [INFO] extracting crate mcpat 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mcpat/0.9.0 [INFO] validating manifest of mcpat-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mcpat-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mcpat-0.9.0 [INFO] finished frobbing mcpat-0.9.0 [INFO] frobbed toml for mcpat-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/mcpat/0.9.0/Cargo.toml [INFO] started frobbing mcpat-0.9.0 [INFO] finished frobbing mcpat-0.9.0 [INFO] frobbed toml for mcpat-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mcpat/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mcpat-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mcpat/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbb073a109ae98ab762ebc60564693970859e1b5e1d67953acffcf9d074ca497 [INFO] running `"docker" "start" "-a" "fbb073a109ae98ab762ebc60564693970859e1b5e1d67953acffcf9d074ca497"` [INFO] [stderr] Compiling mcpat-sys v0.8.0 [INFO] [stderr] Checking fixture v0.3.1 [INFO] [stderr] Checking mcpat v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | Cache { raw: raw, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | Core { raw: raw, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | Processor { raw: raw, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | Cache { raw: raw, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | Core { raw: raw, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/processor.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | Processor { raw: raw, phantom: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `raw` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/component.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 26 | | if long_channel { [INFO] [stderr] 27 | | raw::powerComponents_longer_channel_leakage(components) [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | raw::powerComponents_leakage(components) [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 25 | } else if long_channel { [INFO] [stderr] 26 | raw::powerComponents_longer_channel_leakage(components) [INFO] [stderr] 27 | } else { [INFO] [stderr] 28 | raw::powerComponents_leakage(components) [INFO] [stderr] 29 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/component.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 26 | | if long_channel { [INFO] [stderr] 27 | | raw::powerComponents_longer_channel_leakage(components) [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | raw::powerComponents_leakage(components) [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 25 | } else if long_channel { [INFO] [stderr] 26 | raw::powerComponents_longer_channel_leakage(components) [INFO] [stderr] 27 | } else { [INFO] [stderr] 28 | raw::powerComponents_leakage(components) [INFO] [stderr] 29 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> tests/support/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / macro_rules! round( [INFO] [stderr] 8 | | ($value:expr, $precision:expr) => ({ [INFO] [stderr] 9 | | let scale = 10f64.powi($precision); [INFO] [stderr] 10 | | ($value * scale).round() / scale [INFO] [stderr] 11 | | }); [INFO] [stderr] 12 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/workflow.rs:33:68 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(round!(l3.leakage_power(), 3), round!(6.06659 + 0.165767, 3)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.165_767` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> tests/blackscholes.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / loop { [INFO] [stderr] 59 | | let line = match lines.next() { [INFO] [stderr] 60 | | Some(line) => ok!(line), [INFO] [stderr] 61 | | _ => break, [INFO] [stderr] ... | [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(line) = lines.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/blackscholes.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!((actual * scale).round() / scale, (expected * scale).round() / scale); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/blackscholes.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!((actual * scale).round() / scale, (expected * scale).round() / scale); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mcpat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/workflow.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(round!(core.dynamic_power(), 4), 55.7891); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/workflow.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(round!(core.dynamic_power(), 4), 55.7891); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/workflow.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(round!(core.leakage_power(), 3), round!(5.15028 + 0.74513, 3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/workflow.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(round!(core.leakage_power(), 3), round!(5.15028 + 0.74513, 3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/workflow.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(round!(l3.dynamic_power(), 5), 4.32382); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/workflow.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(round!(l3.dynamic_power(), 5), 4.32382); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/workflow.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(round!(l3.leakage_power(), 3), round!(6.06659 + 0.165767, 3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/workflow.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(round!(l3.leakage_power(), 3), round!(6.06659 + 0.165767, 3)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mcpat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fbb073a109ae98ab762ebc60564693970859e1b5e1d67953acffcf9d074ca497"` [INFO] running `"docker" "rm" "-f" "fbb073a109ae98ab762ebc60564693970859e1b5e1d67953acffcf9d074ca497"` [INFO] [stdout] fbb073a109ae98ab762ebc60564693970859e1b5e1d67953acffcf9d074ca497