[INFO] crate mccs-caps 0.1.0 is already in cache [INFO] extracting crate mccs-caps 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mccs-caps/0.1.0 [INFO] extracting crate mccs-caps 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mccs-caps/0.1.0 [INFO] validating manifest of mccs-caps-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mccs-caps-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mccs-caps-0.1.0 [INFO] finished frobbing mccs-caps-0.1.0 [INFO] frobbed toml for mccs-caps-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mccs-caps/0.1.0/Cargo.toml [INFO] started frobbing mccs-caps-0.1.0 [INFO] finished frobbing mccs-caps-0.1.0 [INFO] frobbed toml for mccs-caps-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mccs-caps/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mccs-caps-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mccs-caps/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fae29724ca8836a952dd4cddf9ff2fd52b0d5baaf2dd11c8bc6cef53bcd12fef [INFO] running `"docker" "start" "-a" "fae29724ca8836a952dd4cddf9ff2fd52b0d5baaf2dd11c8bc6cef53bcd12fef"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking mccs-caps v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/testdata.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | / [ [INFO] [stderr] 3 | | // monitors I have lying around [INFO] [stderr] 4 | | &b"(prot(monitor)type(lcd)27UD58cmds(01 02 03 0C E3 F3)vcp(02 04 05 08 10 12 14(05 08 0B ) 16 18 1A 52 60( 11 12 0F 10) AC AE B2 B6 C0 C6 C8 C9 D6(01 04) DF 62 8D F4 F5(01 02) F6(00 01 02) 4D 4E 4F 15(01 06 11 13 14 28 29 32 48) F7(00 01 02 03) F8(00 01) F9 E4 E5 E6 E7 E8 E9 EA EB EF FD(00 01) FE(00 01 02) FF)mccs_ver(2.1)mswhql(1))"[..], [INFO] [stderr] 5 | | &b"(prot(monitor)type(LCD)model(ACER)cmds(01 02 03 07 0C E3 F3)vcp(02 04 05 08 0B 10 12 14(05 08 0B) 16 18 1A 52 60(01 03 11) 6C 6E 70 AC AE B2 B6 C6 C8 C9 CC(01 02 03 04 05 06 08 09 0A 0C 0D 14 16 1E) D6(01 05) DF)mswhql(1)asset_eep(40)mccs_ver(2.0))\0"[..], [INFO] [stderr] ... | [INFO] [stderr] 21 | | &b"(prot(monitor)type(LCD)model(AOC)cmds(01 02 03 07 0C E3 F3)vcp(02 04 05 06 08 0B 0C 10 12 14(01 02 04 05 08) 16 18 1A 52 60(01 03 11) 87 AC AE B2 B6 C6 C8 CA CC(01 02 03 04 06 0A 0D) D6(01 04) DF FD FF)mswhql(1)asset_eep(40)mccs_ver(2.2))"[..], [INFO] [stderr] 22 | | ].iter().cloned().collect() [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:39:66 [INFO] [stderr] | [INFO] [stderr] 39 | caps.vcp_features.entry(code).or_insert_with(|| VcpDescriptor::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `VcpDescriptor::default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match cap { [INFO] [stderr] 62 | | Cap::VcpNames(vcp) => for (code, name, value_names) in vcp { [INFO] [stderr] 63 | | if let Some(vcp) = caps.vcp_features.get_mut(&code) { [INFO] [stderr] 64 | | if let Some(name) = name { [INFO] [stderr] ... | [INFO] [stderr] 77 | | _ => (), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Cap::VcpNames(vcp) = cap for (code, name, value_names) in vcp { [INFO] [stderr] 62 | if let Some(vcp) = caps.vcp_features.get_mut(&code) { [INFO] [stderr] 63 | if let Some(name) = name { [INFO] [stderr] 64 | vcp.name = Some(name.into()) [INFO] [stderr] 65 | } [INFO] [stderr] 66 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:39:66 [INFO] [stderr] | [INFO] [stderr] 39 | caps.vcp_features.entry(code).or_insert_with(|| VcpDescriptor::default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `VcpDescriptor::default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match cap { [INFO] [stderr] 62 | | Cap::VcpNames(vcp) => for (code, name, value_names) in vcp { [INFO] [stderr] 63 | | if let Some(vcp) = caps.vcp_features.get_mut(&code) { [INFO] [stderr] 64 | | if let Some(name) = name { [INFO] [stderr] ... | [INFO] [stderr] 77 | | _ => (), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Cap::VcpNames(vcp) = cap for (code, name, value_names) in vcp { [INFO] [stderr] 62 | if let Some(vcp) = caps.vcp_features.get_mut(&code) { [INFO] [stderr] 63 | if let Some(name) = name { [INFO] [stderr] 64 | vcp.name = Some(name.into()) [INFO] [stderr] 65 | } [INFO] [stderr] 66 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.96s [INFO] running `"docker" "inspect" "fae29724ca8836a952dd4cddf9ff2fd52b0d5baaf2dd11c8bc6cef53bcd12fef"` [INFO] running `"docker" "rm" "-f" "fae29724ca8836a952dd4cddf9ff2fd52b0d5baaf2dd11c8bc6cef53bcd12fef"` [INFO] [stdout] fae29724ca8836a952dd4cddf9ff2fd52b0d5baaf2dd11c8bc6cef53bcd12fef