[INFO] crate mbutiles 0.1.1 is already in cache [INFO] extracting crate mbutiles 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/mbutiles/0.1.1 [INFO] extracting crate mbutiles 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mbutiles/0.1.1 [INFO] validating manifest of mbutiles-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mbutiles-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mbutiles-0.1.1 [INFO] finished frobbing mbutiles-0.1.1 [INFO] frobbed toml for mbutiles-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/mbutiles/0.1.1/Cargo.toml [INFO] started frobbing mbutiles-0.1.1 [INFO] finished frobbing mbutiles-0.1.1 [INFO] frobbed toml for mbutiles-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mbutiles/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mbutiles-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mbutiles/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28ca6217b28742c0ef077503f31165e57e4a0be41d345b35857e091eb5498810 [INFO] running `"docker" "start" "-a" "28ca6217b28742c0ef077503f31165e57e4a0be41d345b35857e091eb5498810"` [INFO] [stderr] Compiling libsqlite3-sys v0.5.0 [INFO] [stderr] Checking jlens v0.0.1 [INFO] [stderr] Checking stdio_logger v0.1.1 [INFO] [stderr] warning: redundant linker flag specified for library `sqlite3` [INFO] [stderr] [INFO] [stderr] Checking rusqlite v0.7.4 [INFO] [stderr] Checking mbutiles v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:431:58 [INFO] [stderr] | [INFO] [stderr] 431 | .join(format!("{:03}", x as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:434:58 [INFO] [stderr] | [INFO] [stderr] 434 | .join(format!("{:02}", y as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:431:58 [INFO] [stderr] | [INFO] [stderr] 431 | .join(format!("{:03}", x as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:434:58 [INFO] [stderr] | [INFO] [stderr] 434 | .join(format!("{:02}", y as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 58 | | PRAGMA synchronous=0; [INFO] [stderr] 59 | | PRAGMA locking_mode=EXCLUSIVE; [INFO] [stderr] 60 | | PRAGMA journal_mode=DELETE; [INFO] [stderr] 61 | | ") [INFO] [stderr] 62 | | .desc("Cannot execute sqlite optimization query"))) [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 75 | | CREATE TABLE tiles ( [INFO] [stderr] 76 | | zoom_level INTEGER, [INFO] [stderr] 77 | | tile_column INTEGER, [INFO] [stderr] ... | [INFO] [stderr] 89 | | ") [INFO] [stderr] 90 | | .desc("Can't create schema"))) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 58 | | PRAGMA synchronous=0; [INFO] [stderr] 59 | | PRAGMA locking_mode=EXCLUSIVE; [INFO] [stderr] 60 | | PRAGMA journal_mode=DELETE; [INFO] [stderr] 61 | | ") [INFO] [stderr] 62 | | .desc("Cannot execute sqlite optimization query"))) [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 75 | | CREATE TABLE tiles ( [INFO] [stderr] 76 | | zoom_level INTEGER, [INFO] [stderr] 77 | | tile_column INTEGER, [INFO] [stderr] ... | [INFO] [stderr] 89 | | ") [INFO] [stderr] 90 | | .desc("Can't create schema"))) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:32 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:48 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:66 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:40 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:58 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:32 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:48 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:32 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:48 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:66 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:66 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:40 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:58 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:32 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:48 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:66 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:540:9 [INFO] [stderr] | [INFO] [stderr] 540 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:540:9 [INFO] [stderr] | [INFO] [stderr] 540 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:431:58 [INFO] [stderr] | [INFO] [stderr] 431 | .join(format!("{:03}", x as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:434:58 [INFO] [stderr] | [INFO] [stderr] 434 | .join(format!("{:02}", y as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:431:58 [INFO] [stderr] | [INFO] [stderr] 431 | .join(format!("{:03}", x as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mbtiles.rs:434:58 [INFO] [stderr] | [INFO] [stderr] 434 | .join(format!("{:02}", y as i32 / 1000000)) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 58 | | PRAGMA synchronous=0; [INFO] [stderr] 59 | | PRAGMA locking_mode=EXCLUSIVE; [INFO] [stderr] 60 | | PRAGMA journal_mode=DELETE; [INFO] [stderr] 61 | | ") [INFO] [stderr] 62 | | .desc("Cannot execute sqlite optimization query"))) [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 75 | | CREATE TABLE tiles ( [INFO] [stderr] 76 | | zoom_level INTEGER, [INFO] [stderr] 77 | | tile_column INTEGER, [INFO] [stderr] ... | [INFO] [stderr] 89 | | ") [INFO] [stderr] 90 | | .desc("Can't create schema"))) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:32 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:48 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:66 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:40 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:58 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:32 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:48 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:66 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:540:9 [INFO] [stderr] | [INFO] [stderr] 540 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 58 | | PRAGMA synchronous=0; [INFO] [stderr] 59 | | PRAGMA locking_mode=EXCLUSIVE; [INFO] [stderr] 60 | | PRAGMA journal_mode=DELETE; [INFO] [stderr] 61 | | ") [INFO] [stderr] 62 | | .desc("Cannot execute sqlite optimization query"))) [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/mbtiles.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(try!(connection.execute_batch(" [INFO] [stderr] | ________^ [INFO] [stderr] 75 | | CREATE TABLE tiles ( [INFO] [stderr] 76 | | zoom_level INTEGER, [INFO] [stderr] 77 | | tile_column INTEGER, [INFO] [stderr] ... | [INFO] [stderr] 89 | | ") [INFO] [stderr] 90 | | .desc("Can't create schema"))) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:32 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:48 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:302:66 [INFO] [stderr] | [INFO] [stderr] 302 | &[&(zoom as i64), &(column as i64), &(row as i64), &zipped_json]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:24 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:40 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:323:58 [INFO] [stderr] | [INFO] [stderr] 323 | &[&(zoom as i64), &(column as i64), &(row as i64), &key, &key_json.to_string()])); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:32 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(zoom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:48 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mbtiles.rs:350:66 [INFO] [stderr] | [INFO] [stderr] 350 | &[&(zoom as i64), &(column as i64), &(row as i64), &buffer]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mbtiles.rs:540:9 [INFO] [stderr] | [INFO] [stderr] 540 | .ok_or(MBTileError::new_static("Cannot identify an output directory"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| MBTileError::new_static("Cannot identify an output directory"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.30s [INFO] running `"docker" "inspect" "28ca6217b28742c0ef077503f31165e57e4a0be41d345b35857e091eb5498810"` [INFO] running `"docker" "rm" "-f" "28ca6217b28742c0ef077503f31165e57e4a0be41d345b35857e091eb5498810"` [INFO] [stdout] 28ca6217b28742c0ef077503f31165e57e4a0be41d345b35857e091eb5498810