[INFO] crate mbox-reader 0.1.0 is already in cache [INFO] extracting crate mbox-reader 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mbox-reader/0.1.0 [INFO] extracting crate mbox-reader 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mbox-reader/0.1.0 [INFO] validating manifest of mbox-reader-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mbox-reader-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mbox-reader-0.1.0 [INFO] finished frobbing mbox-reader-0.1.0 [INFO] frobbed toml for mbox-reader-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mbox-reader/0.1.0/Cargo.toml [INFO] started frobbing mbox-reader-0.1.0 [INFO] finished frobbing mbox-reader-0.1.0 [INFO] frobbed toml for mbox-reader-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mbox-reader/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mbox-reader-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mbox-reader/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31fcb65f15c6eaecdee1d2015edfe4fdc768c678aa7ed50178af173ffd6134d0 [INFO] running `"docker" "start" "-a" "31fcb65f15c6eaecdee1d2015edfe4fdc768c678aa7ed50178af173ffd6134d0"` [INFO] [stderr] Checking mbox-reader v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn iter<'a>(&'a self) -> MboxReader<'a> { [INFO] [stderr] 85 | | MboxReader::new(self) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:100:53 [INFO] [stderr] | [INFO] [stderr] 100 | Some(pos) => Start { bytes: &self.bytes[..pos + 1] }, [INFO] [stderr] | ^^^^^^^^^ help: use: `..=pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn iter<'a>(&'a self) -> MboxReader<'a> { [INFO] [stderr] 85 | | MboxReader::new(self) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:100:53 [INFO] [stderr] | [INFO] [stderr] 100 | Some(pos) => Start { bytes: &self.bytes[..pos + 1] }, [INFO] [stderr] | ^^^^^^^^^ help: use: `..=pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "31fcb65f15c6eaecdee1d2015edfe4fdc768c678aa7ed50178af173ffd6134d0"` [INFO] running `"docker" "rm" "-f" "31fcb65f15c6eaecdee1d2015edfe4fdc768c678aa7ed50178af173ffd6134d0"` [INFO] [stdout] 31fcb65f15c6eaecdee1d2015edfe4fdc768c678aa7ed50178af173ffd6134d0