[INFO] crate may_queue 0.1.2 is already in cache [INFO] extracting crate may_queue 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/may_queue/0.1.2 [INFO] extracting crate may_queue 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/may_queue/0.1.2 [INFO] validating manifest of may_queue-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of may_queue-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing may_queue-0.1.2 [INFO] finished frobbing may_queue-0.1.2 [INFO] frobbed toml for may_queue-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/may_queue/0.1.2/Cargo.toml [INFO] started frobbing may_queue-0.1.2 [INFO] finished frobbing may_queue-0.1.2 [INFO] frobbed toml for may_queue-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/may_queue/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting may_queue-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/may_queue/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 675695617ffdd56e1e5f57a7513c50623af294943379083dc6020de42a9e77f6 [INFO] running `"docker" "start" "-a" "675695617ffdd56e1e5f57a7513c50623af294943379083dc6020de42a9e77f6"` [INFO] [stderr] Compiling may_queue v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpmc_bounded.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpsc_list_v1.rs:153:22 [INFO] [stderr] | [INFO] [stderr] 153 | (Entry { node: node }, is_head) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpmc_bounded.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mpsc_list_v1.rs:153:22 [INFO] [stderr] | [INFO] [stderr] 153 | (Entry { node: node }, is_head) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/block_node.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let data = self.data.ptr().offset((index & BLOCK_MASK) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.ptr().add((index & BLOCK_MASK))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/block_node.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | let data = self.data.ptr().offset((index & BLOCK_MASK) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.ptr().add((index & BLOCK_MASK))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/block_node.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut p_data = self.data.ptr().offset((start & BLOCK_MASK) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.ptr().add((start & BLOCK_MASK))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpsc_list::Queue` [INFO] [stderr] --> src/mpsc_list.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Queue { [INFO] [stderr] 35 | | let stub = unsafe { Node::new(None) }; [INFO] [stderr] 36 | | Queue { [INFO] [stderr] 37 | | head: AtomicPtr::new(stub), [INFO] [stderr] 38 | | tail: UnsafeCell::new(stub), [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | impl Default for mpsc_list::Queue { [INFO] [stderr] 32 | fn default() -> Self { [INFO] [stderr] 33 | Self::new() [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/mpsc_list_v1.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn get_data(&self) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/mpsc_list_v1.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn get_data(&self) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpsc_list_v1::Queue` [INFO] [stderr] --> src/mpsc_list_v1.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new() -> Queue { [INFO] [stderr] 133 | | let stub = unsafe { Node::new(None) }; [INFO] [stderr] 134 | | // there is no handle for the node, so it's ref should be 1 now [INFO] [stderr] 135 | | unsafe { &mut *stub }.refs = 1; [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | impl Default for mpsc_list_v1::Queue { [INFO] [stderr] 130 | fn default() -> Self { [INFO] [stderr] 131 | Self::new() [INFO] [stderr] 132 | } [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `spsc::Queue` [INFO] [stderr] --> src/spsc.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Self { [INFO] [stderr] 33 | | let init_block = BlockNode::::new(); [INFO] [stderr] 34 | | Queue { [INFO] [stderr] 35 | | head: init_block, [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for spsc::Queue { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `may_queue`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/block_node.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | let data = self.data.ptr().offset((index & BLOCK_MASK) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.ptr().add((index & BLOCK_MASK))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/block_node.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | let data = self.data.ptr().offset((index & BLOCK_MASK) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.ptr().add((index & BLOCK_MASK))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/block_node.rs:77:26 [INFO] [stderr] | [INFO] [stderr] 77 | let mut p_data = self.data.ptr().offset((start & BLOCK_MASK) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.ptr().add((start & BLOCK_MASK))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpsc_list::Queue` [INFO] [stderr] --> src/mpsc_list.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Queue { [INFO] [stderr] 35 | | let stub = unsafe { Node::new(None) }; [INFO] [stderr] 36 | | Queue { [INFO] [stderr] 37 | | head: AtomicPtr::new(stub), [INFO] [stderr] 38 | | tail: UnsafeCell::new(stub), [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | impl Default for mpsc_list::Queue { [INFO] [stderr] 32 | fn default() -> Self { [INFO] [stderr] 33 | Self::new() [INFO] [stderr] 34 | } [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/mpsc_list_v1.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn get_data(&self) -> &mut T { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/mpsc_list_v1.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | pub unsafe fn get_data(&self) -> &mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpsc_list_v1::Queue` [INFO] [stderr] --> src/mpsc_list_v1.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new() -> Queue { [INFO] [stderr] 133 | | let stub = unsafe { Node::new(None) }; [INFO] [stderr] 134 | | // there is no handle for the node, so it's ref should be 1 now [INFO] [stderr] 135 | | unsafe { &mut *stub }.refs = 1; [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | impl Default for mpsc_list_v1::Queue { [INFO] [stderr] 130 | fn default() -> Self { [INFO] [stderr] 131 | Self::new() [INFO] [stderr] 132 | } [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `spsc::Queue` [INFO] [stderr] --> src/spsc.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> Self { [INFO] [stderr] 33 | | let init_block = BlockNode::::new(); [INFO] [stderr] 34 | | Queue { [INFO] [stderr] 35 | | head: init_block, [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for spsc::Queue { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `may_queue`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "675695617ffdd56e1e5f57a7513c50623af294943379083dc6020de42a9e77f6"` [INFO] running `"docker" "rm" "-f" "675695617ffdd56e1e5f57a7513c50623af294943379083dc6020de42a9e77f6"` [INFO] [stdout] 675695617ffdd56e1e5f57a7513c50623af294943379083dc6020de42a9e77f6