[INFO] crate maxminddb 0.11.0 is already in cache [INFO] extracting crate maxminddb 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/maxminddb/0.11.0 [INFO] extracting crate maxminddb 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maxminddb/0.11.0 [INFO] validating manifest of maxminddb-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maxminddb-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maxminddb-0.11.0 [INFO] finished frobbing maxminddb-0.11.0 [INFO] frobbed toml for maxminddb-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/maxminddb/0.11.0/Cargo.toml [INFO] started frobbing maxminddb-0.11.0 [INFO] finished frobbing maxminddb-0.11.0 [INFO] frobbed toml for maxminddb-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maxminddb/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maxminddb-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/maxminddb/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88b23b89af145eda272a7b0f58603da315fab95a50c186a3e286af8b71d9a30c [INFO] running `"docker" "start" "-a" "88b23b89af145eda272a7b0f58603da315fab95a50c186a3e286af8b71d9a30c"` [INFO] [stderr] Checking maxminddb v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/maxminddb/reader_test.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(result.double, 42.123456); [INFO] [stderr] | ^^^^^^^^^ help: consider: `42.123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/maxminddb/reader_test.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | assert_eq!(result.int32, -268435456); [INFO] [stderr] | ^^^^^^^^^ help: consider: `268_435_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/maxminddb/reader_test.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | assert_eq!(result.uint32, 268435456); [INFO] [stderr] | ^^^^^^^^^ help: consider: `268_435_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/maxminddb/reader_test.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!(result.uint64, 1152921504606846976); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_152_921_504_606_846_976` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/maxminddb/reader_test.rs:213:37 [INFO] [stderr] | [INFO] [stderr] 213 | assert!(metadata.build_epoch >= 1397457605); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_397_457_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maxminddb/lib.rs:542:5 [INFO] [stderr] | [INFO] [stderr] 542 | / pub fn from_buf<'buf>(buf: &'buf [u8]) -> Result, MaxMindDBError> { [INFO] [stderr] 543 | | let data_section_separator_size = 16; [INFO] [stderr] 544 | | [INFO] [stderr] 545 | | let metadata_start = find_metadata_start(&buf)?; [INFO] [stderr] ... | [INFO] [stderr] 579 | | Ok(reader) [INFO] [stderr] 580 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maxminddb/lib.rs:542:5 [INFO] [stderr] | [INFO] [stderr] 542 | / pub fn from_buf<'buf>(buf: &'buf [u8]) -> Result, MaxMindDBError> { [INFO] [stderr] 543 | | let data_section_separator_size = 16; [INFO] [stderr] 544 | | [INFO] [stderr] 545 | | let metadata_start = find_metadata_start(&buf)?; [INFO] [stderr] ... | [INFO] [stderr] 579 | | Ok(reader) [INFO] [stderr] 580 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/maxminddb/reader_test.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(result.double, 42.123456); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/maxminddb/reader_test.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(result.double, 42.123456); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/maxminddb/reader_test.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(result.float, 1.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/maxminddb/reader_test.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(result.float, 1.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/maxminddb/reader_test.rs:217:10 [INFO] [stderr] | [INFO] [stderr] 217 | *metadata.description.get(&"en".to_string()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&metadata.description[&"en".to_string()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/maxminddb/reader_test.rs:221:10 [INFO] [stderr] | [INFO] [stderr] 221 | *metadata.description.get(&"zh".to_string()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&metadata.description[&"zh".to_string()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `maxminddb`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "88b23b89af145eda272a7b0f58603da315fab95a50c186a3e286af8b71d9a30c"` [INFO] running `"docker" "rm" "-f" "88b23b89af145eda272a7b0f58603da315fab95a50c186a3e286af8b71d9a30c"` [INFO] [stdout] 88b23b89af145eda272a7b0f58603da315fab95a50c186a3e286af8b71d9a30c