[INFO] crate maven-version-rs 0.1.0 is already in cache
[INFO] extracting crate maven-version-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/maven-version-rs/0.1.0
[INFO] extracting crate maven-version-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maven-version-rs/0.1.0
[INFO] validating manifest of maven-version-rs-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of maven-version-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing maven-version-rs-0.1.0
[INFO] finished frobbing maven-version-rs-0.1.0
[INFO] frobbed toml for maven-version-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/maven-version-rs/0.1.0/Cargo.toml
[INFO] started frobbing maven-version-rs-0.1.0
[INFO] finished frobbing maven-version-rs-0.1.0
[INFO] frobbed toml for maven-version-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maven-version-rs/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting maven-version-rs-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/maven-version-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 379027d12ea3574f8c486913d39499e71be9a899caed9d661e46beaa28ecf418
[INFO] running `"docker" "start" "-a" "379027d12ea3574f8c486913d39499e71be9a899caed9d661e46beaa28ecf418"`
[INFO] [stderr]     Checking maven-version-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:174:9
[INFO] [stderr]     |
[INFO] [stderr] 174 |         major_version: major_version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `major_version`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 |         minor_version: minor_version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minor_version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 |         incremental_version: incremental_version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `incremental_version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |         build_number: build_number,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         qualifier: qualifier,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `qualifier`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:174:9
[INFO] [stderr]     |
[INFO] [stderr] 174 |         major_version: major_version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `major_version`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 |         minor_version: minor_version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minor_version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 |         incremental_version: incremental_version,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `incremental_version`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 |         build_number: build_number,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/maven2.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         qualifier: qualifier,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `qualifier`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/maven3.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 | const RELEASE_VERSION_INDEX: &'static str = "5"; // QUALIFIERS index of ""
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/maven3.rs:362:38
[INFO] [stderr]     |
[INFO] [stderr] 362 |             normalize_sublist(items, (index + 1), start_index + 1);
[INFO] [stderr]     |                                      ^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/maven3.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 | const RELEASE_VERSION_INDEX: &'static str = "5"; // QUALIFIERS index of ""
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/maven3.rs:362:38
[INFO] [stderr]     |
[INFO] [stderr] 362 |             normalize_sublist(items, (index + 1), start_index + 1);
[INFO] [stderr]     |                                      ^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/maven3.rs:397:33
[INFO] [stderr]     |
[INFO] [stderr] 397 |     const VERSIONS_QUALIFIER: [&'static str; 22] = ["1-alpha2snapshot", "1-alpha2", "1-alpha-123", "1-beta-2", "1-beta123", "1-m2", "1-m11", "1-rc", "1-cr2",
[INFO] [stderr]     |                                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/maven3.rs:400:30
[INFO] [stderr]     |
[INFO] [stderr] 400 |     const VERSIONS_NUMBER: [&'static str; 25] = ["2.0", "2-1", "2.0.a", "2.0.0.a", "2.0.2", "2.0.123", "2.1.0", "2.1-a", "2.1b", "2.1-c", "2.1-1", "2.1.0.1",
[INFO] [stderr]     |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:278:67
[INFO] [stderr]     |
[INFO] [stderr] 278 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:287:67
[INFO] [stderr]     |
[INFO] [stderr] 287 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:296:67
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:306:67
[INFO] [stderr]     |
[INFO] [stderr] 306 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:317:54
[INFO] [stderr]     |
[INFO] [stderr] 317 |         let substring: String = chars[start_index..].into_iter().collect();
[INFO] [stderr]     |                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/maven2.rs:404:5
[INFO] [stderr]     |
[INFO] [stderr] 404 | /     fn new_artifact_version<'a>(version: &'a str) -> Maven2ArtifactVersion<'a> {
[INFO] [stderr] 405 | |         Maven2ArtifactVersion::from(version)
[INFO] [stderr] 406 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:278:67
[INFO] [stderr]     |
[INFO] [stderr] 278 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:287:67
[INFO] [stderr]     |
[INFO] [stderr] 287 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:296:67
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:306:67
[INFO] [stderr]     |
[INFO] [stderr] 306 |                 let substring: String = chars[start_index..index].into_iter().collect();
[INFO] [stderr]     |                                                                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]    --> src/maven3.rs:317:54
[INFO] [stderr]     |
[INFO] [stderr] 317 |         let substring: String = chars[start_index..].into_iter().collect();
[INFO] [stderr]     |                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `c`.
[INFO] [stderr]    --> src/maven3.rs:448:22
[INFO] [stderr]     |
[INFO] [stderr] 448 |             for j in i..versions.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 448 |             for <item> in c.iter().take(versions.len()).skip(i) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.20s
[INFO] running `"docker" "inspect" "379027d12ea3574f8c486913d39499e71be9a899caed9d661e46beaa28ecf418"`
[INFO] running `"docker" "rm" "-f" "379027d12ea3574f8c486913d39499e71be9a899caed9d661e46beaa28ecf418"`
[INFO] [stdout] 379027d12ea3574f8c486913d39499e71be9a899caed9d661e46beaa28ecf418