[INFO] crate matmath 1.2.2 is already in cache
[INFO] extracting crate matmath 1.2.2 into work/ex/clippy-test-run/sources/stable/reg/matmath/1.2.2
[INFO] extracting crate matmath 1.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/matmath/1.2.2
[INFO] validating manifest of matmath-1.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of matmath-1.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing matmath-1.2.2
[INFO] finished frobbing matmath-1.2.2
[INFO] frobbed toml for matmath-1.2.2 written to work/ex/clippy-test-run/sources/stable/reg/matmath/1.2.2/Cargo.toml
[INFO] started frobbing matmath-1.2.2
[INFO] finished frobbing matmath-1.2.2
[INFO] frobbed toml for matmath-1.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/matmath/1.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting matmath-1.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/matmath/1.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1f7f5d4def722cb2daffbce68fa625fba4cd1887de5a509359898f7353a3c281
[INFO] running `"docker" "start" "-a" "1f7f5d4def722cb2daffbce68fa625fba4cd1887de5a509359898f7353a3c281"`
[INFO] [stderr]     Checking matmath v1.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/game.rs:696:17
[INFO] [stderr]     |
[INFO] [stderr] 696 |             let f = self.focal_length.clone();
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/game.rs:697:17
[INFO] [stderr]     |
[INFO] [stderr] 697 |             let m = f / z;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/game.rs:696:17
[INFO] [stderr]     |
[INFO] [stderr] 696 |             let f = self.focal_length.clone();
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/game.rs:697:17
[INFO] [stderr]     |
[INFO] [stderr] 697 |             let m = f / z;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/matrix_helper.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     data
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/matrix_helper.rs:18:16
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let data = e_data.map(|(_, e)| e);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/matrix_helper.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 |             new_i
[INFO] [stderr]    |             ^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/matrix_helper.rs:12:25
[INFO] [stderr]    |
[INFO] [stderr] 12 |             let new_i = (old_col * rows) + old_row;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/matrix_class.rs:235:17
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 new_i
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/matrix_class.rs:234:29
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 let new_i = (old_col * rows) + old_row;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/special_matrices.rs:273:20
[INFO] [stderr]     |
[INFO] [stderr] 273 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 274 | |                 if col == row { T::one() } else { T::zero() }
[INFO] [stderr] 275 | |             }
[INFO] [stderr]     | |_____________^ help: try: `if col == row { T::one() } else { T::zero() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/matrix_helper.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     data
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/matrix_helper.rs:18:16
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let data = e_data.map(|(_, e)| e);
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/matrix_helper.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 |             new_i
[INFO] [stderr]    |             ^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/matrix_helper.rs:12:25
[INFO] [stderr]    |
[INFO] [stderr] 12 |             let new_i = (old_col * rows) + old_row;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/matrix_class.rs:235:17
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 new_i
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/matrix_class.rs:234:29
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 let new_i = (old_col * rows) + old_row;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/special_matrices.rs:273:20
[INFO] [stderr]     |
[INFO] [stderr] 273 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 274 | |                 if col == row { T::one() } else { T::zero() }
[INFO] [stderr] 275 | |             }
[INFO] [stderr]     | |_____________^ help: try: `if col == row { T::one() } else { T::zero() }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.enumerate()` or similar iterators
[INFO] [stderr]   --> src/std_vec_tools.rs:19:18
[INFO] [stderr]    |
[INFO] [stderr] 19 |         for e in self {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/std_vec_tools.rs:61:15
[INFO] [stderr]    |
[INFO] [stderr] 61 |         while v.len() > 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/std_vec_tools.rs:76:15
[INFO] [stderr]    |
[INFO] [stderr] 76 |         while v.len() > 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/matrix_class.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 |                       0 as $x
[INFO] [stderr]    |                       ^ help: try: `f64::from(0)`
[INFO] [stderr] ...
[INFO] [stderr] 27 | / impl_matrix_element!(
[INFO] [stderr] 28 | |     i8, i16, i32, i64, i128,
[INFO] [stderr] 29 | |     u8, u16, u32, u64, u128,
[INFO] [stderr] 30 | |     f32, f64
[INFO] [stderr] 31 | | );
[INFO] [stderr]    | |__- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/matrix_class.rs:20:21
[INFO] [stderr]    |
[INFO] [stderr] 20 |                       1 as $x
[INFO] [stderr]    |                       ^ help: try: `f64::from(1)`
[INFO] [stderr] ...
[INFO] [stderr] 27 | / impl_matrix_element!(
[INFO] [stderr] 28 | |     i8, i16, i32, i64, i128,
[INFO] [stderr] 29 | |     u8, u16, u32, u64, u128,
[INFO] [stderr] 30 | |     f32, f64
[INFO] [stderr] 31 | | );
[INFO] [stderr]    | |__- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/matrix_class.rs:121:28
[INFO] [stderr]     |
[INFO] [stderr] 121 |           let data: Vec<T> = [e].iter()
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 122 | |             .cycle()
[INFO] [stderr] 123 | |             .take(len)
[INFO] [stderr] 124 | |             .map(|x| x.clone())
[INFO] [stderr]     | |_______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 121 |         let data: Vec<T> = [e].iter()
[INFO] [stderr] 122 |             .cycle()
[INFO] [stderr] 123 |             .take(len).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/matrix_class.rs:199:12
[INFO] [stderr]     |
[INFO] [stderr] 199 |         Ok(self.data.get(i).unwrap().clone())
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.data[i]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.enumerate()` or similar iterators
[INFO] [stderr]   --> src/std_vec_tools.rs:19:18
[INFO] [stderr]    |
[INFO] [stderr] 19 |         for e in self {
[INFO] [stderr]    |                  ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/std_vec_tools.rs:61:15
[INFO] [stderr]    |
[INFO] [stderr] 61 |         while v.len() > 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/std_vec_tools.rs:76:15
[INFO] [stderr]    |
[INFO] [stderr] 76 |         while v.len() > 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/matrix_class.rs:17:21
[INFO] [stderr]    |
[INFO] [stderr] 17 |                       0 as $x
[INFO] [stderr]    |                       ^ help: try: `f64::from(0)`
[INFO] [stderr] ...
[INFO] [stderr] 27 | / impl_matrix_element!(
[INFO] [stderr] 28 | |     i8, i16, i32, i64, i128,
[INFO] [stderr] 29 | |     u8, u16, u32, u64, u128,
[INFO] [stderr] 30 | |     f32, f64
[INFO] [stderr] 31 | | );
[INFO] [stderr]    | |__- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/matrix_class.rs:20:21
[INFO] [stderr]    |
[INFO] [stderr] 20 |                       1 as $x
[INFO] [stderr]    |                       ^ help: try: `f64::from(1)`
[INFO] [stderr] ...
[INFO] [stderr] 27 | / impl_matrix_element!(
[INFO] [stderr] 28 | |     i8, i16, i32, i64, i128,
[INFO] [stderr] 29 | |     u8, u16, u32, u64, u128,
[INFO] [stderr] 30 | |     f32, f64
[INFO] [stderr] 31 | | );
[INFO] [stderr]    | |__- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/matrix_class.rs:121:28
[INFO] [stderr]     |
[INFO] [stderr] 121 |           let data: Vec<T> = [e].iter()
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 122 | |             .cycle()
[INFO] [stderr] 123 | |             .take(len)
[INFO] [stderr] 124 | |             .map(|x| x.clone())
[INFO] [stderr]     | |_______________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]     |
[INFO] [stderr] 121 |         let data: Vec<T> = [e].iter()
[INFO] [stderr] 122 |             .cycle()
[INFO] [stderr] 123 |             .take(len).cloned()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/matrix_class.rs:199:12
[INFO] [stderr]     |
[INFO] [stderr] 199 |         Ok(self.data.get(i).unwrap().clone())
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.data[i]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.54s
[INFO] running `"docker" "inspect" "1f7f5d4def722cb2daffbce68fa625fba4cd1887de5a509359898f7353a3c281"`
[INFO] running `"docker" "rm" "-f" "1f7f5d4def722cb2daffbce68fa625fba4cd1887de5a509359898f7353a3c281"`
[INFO] [stdout] 1f7f5d4def722cb2daffbce68fa625fba4cd1887de5a509359898f7353a3c281