[INFO] crate mat32 0.2.1 is already in cache [INFO] extracting crate mat32 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/mat32/0.2.1 [INFO] extracting crate mat32 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mat32/0.2.1 [INFO] validating manifest of mat32-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mat32-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mat32-0.2.1 [INFO] finished frobbing mat32-0.2.1 [INFO] frobbed toml for mat32-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/mat32/0.2.1/Cargo.toml [INFO] started frobbing mat32-0.2.1 [INFO] finished frobbing mat32-0.2.1 [INFO] frobbed toml for mat32-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mat32/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mat32-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mat32/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ac4fe39bafe31fbef9b5c3987db8d5717fbc49cda7192eadcb5e16cbff75663 [INFO] running `"docker" "start" "-a" "5ac4fe39bafe31fbef9b5c3987db8d5717fbc49cda7192eadcb5e16cbff75663"` [INFO] [stderr] Checking cast_trait v0.1.2 [INFO] [stderr] Checking vec3 v0.2.1 [INFO] [stderr] Checking vec2 v0.2.1 [INFO] [stderr] Checking mat32 v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let s = a.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | let s = a.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | out[4] = position[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `position[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | out[5] = position[1].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `position[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | position[0] = out[4].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | position[1] = out[5].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[5]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | *rotation = out[1].atan2(out[0].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn rotation<'out, T>(out: &[T; 6]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | out[1].atan2(out[0].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let x = &target[0] - &eye[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 81 | let x = target[0] - eye[0]; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let y = &target[1] - &eye[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 82 | let y = target[1] - eye[1]; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let a = &y.atan2(x) - &T::from_f64(f64::consts::FRAC_PI_2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 83 | let a = y.atan2(x) - T::from_f64(f64::consts::FRAC_PI_2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | out[0] = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | out[1] = s.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | out[4] = position[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `position[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | out[5] = position[1].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `position[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | position[0] = out[4].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | position[1] = out[5].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[5]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compose.rs:66:30 [INFO] [stderr] | [INFO] [stderr] 66 | *rotation = out[1].atan2(out[0].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn rotation<'out, T>(out: &[T; 6]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | out[1].atan2(out[0].clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `out[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let x = &target[0] - &eye[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 81 | let x = target[0] - eye[0]; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let y = &target[1] - &eye[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 82 | let y = target[1] - eye[1]; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/transform.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let a = &y.atan2(x) - &T::from_f64(f64::consts::FRAC_PI_2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 83 | let a = y.atan2(x) - T::from_f64(f64::consts::FRAC_PI_2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | out[0] = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | out[1] = s.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.99s [INFO] running `"docker" "inspect" "5ac4fe39bafe31fbef9b5c3987db8d5717fbc49cda7192eadcb5e16cbff75663"` [INFO] running `"docker" "rm" "-f" "5ac4fe39bafe31fbef9b5c3987db8d5717fbc49cda7192eadcb5e16cbff75663"` [INFO] [stdout] 5ac4fe39bafe31fbef9b5c3987db8d5717fbc49cda7192eadcb5e16cbff75663