[INFO] crate mat3 0.2.1 is already in cache [INFO] extracting crate mat3 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/mat3/0.2.1 [INFO] extracting crate mat3 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mat3/0.2.1 [INFO] validating manifest of mat3-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mat3-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mat3-0.2.1 [INFO] finished frobbing mat3-0.2.1 [INFO] frobbed toml for mat3-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/mat3/0.2.1/Cargo.toml [INFO] started frobbing mat3-0.2.1 [INFO] finished frobbing mat3-0.2.1 [INFO] frobbed toml for mat3-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mat3/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mat3-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mat3/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78c2fc6461132976f15bc1b1253dda1e706cf9be3bfb7db4e695d65f814250ca [INFO] running `"docker" "start" "-a" "78c2fc6461132976f15bc1b1253dda1e706cf9be3bfb7db4e695d65f814250ca"` [INFO] [stderr] Checking mat3 v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/det.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let e = &out[4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/det.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let f = &out[5]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/det.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let g = &out[6]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/det.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let h = &out[7]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/det.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let i = &out[8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/set.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | let w = &q[3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let z = &v[2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/det.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let e = &out[4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/det.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let f = &out[5]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/det.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let g = &out[6]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/det.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let h = &out[7]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/det.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let i = &out[8]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/set.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | let w = &q[3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let z = &v[2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/det.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return &(a * e) * i - &(a * f) * h - &(b * d) * i + &(b * f) * g + &(c * d) * h - &(c * e) * g; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&(a * e) * i - &(a * f) * h - &(b * d) * i + &(b * f) * g + &(c * d) * h - &(c * e) * g` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/inv.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn inv_mat3_values<'out, T>( [INFO] [stderr] 15 | | out: &'out mut [T; 9], [INFO] [stderr] 16 | | m00: &T, [INFO] [stderr] 17 | | m01: &T, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/new.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn new(m00: T, m01: T, m02: T, m10: T, m11: T, m12: T, m20: T, m21: T, m22: T) -> [T; 9] { [INFO] [stderr] 5 | | [m00, m10, m20, m01, m11, m21, m02, m12, m22] [INFO] [stderr] 6 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/det.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return &(a * e) * i - &(a * f) * h - &(b * d) * i + &(b * f) * g + &(c * d) * h - &(c * e) * g; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&(a * e) * i - &(a * f) * h - &(b * d) * i + &(b * f) * g + &(c * d) * h - &(c * e) * g` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/set.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn set( [INFO] [stderr] 7 | | out: &mut [T; 9], [INFO] [stderr] 8 | | m00: T, [INFO] [stderr] 9 | | m01: T, [INFO] [stderr] ... | [INFO] [stderr] 27 | | out [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/inv.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn inv_mat3_values<'out, T>( [INFO] [stderr] 15 | | out: &'out mut [T; 9], [INFO] [stderr] 16 | | m00: &T, [INFO] [stderr] 17 | | m01: &T, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/new.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub fn new(m00: T, m01: T, m02: T, m10: T, m11: T, m12: T, m20: T, m21: T, m22: T) -> [T; 9] { [INFO] [stderr] 5 | | [m00, m10, m20, m01, m11, m21, m02, m12, m22] [INFO] [stderr] 6 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/set.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn set( [INFO] [stderr] 7 | | out: &mut [T; 9], [INFO] [stderr] 8 | | m00: T, [INFO] [stderr] 9 | | m01: T, [INFO] [stderr] ... | [INFO] [stderr] 27 | | out [INFO] [stderr] 28 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "78c2fc6461132976f15bc1b1253dda1e706cf9be3bfb7db4e695d65f814250ca"` [INFO] running `"docker" "rm" "-f" "78c2fc6461132976f15bc1b1253dda1e706cf9be3bfb7db4e695d65f814250ca"` [INFO] [stdout] 78c2fc6461132976f15bc1b1253dda1e706cf9be3bfb7db4e695d65f814250ca