[INFO] crate marpa 0.2.1 is already in cache
[INFO] extracting crate marpa 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/marpa/0.2.1
[INFO] extracting crate marpa 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/marpa/0.2.1
[INFO] validating manifest of marpa-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of marpa-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing marpa-0.2.1
[INFO] finished frobbing marpa-0.2.1
[INFO] frobbed toml for marpa-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/marpa/0.2.1/Cargo.toml
[INFO] started frobbing marpa-0.2.1
[INFO] finished frobbing marpa-0.2.1
[INFO] frobbed toml for marpa-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/marpa/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting marpa-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/marpa/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9625d3cd4a89468981d790f538e9415a14932f78feeb4d83063df57bb9f671b5
[INFO] running `"docker" "start" "-a" "9625d3cd4a89468981d790f538e9415a14932f78feeb4d83063df57bb9f671b5"`
[INFO] [stderr]    Compiling autotools v0.1.3
[INFO] [stderr]    Compiling libmarpa-sys v0.1.3
[INFO] [stderr]     Checking marpa v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/thin/recognizer.rs:215:69
[INFO] [stderr]     |
[INFO] [stderr] 215 |             ruleid if ruleid >= 0 => Ok(ProgressItem{ rule: ruleid, pos: pos, origin: origin }),
[INFO] [stderr]     |                                                                     ^^^^^^^^ help: replace it with: `pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/thin/recognizer.rs:215:79
[INFO] [stderr]     |
[INFO] [stderr] 215 |             ruleid if ruleid >= 0 => Ok(ProgressItem{ rule: ruleid, pos: pos, origin: origin }),
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^ help: replace it with: `origin`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/bocage.rs:50:43
[INFO] [stderr]    |
[INFO] [stderr] 50 |             b => Ok( Bocage{ internal: b, grammar: grammar }),
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/order.rs:50:42
[INFO] [stderr]    |
[INFO] [stderr] 50 |             o => Ok( Order{ internal: o, grammar: grammar }),
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/tree.rs:50:41
[INFO] [stderr]    |
[INFO] [stderr] 50 |             t => Ok( Tree{ internal: t, grammar: grammar }),
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/value.rs:27:42
[INFO] [stderr]    |
[INFO] [stderr] 27 |             v => Ok( Value{ internal: v, grammar: grammar }),
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lexer/byte_scanner.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             rd: rd,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `rd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stack/mod.rs:16:16
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Stack{ items: items, processor: processor }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stack/mod.rs:16:30
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Stack{ items: items, processor: processor }
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/thin/recognizer.rs:215:69
[INFO] [stderr]     |
[INFO] [stderr] 215 |             ruleid if ruleid >= 0 => Ok(ProgressItem{ rule: ruleid, pos: pos, origin: origin }),
[INFO] [stderr]     |                                                                     ^^^^^^^^ help: replace it with: `pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/thin/recognizer.rs:215:79
[INFO] [stderr]     |
[INFO] [stderr] 215 |             ruleid if ruleid >= 0 => Ok(ProgressItem{ rule: ruleid, pos: pos, origin: origin }),
[INFO] [stderr]     |                                                                               ^^^^^^^^^^^^^^ help: replace it with: `origin`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/bocage.rs:50:43
[INFO] [stderr]    |
[INFO] [stderr] 50 |             b => Ok( Bocage{ internal: b, grammar: grammar }),
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/order.rs:50:42
[INFO] [stderr]    |
[INFO] [stderr] 50 |             o => Ok( Order{ internal: o, grammar: grammar }),
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/tree.rs:50:41
[INFO] [stderr]    |
[INFO] [stderr] 50 |             t => Ok( Tree{ internal: t, grammar: grammar }),
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/thin/value.rs:27:42
[INFO] [stderr]    |
[INFO] [stderr] 27 |             v => Ok( Value{ internal: v, grammar: grammar }),
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^^ help: replace it with: `grammar`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lexer/byte_scanner.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             rd: rd,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `rd`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stack/mod.rs:16:16
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Stack{ items: items, processor: processor }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stack/mod.rs:16:30
[INFO] [stderr]    |
[INFO] [stderr] 16 |         Stack{ items: items, processor: processor }
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/thin/grammar.rs:115:12
[INFO] [stderr]     |
[INFO] [stderr] 115 |         Ok((0..try!(self.num_symbols())))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/thin/grammar.rs:115:12
[INFO] [stderr]     |
[INFO] [stderr] 115 |         Ok((0..try!(self.num_symbols())))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/thin/event.rs:27:19
[INFO] [stderr]    |
[INFO] [stderr] 27 |         EventIter((0..count), grammar)
[INFO] [stderr]    |                   ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/error.rs:69:33
[INFO] [stderr]    |
[INFO] [stderr] 69 | const MARPA_ERROR_DESCRIPTION: &'static [MarpaDescription] = &[
[INFO] [stderr]    |                                -^^^^^^^------------------- help: consider removing `'static`: `&[MarpaDescription]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/thin/grammar.rs:115:12
[INFO] [stderr]     |
[INFO] [stderr] 115 |         Ok((0..try!(self.num_symbols())))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/thin/grammar.rs:115:12
[INFO] [stderr]     |
[INFO] [stderr] 115 |         Ok((0..try!(self.num_symbols())))
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/thin/event.rs:27:19
[INFO] [stderr]    |
[INFO] [stderr] 27 |         EventIter((0..count), grammar)
[INFO] [stderr]    |                   ^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/error.rs:69:33
[INFO] [stderr]    |
[INFO] [stderr] 69 | const MARPA_ERROR_DESCRIPTION: &'static [MarpaDescription] = &[
[INFO] [stderr]    |                                -^^^^^^^------------------- help: consider removing `'static`: `&[MarpaDescription]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `EarleyItem`
[INFO] [stderr]  --> src/thin/earley.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub type EarleyItem = Marpa_Earley_Item_ID;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `thin::config::Config`
[INFO] [stderr]   --> src/thin/config.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Config {
[INFO] [stderr] 13 | |         let mut cfg = Config { internal: Marpa_Config::default() };
[INFO] [stderr] 14 | |
[INFO] [stderr] 15 | |         assert!(cfg.init() == MARPA_ERR_NONE);
[INFO] [stderr] 16 | |
[INFO] [stderr] 17 | |         cfg
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/thin/grammar.rs:191:23
[INFO] [stderr]     |
[INFO] [stderr] 191 |             max => Ok(0..max+1),
[INFO] [stderr]     |                       ^^^^^^^^ help: use: `0..=max`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/recognizer.rs:56:18
[INFO] [stderr]    |
[INFO] [stderr] 56 |             n if n == ptr::null_mut() => g.error_or("error creating recognizer"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_null)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/thin/recognizer.rs:236:16
[INFO] [stderr]     |
[INFO] [stderr] 236 |           if let None = res {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 237 | |             res = Some(Ok(report));
[INFO] [stderr] 238 | |         }
[INFO] [stderr]     | |_________- help: try this: `if res.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/bocage.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |             n if n == ptr::null_mut() => grammar.error_or("error creating bocage"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/order.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |             n if n == ptr::null_mut() => grammar.error_or("error creating order"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/tree.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |             n if n == ptr::null_mut() => grammar.error_or("error creating order"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/value.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |             n if n == ptr::null_mut() => grammar.error_or("error creating value"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lexer/byte_scanner.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         self.0 as i32
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: try: `i32::from(self.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lexer/byte_scanner.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         (self.0 + 1) as i32
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.0 + 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/stack/mod.rs:23:89
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 self.items[start as usize] = self.processor.proc_rule(rule, &self.items[start as usize..end as usize + 1]);
[INFO] [stderr]    |                                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start as usize..=end as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/tree_builder/builder.rs:41:23
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn is_discard(&mut self, rule_id: Rule) -> bool {
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/tree_builder/builder.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 | /         match &*child.borrow() {
[INFO] [stderr] 81 | |             &Node::Leaf(tok) => out.push(*tok),
[INFO] [stderr] 82 | |             &Node::Null(_) => {},
[INFO] [stderr] 83 | |             &Node::Tree(_, ref chs) => rollup_token_rec(chs, out),
[INFO] [stderr] 84 | |             &Node::Rule(_, _) => panic!("cannot rollup Rule into Token - this is an internal bug."),
[INFO] [stderr] 85 | |             &Node::Token(_, _) => panic!("cannot rollup Token into Token - this is an internal bug."),
[INFO] [stderr] 86 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 80 |         match *child.borrow() {
[INFO] [stderr] 81 |             Node::Leaf(tok) => out.push(*tok),
[INFO] [stderr] 82 |             Node::Null(_) => {},
[INFO] [stderr] 83 |             Node::Tree(_, ref chs) => rollup_token_rec(chs, out),
[INFO] [stderr] 84 |             Node::Rule(_, _) => panic!("cannot rollup Rule into Token - this is an internal bug."),
[INFO] [stderr] 85 |             Node::Token(_, _) => panic!("cannot rollup Token into Token - this is an internal bug."),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/tree_builder/builder.rs:99:9
[INFO] [stderr]     |
[INFO] [stderr] 99  | /         match &*child.borrow() {
[INFO] [stderr] 100 | |             &Node::Token(_, _) => out.push(child.clone()),
[INFO] [stderr] 101 | |             &Node::Rule(_, _) => out.push(child.clone()),
[INFO] [stderr] 102 | |             &Node::Null(_) => {},
[INFO] [stderr] 103 | |             &Node::Tree(_, ref chs) => rollup_rule_rec(chs, out),
[INFO] [stderr] 104 | |             &Node::Leaf(_) => panic!("cannot rollup Leaf into Rule - this is an internal bug."),
[INFO] [stderr] 105 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 99  |         match *child.borrow() {
[INFO] [stderr] 100 |             Node::Token(_, _) => out.push(child.clone()),
[INFO] [stderr] 101 |             Node::Rule(_, _) => out.push(child.clone()),
[INFO] [stderr] 102 |             Node::Null(_) => {},
[INFO] [stderr] 103 |             Node::Tree(_, ref chs) => rollup_rule_rec(chs, out),
[INFO] [stderr] 104 |             Node::Leaf(_) => panic!("cannot rollup Leaf into Rule - this is an internal bug."),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/mod.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         match self {
[INFO] [stderr] 39 | |             &mut G(ref mut g) => {
[INFO] [stderr] 40 | |                 try!(g.precompute());
[INFO] [stderr] 41 | |                 Recognizer::new(g.clone()).map(|s| R(s))
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |             &mut T(_) => Err("No next state".into()),
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 38 |         match *self {
[INFO] [stderr] 39 |             G(ref mut g) => {
[INFO] [stderr] 40 |                 try!(g.precompute());
[INFO] [stderr] 41 |                 Recognizer::new(g.clone()).map(|s| R(s))
[INFO] [stderr] 42 |             },
[INFO] [stderr] 43 |             R(ref r) => Bocage::new(r.clone()).map(|s| B(s)),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:41:48
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 Recognizer::new(g.clone()).map(|s| R(s))
[INFO] [stderr]    |                                                ^^^^^^^^ help: remove closure as shown: `R`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:43:57
[INFO] [stderr]    |
[INFO] [stderr] 43 |             &mut R(ref r) => Bocage::new(r.clone()).map(|s| B(s)),
[INFO] [stderr]    |                                                         ^^^^^^^^ help: remove closure as shown: `B`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:44:56
[INFO] [stderr]    |
[INFO] [stderr] 44 |             &mut B(ref b) => Order::new(b.clone()).map(|s| O(s)),
[INFO] [stderr]    |                                                        ^^^^^^^^ help: remove closure as shown: `O`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:45:55
[INFO] [stderr]    |
[INFO] [stderr] 45 |             &mut O(ref o) => Tree::new(o.clone()).map(|s| T(s)),
[INFO] [stderr]    |                                                       ^^^^^^^^ help: remove closure as shown: `T`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::Parser`
[INFO] [stderr]   --> src/parser/mod.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     pub fn new() -> Self {
[INFO] [stderr] 72 | |         Parser{ state: Default::default() }
[INFO] [stderr] 73 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/grammar/mod.rs:72:32
[INFO] [stderr]    |
[INFO] [stderr] 72 |     pub fn symbol(&self, item: &Item) -> thin::Symbol {
[INFO] [stderr]    |                                ^^^^^ help: consider passing by value instead: `Item`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/grammar/mod.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 | /         match item {
[INFO] [stderr] 74 | |             &Item::Rule(ref rule) => *self.rules.get(rule).unwrap(),
[INFO] [stderr] 75 | |             &Item::Symbol(ref sym) => *sym,
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 73 |         match *item {
[INFO] [stderr] 74 |             Item::Rule(ref rule) => *self.rules.get(rule).unwrap(),
[INFO] [stderr] 75 |             Item::Symbol(ref sym) => *sym,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/grammar/mod.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |             &Item::Rule(ref rule) => *self.rules.get(rule).unwrap(),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.rules[rule]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grammar/mod.rs:182:48
[INFO] [stderr]     |
[INFO] [stderr] 182 |         self.alternative(lhs, &bytes_to_items(&(from..(to+1)).collect::<Vec<u8>>()))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^ help: use: `(from..=to)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/grammar/mod.rs:201:57
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 try!(self.internal.new_rule(internal, &[b as thin::Symbol]));
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^ help: try: `i32::from(b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/grammar/mod.rs:224:39
[INFO] [stderr]     |
[INFO] [stderr] 224 |     input.iter().map(|x| Item::Symbol(*x as thin::Symbol)) .collect()
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/grammar/mod.rs:231:31
[INFO] [stderr]     |
[INFO] [stderr] 231 |         .map(|x| Item::Symbol(*x as thin::Symbol))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: type alias is never used: `EarleyItem`
[INFO] [stderr]  --> src/thin/earley.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub type EarleyItem = Marpa_Earley_Item_ID;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `thin::config::Config`
[INFO] [stderr]   --> src/thin/config.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Config {
[INFO] [stderr] 13 | |         let mut cfg = Config { internal: Marpa_Config::default() };
[INFO] [stderr] 14 | |
[INFO] [stderr] 15 | |         assert!(cfg.init() == MARPA_ERR_NONE);
[INFO] [stderr] 16 | |
[INFO] [stderr] 17 | |         cfg
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/thin/grammar.rs:191:23
[INFO] [stderr]     |
[INFO] [stderr] 191 |             max => Ok(0..max+1),
[INFO] [stderr]     |                       ^^^^^^^^ help: use: `0..=max`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/thin/grammar.rs:528:20
[INFO] [stderr]     |
[INFO] [stderr] 528 |         g.new_rule(0.into(), &[1, 2]).unwrap();
[INFO] [stderr]     |                    ^^^^^^^^ help: consider removing `.into()`: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/thin/grammar.rs:529:20
[INFO] [stderr]     |
[INFO] [stderr] 529 |         g.new_rule(1.into(), &[3, 4]).unwrap();
[INFO] [stderr]     |                    ^^^^^^^^ help: consider removing `.into()`: `1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/thin/grammar.rs:530:20
[INFO] [stderr]     |
[INFO] [stderr] 530 |         g.new_rule(2.into(), &[]).unwrap();
[INFO] [stderr]     |                    ^^^^^^^^ help: consider removing `.into()`: `2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/thin/grammar.rs:542:17
[INFO] [stderr]     |
[INFO] [stderr] 542 |         assert!(g.symbol_is_terminal(s).unwrap() == false);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!g.symbol_is_terminal(s).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/thin/grammar.rs:544:17
[INFO] [stderr]     |
[INFO] [stderr] 544 |         assert!(g.symbol_is_terminal(s).unwrap() == true);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `g.symbol_is_terminal(s).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/thin/grammar.rs:546:9
[INFO] [stderr]     |
[INFO] [stderr] 546 | /         match term {
[INFO] [stderr] 547 | |             Ok(_) => assert!(false),
[INFO] [stderr] 548 | |             _ => {},
[INFO] [stderr] 549 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Ok(_) = term { assert!(false) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/thin/grammar.rs:570:17
[INFO] [stderr]     |
[INFO] [stderr] 570 |         assert!(g.events().unwrap().collect::<Vec<Event>>().len() == 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `g.events().unwrap().collect::<Vec<Event>>().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]    --> src/thin/grammar.rs:570:36
[INFO] [stderr]     |
[INFO] [stderr] 570 |         assert!(g.events().unwrap().collect::<Vec<Event>>().len() == 0);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/recognizer.rs:56:18
[INFO] [stderr]    |
[INFO] [stderr] 56 |             n if n == ptr::null_mut() => g.error_or("error creating recognizer"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_null)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/thin/recognizer.rs:236:16
[INFO] [stderr]     |
[INFO] [stderr] 236 |           if let None = res {
[INFO] [stderr]     |  _________-      ^^^^
[INFO] [stderr] 237 | |             res = Some(Ok(report));
[INFO] [stderr] 238 | |         }
[INFO] [stderr]     | |_________- help: try this: `if res.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/thin/recognizer.rs:263:17
[INFO] [stderr]     |
[INFO] [stderr] 263 |         assert!(g.events().unwrap().collect::<Vec<Event>>().len() == 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `g.events().unwrap().collect::<Vec<Event>>().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]    --> src/thin/recognizer.rs:263:36
[INFO] [stderr]     |
[INFO] [stderr] 263 |         assert!(g.events().unwrap().collect::<Vec<Event>>().len() == 0);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/thin/recognizer.rs:273:17
[INFO] [stderr]     |
[INFO] [stderr] 273 |         assert!(evs.len() != 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!evs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/bocage.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |             n if n == ptr::null_mut() => grammar.error_or("error creating bocage"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/thin/bocage.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |         assert!(g.events().unwrap().collect::<Vec<Event>>().len() == 0);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `g.events().unwrap().collect::<Vec<Event>>().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]   --> src/thin/bocage.rs:91:36
[INFO] [stderr]    |
[INFO] [stderr] 91 |         assert!(g.events().unwrap().collect::<Vec<Event>>().len() == 0);
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/thin/bocage.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |         assert!(evs.len() != 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!evs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/order.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |             n if n == ptr::null_mut() => grammar.error_or("error creating order"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/tree.rs:49:18
[INFO] [stderr]    |
[INFO] [stderr] 49 |             n if n == ptr::null_mut() => grammar.error_or("error creating order"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method
[INFO] [stderr]   --> src/thin/value.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |             n if n == ptr::null_mut() => grammar.error_or("error creating value"),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lexer/byte_scanner.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         self.0 as i32
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: try: `i32::from(self.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/lexer/byte_scanner.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         (self.0 + 1) as i32
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.0 + 1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/stack/mod.rs:23:89
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 self.items[start as usize] = self.processor.proc_rule(rule, &self.items[start as usize..end as usize + 1]);
[INFO] [stderr]    |                                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start as usize..=end as usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/tree_builder/builder.rs:41:23
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn is_discard(&mut self, rule_id: Rule) -> bool {
[INFO] [stderr]    |                       ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/tree_builder/builder.rs:80:9
[INFO] [stderr]    |
[INFO] [stderr] 80 | /         match &*child.borrow() {
[INFO] [stderr] 81 | |             &Node::Leaf(tok) => out.push(*tok),
[INFO] [stderr] 82 | |             &Node::Null(_) => {},
[INFO] [stderr] 83 | |             &Node::Tree(_, ref chs) => rollup_token_rec(chs, out),
[INFO] [stderr] 84 | |             &Node::Rule(_, _) => panic!("cannot rollup Rule into Token - this is an internal bug."),
[INFO] [stderr] 85 | |             &Node::Token(_, _) => panic!("cannot rollup Token into Token - this is an internal bug."),
[INFO] [stderr] 86 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 80 |         match *child.borrow() {
[INFO] [stderr] 81 |             Node::Leaf(tok) => out.push(*tok),
[INFO] [stderr] 82 |             Node::Null(_) => {},
[INFO] [stderr] 83 |             Node::Tree(_, ref chs) => rollup_token_rec(chs, out),
[INFO] [stderr] 84 |             Node::Rule(_, _) => panic!("cannot rollup Rule into Token - this is an internal bug."),
[INFO] [stderr] 85 |             Node::Token(_, _) => panic!("cannot rollup Token into Token - this is an internal bug."),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/tree_builder/builder.rs:99:9
[INFO] [stderr]     |
[INFO] [stderr] 99  | /         match &*child.borrow() {
[INFO] [stderr] 100 | |             &Node::Token(_, _) => out.push(child.clone()),
[INFO] [stderr] 101 | |             &Node::Rule(_, _) => out.push(child.clone()),
[INFO] [stderr] 102 | |             &Node::Null(_) => {},
[INFO] [stderr] 103 | |             &Node::Tree(_, ref chs) => rollup_rule_rec(chs, out),
[INFO] [stderr] 104 | |             &Node::Leaf(_) => panic!("cannot rollup Leaf into Rule - this is an internal bug."),
[INFO] [stderr] 105 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 99  |         match *child.borrow() {
[INFO] [stderr] 100 |             Node::Token(_, _) => out.push(child.clone()),
[INFO] [stderr] 101 |             Node::Rule(_, _) => out.push(child.clone()),
[INFO] [stderr] 102 |             Node::Null(_) => {},
[INFO] [stderr] 103 |             Node::Tree(_, ref chs) => rollup_rule_rec(chs, out),
[INFO] [stderr] 104 |             Node::Leaf(_) => panic!("cannot rollup Leaf into Rule - this is an internal bug."),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> tests/main.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |     let v = t.next().unwrap();
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/parser/mod.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         match self {
[INFO] [stderr] 39 | |             &mut G(ref mut g) => {
[INFO] [stderr] 40 | |                 try!(g.precompute());
[INFO] [stderr] 41 | |                 Recognizer::new(g.clone()).map(|s| R(s))
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |             &mut T(_) => Err("No next state".into()),
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 38 |         match *self {
[INFO] [stderr] 39 |             G(ref mut g) => {
[INFO] [stderr] 40 |                 try!(g.precompute());
[INFO] [stderr] 41 |                 Recognizer::new(g.clone()).map(|s| R(s))
[INFO] [stderr] 42 |             },
[INFO] [stderr] 43 |             R(ref r) => Bocage::new(r.clone()).map(|s| B(s)),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:41:48
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 Recognizer::new(g.clone()).map(|s| R(s))
[INFO] [stderr]    |                                                ^^^^^^^^ help: remove closure as shown: `R`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:43:57
[INFO] [stderr]    |
[INFO] [stderr] 43 |             &mut R(ref r) => Bocage::new(r.clone()).map(|s| B(s)),
[INFO] [stderr]    |                                                         ^^^^^^^^ help: remove closure as shown: `B`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:44:56
[INFO] [stderr]    |
[INFO] [stderr] 44 |             &mut B(ref b) => Order::new(b.clone()).map(|s| O(s)),
[INFO] [stderr]    |                                                        ^^^^^^^^ help: remove closure as shown: `O`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parser/mod.rs:45:55
[INFO] [stderr]    |
[INFO] [stderr] 45 |             &mut O(ref o) => Tree::new(o.clone()).map(|s| T(s)),
[INFO] [stderr]    |                                                       ^^^^^^^^ help: remove closure as shown: `T`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::Parser`
[INFO] [stderr]   --> src/parser/mod.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 | /     pub fn new() -> Self {
[INFO] [stderr] 72 | |         Parser{ state: Default::default() }
[INFO] [stderr] 73 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/grammar/mod.rs:72:32
[INFO] [stderr]    |
[INFO] [stderr] 72 |     pub fn symbol(&self, item: &Item) -> thin::Symbol {
[INFO] [stderr]    |                                ^^^^^ help: consider passing by value instead: `Item`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/grammar/mod.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 | /         match item {
[INFO] [stderr] 74 | |             &Item::Rule(ref rule) => *self.rules.get(rule).unwrap(),
[INFO] [stderr] 75 | |             &Item::Symbol(ref sym) => *sym,
[INFO] [stderr] 76 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 73 |         match *item {
[INFO] [stderr] 74 |             Item::Rule(ref rule) => *self.rules.get(rule).unwrap(),
[INFO] [stderr] 75 |             Item::Symbol(ref sym) => *sym,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/grammar/mod.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |             &Item::Rule(ref rule) => *self.rules.get(rule).unwrap(),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.rules[rule]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/grammar/mod.rs:182:48
[INFO] [stderr]     |
[INFO] [stderr] 182 |         self.alternative(lhs, &bytes_to_items(&(from..(to+1)).collect::<Vec<u8>>()))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^ help: use: `(from..=to)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/grammar/mod.rs:201:57
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 try!(self.internal.new_rule(internal, &[b as thin::Symbol]));
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^ help: try: `i32::from(b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/grammar/mod.rs:224:39
[INFO] [stderr]     |
[INFO] [stderr] 224 |     input.iter().map(|x| Item::Symbol(*x as thin::Symbol)) .collect()
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/grammar/mod.rs:231:31
[INFO] [stderr]     |
[INFO] [stderr] 231 |         .map(|x| Item::Symbol(*x as thin::Symbol))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*x)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.26s
[INFO] running `"docker" "inspect" "9625d3cd4a89468981d790f538e9415a14932f78feeb4d83063df57bb9f671b5"`
[INFO] running `"docker" "rm" "-f" "9625d3cd4a89468981d790f538e9415a14932f78feeb4d83063df57bb9f671b5"`
[INFO] [stdout] 9625d3cd4a89468981d790f538e9415a14932f78feeb4d83063df57bb9f671b5