[INFO] crate markov-chain 0.1.1 is already in cache [INFO] extracting crate markov-chain 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/markov-chain/0.1.1 [INFO] extracting crate markov-chain 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/markov-chain/0.1.1 [INFO] validating manifest of markov-chain-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of markov-chain-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing markov-chain-0.1.1 [INFO] finished frobbing markov-chain-0.1.1 [INFO] frobbed toml for markov-chain-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/markov-chain/0.1.1/Cargo.toml [INFO] started frobbing markov-chain-0.1.1 [INFO] finished frobbing markov-chain-0.1.1 [INFO] frobbed toml for markov-chain-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/markov-chain/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting markov-chain-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/markov-chain/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f1c7c72de1d908a100d13c082970e340cbc97f569c112d884cba3877dfd82fc [INFO] running `"docker" "start" "-a" "9f1c7c72de1d908a100d13c082970e340cbc97f569c112d884cba3877dfd82fc"` [INFO] [stderr] Checking markov-chain v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | .map(|x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:228:12 [INFO] [stderr] | [INFO] [stderr] 228 | if curs.iter().find(|x| x.is_none()).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|x| x.is_none()).is_some()` with `any(|x| x.is_none())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:259:40 [INFO] [stderr] | [INFO] [stderr] 259 | fn choose_random_link(&self, node: &Node) -> Option<&T> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | .map(|x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:228:12 [INFO] [stderr] | [INFO] [stderr] 228 | if curs.iter().find(|x| x.is_none()).is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|x| x.is_none()).is_some()` with `any(|x| x.is_none())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:259:40 [INFO] [stderr] | [INFO] [stderr] 259 | fn choose_random_link(&self, node: &Node) -> Option<&T> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 419 | let link = test_get_link!(chain, [1u32]); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 423 | let link = test_get_link!(chain, [2u32]); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 426 | let link = test_get_link!(chain, [3u32]); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 430 | let link = test_get_link!(chain, [4u32]); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 440 | let link = test_get_link!(chain, [1u32, 2u32]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 443 | let link = test_get_link!(chain, [2u32, 3u32]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 447 | let link = test_get_link!(chain, [3u32, 4u32]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 450 | let link = test_get_link!(chain, [1u32, 3u32]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 459 | let link = test_get_link!(chain, [1u32, 2u32, 3u32]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 462 | let link = test_get_link!(chain, [2u32, 3u32, 4u32]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 466 | let link = test_get_link!(chain, [3u32, 4u32, 1u32]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:369:17 [INFO] [stderr] | [INFO] [stderr] 369 | let ref map = $chain.chain; [INFO] [stderr] | ----^^^^^^^---------------- help: try: `let map = &$chain.chain;` [INFO] [stderr] ... [INFO] [stderr] 469 | let link = test_get_link!(chain, [4u32, 1u32, 2u32]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.65s [INFO] running `"docker" "inspect" "9f1c7c72de1d908a100d13c082970e340cbc97f569c112d884cba3877dfd82fc"` [INFO] running `"docker" "rm" "-f" "9f1c7c72de1d908a100d13c082970e340cbc97f569c112d884cba3877dfd82fc"` [INFO] [stdout] 9f1c7c72de1d908a100d13c082970e340cbc97f569c112d884cba3877dfd82fc