[INFO] crate markdown 0.2.0 is already in cache [INFO] extracting crate markdown 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/markdown/0.2.0 [INFO] extracting crate markdown 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/markdown/0.2.0 [INFO] validating manifest of markdown-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of markdown-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing markdown-0.2.0 [INFO] finished frobbing markdown-0.2.0 [INFO] frobbed toml for markdown-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/markdown/0.2.0/Cargo.toml [INFO] started frobbing markdown-0.2.0 [INFO] finished frobbing markdown-0.2.0 [INFO] frobbed toml for markdown-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/markdown/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting markdown-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/markdown/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6acfcbb814a3186dedb15e216fdb1f635869bccc2ff8f99d656be15f336ffe4b [INFO] running `"docker" "start" "-a" "6acfcbb814a3186dedb15e216fdb1f635869bccc2ff8f99d656be15f336ffe4b"` [INFO] [stderr] Checking markdown v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: value assigned to `last_indent` is never read [INFO] [stderr] --> src/parser/block/unordered_list.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut last_indent = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/span/mod.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | t.push_str(&text[i..i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parser/block/code_block.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | let code_block_tabs = Regex::new(r"^\t").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block/blockquote.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | if prev_newline && line.len() > 0 && &line[0..1] != ">" { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block/blockquote.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if line.len() > 0 && &line[0..1] == ">" { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | Hr => format!("
"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"
".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | Break => format!("
"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"
".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | Text(ref text) => format!("{}", &escape(text)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&escape(text).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/block/code_block.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | ((CodeBlock("Test".to_owned()), 1))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/block/code_block.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | ((CodeBlock("Test\nthis".to_owned()), 2))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser/block/code_block.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | ((CodeBlock("Test\nthis".to_owned()), 2))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: value assigned to `last_indent` is never read [INFO] [stderr] --> src/parser/block/unordered_list.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut last_indent = 0; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser/span/mod.rs:37:34 [INFO] [stderr] | [INFO] [stderr] 37 | t.push_str(&text[i..i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:26:37 [INFO] [stderr] | [INFO] [stderr] 26 | assert_eq!(parse_atx_header(&vec!["### Test", "testtest"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["### Test", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | assert_eq!(parse_atx_header(&vec!["# Test", "testtest"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["# Test", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:32:37 [INFO] [stderr] | [INFO] [stderr] 32 | assert_eq!(parse_atx_header(&vec!["###### Test", "testtest"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["###### Test", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(parse_atx_header(&vec!["### Test and a pretty long sentence", "testtest"]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["### Test and a pretty long sentence", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(parse_atx_header(&vec!["### Test ###", "testtest"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["### Test ###", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(parse_atx_header(&vec!["# Test #", "testtest"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["# Test #", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | assert_eq!(parse_atx_header(&vec!["###### Test ##", "testtest"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["###### Test ##", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:52:37 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(parse_atx_header(&vec!["### Test and a pretty long sentence #########", [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 53 | | "testtest"]) [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(parse_atx_header(&["### Test and a pretty long sentence #########", [INFO] [stderr] 53 | "testtest"]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | assert_eq!(parse_atx_header(&vec!["####### Test", "testtest"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["####### Test", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(parse_atx_header(&vec!["Test #", "testtest"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["Test #", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/atx_header.rs:64:37 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(parse_atx_header(&vec!["T ### est #", "testtest"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["T ### est #", "testtest"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/setext_header.rs:28:40 [INFO] [stderr] | [INFO] [stderr] 28 | assert_eq!(parse_setext_header(&vec!["Test", "=========="]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["Test", "=========="]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/setext_header.rs:31:40 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(parse_setext_header(&vec!["Test", "----------"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["Test", "----------"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/setext_header.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(parse_setext_header(&vec!["This is a test", "==="]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["This is a test", "==="]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/setext_header.rs:37:40 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!(parse_setext_header(&vec!["This is a test", "---"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["This is a test", "---"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(parse_hr(&vec!["-------"]).unwrap(), (Hr, 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["-------"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(parse_hr(&vec!["---"]).unwrap(), (Hr, 1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["---"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(parse_hr(&vec!["----------------------------"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["----------------------------"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | assert_eq!(parse_hr(&vec!["-------", "abc"]).unwrap(), (Hr, 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["-------", "abc"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | assert_eq!(parse_hr(&vec!["======="]).unwrap(), (Hr, 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["======="]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | assert_eq!(parse_hr(&vec!["==="]).unwrap(), (Hr, 1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&["==="]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:29:29 [INFO] [stderr] | [INFO] [stderr] 29 | assert_eq!(parse_hr(&vec!["============================"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["============================"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(parse_hr(&vec!["=======", "abc"]).unwrap(), (Hr, 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["=======", "abc"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(parse_hr(&vec!["a-------"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["a-------"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!(parse_hr(&vec!["--- a"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&["--- a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(parse_hr(&vec!["--a-"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["--a-"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | assert_eq!(parse_hr(&vec!["-------====--------------"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["-------====--------------"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:41:29 [INFO] [stderr] | [INFO] [stderr] 41 | assert_eq!(parse_hr(&vec!["a======"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["a======"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(parse_hr(&vec!["=== a"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&["=== a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(parse_hr(&vec!["==a="]), None); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&["==a="]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/hr.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | assert_eq!(parse_hr(&vec!["=======---================="]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["=======---================="]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parser/block/code_block.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | let code_block_tabs = Regex::new(r"^\t").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/code_block.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!(parse_code_block(&vec![" Test"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[" Test"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/code_block.rs:49:37 [INFO] [stderr] | [INFO] [stderr] 49 | assert_eq!(parse_code_block(&vec![" Test", " this"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[" Test", " this"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/code_block.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | assert_eq!(parse_code_block(&vec![" Test", " this", "stuff", " now"]).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[" Test", " this", "stuff", " now"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/code_block.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | assert_eq!(parse_code_block(&vec![" Test"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[" Test"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/code_block.rs:66:37 [INFO] [stderr] | [INFO] [stderr] 66 | assert_eq!(parse_code_block(&vec!["Test", " this", "stuff", " now"]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["Test", " this", "stuff", " now"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block/blockquote.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | if prev_newline && line.len() > 0 && &line[0..1] != ">" { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block/blockquote.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if line.len() > 0 && &line[0..1] == ">" { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/blockquote.rs:62:32 [INFO] [stderr] | [INFO] [stderr] 62 | match parse_blockquote(&vec!["> A citation", "> is good"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["> A citation", "> is good"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/blockquote.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | match parse_blockquote(&vec!["> A citation", "> is good,", "very good"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["> A citation", "> is good,", "very good"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/blockquote.rs:75:32 [INFO] [stderr] | [INFO] [stderr] 75 | match parse_blockquote(&vec!["> A citation", "> is good", "", "whatever"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["> A citation", "> is good", "", "whatever"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/blockquote.rs:83:37 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(parse_blockquote(&vec!["wat > this"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["wat > this"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/blockquote.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(parse_blockquote(&vec!["Hello", "> A citation", "> is good", "", "whatever"]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["Hello", "> A citation", "> is good", "", "whatever"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/unordered_list.rs:104:36 [INFO] [stderr] | [INFO] [stderr] 104 | match parse_unordered_list(&vec!["* A list", "* is good"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["* A list", "* is good"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/unordered_list.rs:109:36 [INFO] [stderr] | [INFO] [stderr] 109 | match parse_unordered_list(&vec!["* A list", "* is good", "laksjdnflakdsjnf"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["* A list", "* is good", "laksjdnflakdsjnf"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/unordered_list.rs:117:36 [INFO] [stderr] | [INFO] [stderr] 117 | match parse_unordered_list(&vec!["* A list", "* is good", "", "laksjdnflakdsjnf"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["* A list", "* is good", "", "laksjdnflakdsjnf"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/unordered_list.rs:122:36 [INFO] [stderr] | [INFO] [stderr] 122 | match parse_unordered_list(&vec!["* A list", "", "laksjdnflakdsjnf"]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["* A list", "", "laksjdnflakdsjnf"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/unordered_list.rs:130:41 [INFO] [stderr] | [INFO] [stderr] 130 | assert_eq!(parse_unordered_list(&vec!["test * test"]), None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["test * test"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/block/unordered_list.rs:135:41 [INFO] [stderr] | [INFO] [stderr] 135 | assert_eq!(parse_unordered_list(&vec!["test", "* whot", "* a list"]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["test", "* whot", "* a list"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | Hr => format!("
"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"
".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | Break => format!("
"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"
".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/html.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | Text(ref text) => format!("{}", &escape(text)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `&escape(text).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/fixtures/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | File::open(Path::new(&html)).unwrap().read_to_string(&mut comp); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> tests/fixtures/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | File::open(md).unwrap().read_to_string(&mut tokens); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.01s [INFO] running `"docker" "inspect" "6acfcbb814a3186dedb15e216fdb1f635869bccc2ff8f99d656be15f336ffe4b"` [INFO] running `"docker" "rm" "-f" "6acfcbb814a3186dedb15e216fdb1f635869bccc2ff8f99d656be15f336ffe4b"` [INFO] [stdout] 6acfcbb814a3186dedb15e216fdb1f635869bccc2ff8f99d656be15f336ffe4b