[INFO] crate marc 1.5.0 is already in cache
[INFO] extracting crate marc 1.5.0 into work/ex/clippy-test-run/sources/stable/reg/marc/1.5.0
[INFO] extracting crate marc 1.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/marc/1.5.0
[INFO] validating manifest of marc-1.5.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of marc-1.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing marc-1.5.0
[INFO] finished frobbing marc-1.5.0
[INFO] frobbed toml for marc-1.5.0 written to work/ex/clippy-test-run/sources/stable/reg/marc/1.5.0/Cargo.toml
[INFO] started frobbing marc-1.5.0
[INFO] finished frobbing marc-1.5.0
[INFO] frobbed toml for marc-1.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/marc/1.5.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting marc-1.5.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/marc/1.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 33bb22027e93b73c3e37b648f4c0a1ac112bc95080634f32799382edc75f51ce
[INFO] running `"docker" "start" "-a" "33bb22027e93b73c3e37b648f4c0a1ac112bc95080634f32799382edc75f51ce"`
[INFO] [stderr] warning: profile `doc` is deprecated and has no effect
[INFO] [stderr]     Checking marc v1.5.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/directory.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             entries: entries,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/field/fields.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             record: record,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `record`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/field/mod.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             tag: tag,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/field/mod.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             data_offset: data_offset,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:90:13
[INFO] [stderr]    |
[INFO] [stderr] 90 |             directory: directory,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             data_offset: data_offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:136:13
[INFO] [stderr]     |
[INFO] [stderr] 136 |             data_offset: data_offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/directory.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             entries: entries,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:273:13
[INFO] [stderr]     |
[INFO] [stderr] 273 |             leader: leader,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `leader`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/field/fields.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             record: record,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `record`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/field/mod.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             tag: tag,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/field/mod.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    --> src/lib.rs:274:13
[INFO] [stderr]     |
[INFO] [stderr] 274 |             fields: fields,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             data_offset: data_offset,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:388:13
[INFO] [stderr]     |
[INFO] [stderr] 388 |             data_offset: data_offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]    |
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:90:13
[INFO] [stderr]    |
[INFO] [stderr] 90 |             directory: directory,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:389:13
[INFO] [stderr]     |
[INFO] [stderr] 389 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             data_offset: data_offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:136:13
[INFO] [stderr]     |
[INFO] [stderr] 136 |             data_offset: data_offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:273:13
[INFO] [stderr]     |
[INFO] [stderr] 273 |             leader: leader,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `leader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:274:13
[INFO] [stderr]     |
[INFO] [stderr] 274 |             fields: fields,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:388:13
[INFO] [stderr]     |
[INFO] [stderr] 388 |             data_offset: data_offset,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:389:13
[INFO] [stderr]     |
[INFO] [stderr] 389 |             directory: directory,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/field/subfield/mod.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return output;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:382:24
[INFO] [stderr]     |
[INFO] [stderr] 382 |             Ok(Record {data: _, data_offset, directory}) => (data_offset, directory),
[INFO] [stderr]     |                        ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Record { data_offset, directory, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/field/subfield/mod.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return output;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/lib.rs:382:24
[INFO] [stderr]     |
[INFO] [stderr] 382 |             Ok(Record {data: _, data_offset, directory}) => (data_offset, directory),
[INFO] [stderr]     |                        ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Record { data_offset, directory, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:710:18
[INFO] [stderr]     |
[INFO] [stderr] 710 |     const RECS: &'static str = "00963nam a2200229 i 4500001001000000003000800010003000800018005001700026008004100043035002300084040002600107041000800133072001900141100005800160245028000218260004000498300001600538650004200554856010400596979001200700979002100712\
[INFO] [stderr]     |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:110:30
[INFO] [stderr]     |
[INFO] [stderr] 110 |     pub fn read<T: io::Read>(mut input: &mut T) -> Result<Option<Record<'static>>> {
[INFO] [stderr]     |                              ----^^^^^
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/field/subfield/subfields.rs:32:23
[INFO] [stderr]    |
[INFO] [stderr] 32 |                 match self.field.data.get(offset).map(|x| *x) {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.field.data.get(offset).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/field/subfield/subfields.rs:44:23
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 match self.field.data.get(offset).map(|x| *x) {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.field.data.get(offset).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/field/subfield/subfields.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 match self.field.data.get(start + offset).map(|x| *x) {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.field.data.get(start + offset).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/field/mod.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new<'x>(tag: Tag, data: &'x [u8]) -> Field<'x> {
[INFO] [stderr] 27 | |         Field {
[INFO] [stderr] 28 | |             tag: tag,
[INFO] [stderr] 29 | |             data: data,
[INFO] [stderr] 30 | |         }
[INFO] [stderr] 31 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `i`
[INFO] [stderr]   --> src/misc.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |     for x in 0..4usize {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 16 |     for (x, <item>) in i.iter().enumerate().take(4usize) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `i`
[INFO] [stderr]   --> src/misc.rs:27:14
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for x in 0..5usize {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for (x, <item>) in i.iter().enumerate().take(5usize) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/tag.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     pub fn as_ref(&self) -> &[u8] {
[INFO] [stderr] 10 | |         &self.0[..]
[INFO] [stderr] 11 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name
[INFO] [stderr]  --> src/indicator.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | /     pub fn as_ref(&self) -> &[u8] {
[INFO] [stderr] 7 | |         &self.0[..]
[INFO] [stderr] 8 | |     }
[INFO] [stderr]   | |_____^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:155:5
[INFO] [stderr]     |
[INFO] [stderr] 155 | /     pub fn fields<'r>(&'r self) -> Fields<'r> {
[INFO] [stderr] 156 | |         Fields::new(self)
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:160:5
[INFO] [stderr]     |
[INFO] [stderr] 160 | /     pub fn as_ref(&self) -> &[u8] {
[INFO] [stderr] 161 | |         self.data.borrow()
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RecordBuilder`
[INFO] [stderr]    --> src/lib.rs:260:5
[INFO] [stderr]     |
[INFO] [stderr] 260 | /     pub fn new() -> RecordBuilder {
[INFO] [stderr] 261 | |         RecordBuilder {
[INFO] [stderr] 262 | |             leader: *b"00000nam  2200000 i 4500",
[INFO] [stderr] 263 | |             fields: vec![],
[INFO] [stderr] 264 | |         }
[INFO] [stderr] 265 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 253 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:271:42
[INFO] [stderr]     |
[INFO] [stderr] 271 |         let fields = record.fields().map(|f| FieldRepr::from(f)).collect();
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FieldRepr::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/lib.rs:356:9
[INFO] [stderr]     |
[INFO] [stderr] 356 |         &mut data[0..5].copy_from_slice(format!("{:05}", size).as_bytes());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[0..5].copy_from_slice(format!("{:05}", size).as_bytes());`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/lib.rs:371:9
[INFO] [stderr]     |
[INFO] [stderr] 371 |         &mut data[12..17].copy_from_slice(format!("{:05}", len).as_bytes());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[12..17].copy_from_slice(format!("{:05}", len).as_bytes());`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:110:30
[INFO] [stderr]     |
[INFO] [stderr] 110 |     pub fn read<T: io::Read>(mut input: &mut T) -> Result<Option<Record<'static>>> {
[INFO] [stderr]     |                              ----^^^^^
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/field/subfield/subfields.rs:32:23
[INFO] [stderr]    |
[INFO] [stderr] 32 |                 match self.field.data.get(offset).map(|x| *x) {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.field.data.get(offset).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/field/subfield/subfields.rs:44:23
[INFO] [stderr]    |
[INFO] [stderr] 44 |                 match self.field.data.get(offset).map(|x| *x) {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.field.data.get(offset).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/field/subfield/subfields.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 match self.field.data.get(start + offset).map(|x| *x) {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.field.data.get(start + offset).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/field/mod.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new<'x>(tag: Tag, data: &'x [u8]) -> Field<'x> {
[INFO] [stderr] 27 | |         Field {
[INFO] [stderr] 28 | |             tag: tag,
[INFO] [stderr] 29 | |             data: data,
[INFO] [stderr] 30 | |         }
[INFO] [stderr] 31 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `i`
[INFO] [stderr]   --> src/misc.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |     for x in 0..4usize {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 16 |     for (x, <item>) in i.iter().enumerate().take(4usize) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `i`
[INFO] [stderr]   --> src/misc.rs:27:14
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for x in 0..5usize {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 27 |     for (x, <item>) in i.iter().enumerate().take(5usize) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/tag.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     pub fn as_ref(&self) -> &[u8] {
[INFO] [stderr] 10 | |         &self.0[..]
[INFO] [stderr] 11 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name
[INFO] [stderr]  --> src/indicator.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 | /     pub fn as_ref(&self) -> &[u8] {
[INFO] [stderr] 7 | |         &self.0[..]
[INFO] [stderr] 8 | |     }
[INFO] [stderr]   | |_____^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:155:5
[INFO] [stderr]     |
[INFO] [stderr] 155 | /     pub fn fields<'r>(&'r self) -> Fields<'r> {
[INFO] [stderr] 156 | |         Fields::new(self)
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:160:5
[INFO] [stderr]     |
[INFO] [stderr] 160 | /     pub fn as_ref(&self) -> &[u8] {
[INFO] [stderr] 161 | |         self.data.borrow()
[INFO] [stderr] 162 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RecordBuilder`
[INFO] [stderr]    --> src/lib.rs:260:5
[INFO] [stderr]     |
[INFO] [stderr] 260 | /     pub fn new() -> RecordBuilder {
[INFO] [stderr] 261 | |         RecordBuilder {
[INFO] [stderr] 262 | |             leader: *b"00000nam  2200000 i 4500",
[INFO] [stderr] 263 | |             fields: vec![],
[INFO] [stderr] 264 | |         }
[INFO] [stderr] 265 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 253 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:271:42
[INFO] [stderr]     |
[INFO] [stderr] 271 |         let fields = record.fields().map(|f| FieldRepr::from(f)).collect();
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FieldRepr::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/lib.rs:356:9
[INFO] [stderr]     |
[INFO] [stderr] 356 |         &mut data[0..5].copy_from_slice(format!("{:05}", size).as_bytes());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[0..5].copy_from_slice(format!("{:05}", size).as_bytes());`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/lib.rs:371:9
[INFO] [stderr]     |
[INFO] [stderr] 371 |         &mut data[12..17].copy_from_slice(format!("{:05}", len).as_bytes());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[12..17].copy_from_slice(format!("{:05}", len).as_bytes());`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:953:13
[INFO] [stderr]     |
[INFO] [stderr] 953 | /             match vec.write_record(record.clone()) {
[INFO] [stderr] 954 | |                 Err(why) => panic!("couldn't write file: {}", why.description()),
[INFO] [stderr] 955 | |                 Ok(_) => (),
[INFO] [stderr] 956 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Err(why) = vec.write_record(record.clone()) { panic!("couldn't write file: {}", why.description()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.19s
[INFO] running `"docker" "inspect" "33bb22027e93b73c3e37b648f4c0a1ac112bc95080634f32799382edc75f51ce"`
[INFO] running `"docker" "rm" "-f" "33bb22027e93b73c3e37b648f4c0a1ac112bc95080634f32799382edc75f51ce"`
[INFO] [stdout] 33bb22027e93b73c3e37b648f4c0a1ac112bc95080634f32799382edc75f51ce