[INFO] crate mar 0.1.1 is already in cache [INFO] extracting crate mar 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/mar/0.1.1 [INFO] extracting crate mar 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mar/0.1.1 [INFO] validating manifest of mar-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mar-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mar-0.1.1 [INFO] finished frobbing mar-0.1.1 [INFO] frobbed toml for mar-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/mar/0.1.1/Cargo.toml [INFO] started frobbing mar-0.1.1 [INFO] finished frobbing mar-0.1.1 [INFO] frobbed toml for mar-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mar/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mar-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mar/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d7f196b08b9a527e2804b5276c757bc250142f743976f97166b8e0197adda14 [INFO] running `"docker" "start" "-a" "5d7f196b08b9a527e2804b5276c757bc250142f743976f97166b8e0197adda14"` [INFO] [stderr] Checking mar v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `round_up` [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | fn round_up(n: usize, incr: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SIGNATURE_BLOCK_OFFSET` [INFO] [stderr] --> src/lib.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | const SIGNATURE_BLOCK_OFFSET: usize = 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_SIZE_OF_MAR_FILE` [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | const MAX_SIZE_OF_MAR_FILE: u64 = 500 * 1024 * 1024; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_SIGNATURE_LENGTH` [INFO] [stderr] --> src/lib.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | const MAX_SIGNATURE_LENGTH: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PRODUCT_INFO_BLOCK_ID` [INFO] [stderr] --> src/lib.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | const PRODUCT_INFO_BLOCK_ID: u32 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mar_item_size` [INFO] [stderr] --> src/lib.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | fn mar_item_size(name_len: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ProductInformationBlock` [INFO] [stderr] --> src/lib.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | struct ProductInformationBlock { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIB_MAX_MAR_CHANNEL_ID_SIZE` [INFO] [stderr] --> src/lib.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | const PIB_MAX_MAR_CHANNEL_ID_SIZE: usize = 63; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIB_MAX_PRODUCT_VERSION_SIZE` [INFO] [stderr] --> src/lib.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | const PIB_MAX_PRODUCT_VERSION_SIZE: usize = 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | archive.seek(SeekFrom::Start(offset_to_index as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset_to_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/read.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | .or(Err(io::Error::new(ErrorKind::InvalidData, "Filename is not UTF-8")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(io::Error::new(ErrorKind::InvalidData, "Filename is not UTF-8")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extract.rs:22:38 [INFO] [stderr] | [INFO] [stderr] 22 | archive.seek(SeekFrom::Start(item.offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extract.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | let mut data = archive.by_ref().take(item.length as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/extract.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | .ok_or(io::Error::new(ErrorKind::InvalidData, ""))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(ErrorKind::InvalidData, ""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extract.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | if bytes_written != item.length as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: structure field `MARChannelID` should have a snake case name such as `marchannel_id` [INFO] [stderr] --> src/lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | MARChannelID: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `productVersion` should have a snake case name such as `product_version` [INFO] [stderr] --> src/lib.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | productVersion: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `round_up` [INFO] [stderr] --> src/lib.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | fn round_up(n: usize, incr: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SIGNATURE_BLOCK_OFFSET` [INFO] [stderr] --> src/lib.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | const SIGNATURE_BLOCK_OFFSET: usize = 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_SIZE_OF_MAR_FILE` [INFO] [stderr] --> src/lib.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | const MAX_SIZE_OF_MAR_FILE: u64 = 500 * 1024 * 1024; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_SIGNATURE_LENGTH` [INFO] [stderr] --> src/lib.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | const MAX_SIGNATURE_LENGTH: usize = 2048; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PRODUCT_INFO_BLOCK_ID` [INFO] [stderr] --> src/lib.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | const PRODUCT_INFO_BLOCK_ID: u32 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mar_item_size` [INFO] [stderr] --> src/lib.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | fn mar_item_size(name_len: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ProductInformationBlock` [INFO] [stderr] --> src/lib.rs:53:1 [INFO] [stderr] | [INFO] [stderr] 53 | struct ProductInformationBlock { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIB_MAX_MAR_CHANNEL_ID_SIZE` [INFO] [stderr] --> src/lib.rs:59:1 [INFO] [stderr] | [INFO] [stderr] 59 | const PIB_MAX_MAR_CHANNEL_ID_SIZE: usize = 63; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIB_MAX_PRODUCT_VERSION_SIZE` [INFO] [stderr] --> src/lib.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | const PIB_MAX_PRODUCT_VERSION_SIZE: usize = 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | archive.seek(SeekFrom::Start(offset_to_index as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(offset_to_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/read.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | .or(Err(io::Error::new(ErrorKind::InvalidData, "Filename is not UTF-8")))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| Err(io::Error::new(ErrorKind::InvalidData, "Filename is not UTF-8")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extract.rs:22:38 [INFO] [stderr] | [INFO] [stderr] 22 | archive.seek(SeekFrom::Start(item.offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extract.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | let mut data = archive.by_ref().take(item.length as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/extract.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | .ok_or(io::Error::new(ErrorKind::InvalidData, ""))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(ErrorKind::InvalidData, ""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/extract.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | if bytes_written != item.length as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(item.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: structure field `MARChannelID` should have a snake case name such as `marchannel_id` [INFO] [stderr] --> src/lib.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | MARChannelID: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `productVersion` should have a snake case name such as `product_version` [INFO] [stderr] --> src/lib.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | productVersion: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `"docker" "inspect" "5d7f196b08b9a527e2804b5276c757bc250142f743976f97166b8e0197adda14"` [INFO] running `"docker" "rm" "-f" "5d7f196b08b9a527e2804b5276c757bc250142f743976f97166b8e0197adda14"` [INFO] [stdout] 5d7f196b08b9a527e2804b5276c757bc250142f743976f97166b8e0197adda14