[INFO] crate map-to-javascript-html 1.2.1 is already in cache
[INFO] extracting crate map-to-javascript-html 1.2.1 into work/ex/clippy-test-run/sources/stable/reg/map-to-javascript-html/1.2.1
[INFO] extracting crate map-to-javascript-html 1.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/map-to-javascript-html/1.2.1
[INFO] validating manifest of map-to-javascript-html-1.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of map-to-javascript-html-1.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing map-to-javascript-html-1.2.1
[INFO] finished frobbing map-to-javascript-html-1.2.1
[INFO] frobbed toml for map-to-javascript-html-1.2.1 written to work/ex/clippy-test-run/sources/stable/reg/map-to-javascript-html/1.2.1/Cargo.toml
[INFO] started frobbing map-to-javascript-html-1.2.1
[INFO] finished frobbing map-to-javascript-html-1.2.1
[INFO] frobbed toml for map-to-javascript-html-1.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/map-to-javascript-html/1.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting map-to-javascript-html-1.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/map-to-javascript-html/1.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e24486a545e5eabfbaff3ecef6c31e87fa854d687b907484393dff3f167503fa
[INFO] running `"docker" "start" "-a" "e24486a545e5eabfbaff3ecef6c31e87fa854d687b907484393dff3f167503fa"`
[INFO] [stderr]     Checking map-to-javascript-html v1.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/lib.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 | /     loop {
[INFO] [stderr] 73 | |         //println!("{}", start);
[INFO] [stderr] 74 | |         match text[start..].find(search) {
[INFO] [stderr] 75 | |             Some(index) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |         }
[INFO] [stderr] 82 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(index) = text[start..].find(search) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/lib.rs:95:26
[INFO] [stderr]    |
[INFO] [stderr] 95 |         s.push_str(&text[offset..(index + 1)]);
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: use: `offset..=index`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:153:98
[INFO] [stderr]     |
[INFO] [stderr] 153 | pub fn hash_map_to_javascript_html<K: Display + Eq + Hash, V: Display, S: AsRef<str>>(hash_map: &HashMap<K, V>, variable_name: S, keys: &[K]) -> Result<String, String> {
[INFO] [stderr]     |                                                                                                  ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 153 | pub fn hash_map_to_javascript_html<K: Display + Eq + Hash, V: Display, S: AsRef<str>, S: ::std::hash::BuildHasher>(hash_map: &HashMap<K, V, S>, variable_name: S, keys: &[K]) -> Result<String, String> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^            ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:171:107
[INFO] [stderr]     |
[INFO] [stderr] 171 | pub fn hash_map_to_javascript_html_beautify<K: Display + Eq + Hash, V: Display, S: AsRef<str>>(hash_map: &HashMap<K, V>, variable_name: S, keys: &[K], spaces_a_tab: u8, tab_count: u8) -> Result<String, String> {
[INFO] [stderr]     |                                                                                                           ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 171 | pub fn hash_map_to_javascript_html_beautify<K: Display + Eq + Hash, V: Display, S: AsRef<str>, S: ::std::hash::BuildHasher>(hash_map: &HashMap<K, V, S>, variable_name: S, keys: &[K], spaces_a_tab: u8, tab_count: u8) -> Result<String, String> {
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^            ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:193:9
[INFO] [stderr]     |
[INFO] [stderr] 193 | /         let tab;
[INFO] [stderr] 194 | |
[INFO] [stderr] 195 | |         if spaces_a_tab > 0 {
[INFO] [stderr] 196 | |             n = spaces_a_tab as usize * tab_count as usize;
[INFO] [stderr] ...   |
[INFO] [stderr] 202 | |             tab = '\t';
[INFO] [stderr] 203 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let tab = if spaces_a_tab > 0 { ..; ' ' } else { ..; '\t' };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/lib.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 | /     loop {
[INFO] [stderr] 73 | |         //println!("{}", start);
[INFO] [stderr] 74 | |         match text[start..].find(search) {
[INFO] [stderr] 75 | |             Some(index) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |         }
[INFO] [stderr] 82 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(index) = text[start..].find(search) { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/lib.rs:95:26
[INFO] [stderr]    |
[INFO] [stderr] 95 |         s.push_str(&text[offset..(index + 1)]);
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: use: `offset..=index`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:153:98
[INFO] [stderr]     |
[INFO] [stderr] 153 | pub fn hash_map_to_javascript_html<K: Display + Eq + Hash, V: Display, S: AsRef<str>>(hash_map: &HashMap<K, V>, variable_name: S, keys: &[K]) -> Result<String, String> {
[INFO] [stderr]     |                                                                                                  ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 153 | pub fn hash_map_to_javascript_html<K: Display + Eq + Hash, V: Display, S: AsRef<str>, S: ::std::hash::BuildHasher>(hash_map: &HashMap<K, V, S>, variable_name: S, keys: &[K]) -> Result<String, String> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^            ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/lib.rs:171:107
[INFO] [stderr]     |
[INFO] [stderr] 171 | pub fn hash_map_to_javascript_html_beautify<K: Display + Eq + Hash, V: Display, S: AsRef<str>>(hash_map: &HashMap<K, V>, variable_name: S, keys: &[K], spaces_a_tab: u8, tab_count: u8) -> Result<String, String> {
[INFO] [stderr]     |                                                                                                           ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 171 | pub fn hash_map_to_javascript_html_beautify<K: Display + Eq + Hash, V: Display, S: AsRef<str>, S: ::std::hash::BuildHasher>(hash_map: &HashMap<K, V, S>, variable_name: S, keys: &[K], spaces_a_tab: u8, tab_count: u8) -> Result<String, String> {
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^            ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:193:9
[INFO] [stderr]     |
[INFO] [stderr] 193 | /         let tab;
[INFO] [stderr] 194 | |
[INFO] [stderr] 195 | |         if spaces_a_tab > 0 {
[INFO] [stderr] 196 | |             n = spaces_a_tab as usize * tab_count as usize;
[INFO] [stderr] ...   |
[INFO] [stderr] 202 | |             tab = '\t';
[INFO] [stderr] 203 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let tab = if spaces_a_tab > 0 { ..; ' ' } else { ..; '\t' };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> tests/tests.rs:16:82
[INFO] [stderr]    |
[INFO] [stderr] 16 |     let html = map_to_javascript_html::hash_map_to_javascript_html(&map, "text", &vec!["test-1", "test-2", "test-'3'", r"test-\'4\'", "script", r"'中'文"]).unwrap();
[INFO] [stderr]    |                                                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["test-1", "test-2", "test-'3'", r"test-\'4\'", "script", r"'中'文"]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> tests/tests.rs:32:91
[INFO] [stderr]    |
[INFO] [stderr] 32 |     let html = map_to_javascript_html::hash_map_to_javascript_html_beautify(&map, "text", &vec!["test-1", "test-2", "test-'3'", r"test-\'4\'", "script", r"'中'文"], 0, 0).unwrap();
[INFO] [stderr]    |                                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["test-1", "test-2", "test-'3'", r"test-\'4\'", "script", r"'中'文"]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> tests/tests.rs:53:91
[INFO] [stderr]    |
[INFO] [stderr] 53 |     let html = map_to_javascript_html::hash_map_to_javascript_html_beautify(&map, "text", &vec!["test-1", "test-2", "test-'3'", r"test-\'4\'", "script", r"'中'文"], 12, 1).unwrap();
[INFO] [stderr]    |                                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["test-1", "test-2", "test-'3'", r"test-\'4\'", "script", r"'中'文"]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.80s
[INFO] running `"docker" "inspect" "e24486a545e5eabfbaff3ecef6c31e87fa854d687b907484393dff3f167503fa"`
[INFO] running `"docker" "rm" "-f" "e24486a545e5eabfbaff3ecef6c31e87fa854d687b907484393dff3f167503fa"`
[INFO] [stdout] e24486a545e5eabfbaff3ecef6c31e87fa854d687b907484393dff3f167503fa