[INFO] crate mandrill_sender 0.1.0 is already in cache [INFO] extracting crate mandrill_sender 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mandrill_sender/0.1.0 [INFO] extracting crate mandrill_sender 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mandrill_sender/0.1.0 [INFO] validating manifest of mandrill_sender-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mandrill_sender-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mandrill_sender-0.1.0 [INFO] finished frobbing mandrill_sender-0.1.0 [INFO] frobbed toml for mandrill_sender-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mandrill_sender/0.1.0/Cargo.toml [INFO] started frobbing mandrill_sender-0.1.0 [INFO] finished frobbing mandrill_sender-0.1.0 [INFO] frobbed toml for mandrill_sender-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mandrill_sender/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mandrill_sender-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mandrill_sender/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5498beb922dde8c9f4276e3892a1676a4e09b1823c44ea67195d6806920ba679 [INFO] running `"docker" "start" "-a" "5498beb922dde8c9f4276e3892a1676a4e09b1823c44ea67195d6806920ba679"` [INFO] [stderr] Checking serde_urlencoded v0.3.0 [INFO] [stderr] Checking reqwest v0.1.0 [INFO] [stderr] Checking mandrill_sender v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/email.rs:83:69 [INFO] [stderr] | [INFO] [stderr] 83 | Sender { api_url: "https://mandrillapp.com/api/1.0".to_owned(), key: key } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/email.rs:83:69 [INFO] [stderr] | [INFO] [stderr] 83 | Sender { api_url: "https://mandrillapp.com/api/1.0".to_owned(), key: key } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | m.from_email = Some(from_email.clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 43 | m.from_email = Some(&(*from_email).clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 43 | m.from_email = Some(&str::clone(from_email).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | m.html = Some(message.clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 44 | m.html = Some(&(*message).clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 44 | m.html = Some(&str::clone(message).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | m.subject = Some(subject.clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 45 | m.subject = Some(&(*subject).clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 45 | m.subject = Some(&str::clone(subject).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | m.to = Some(vec![Recipient{email: to.clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 46 | m.to = Some(vec![Recipient{email: &(*to).clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 46 | m.to = Some(vec![Recipient{email: &str::clone(to).to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/email.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | let body = json::encode(&msg).unwrap_or("".to_owned()).replace("\"_type\"", "\"type\""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/email.rs:149:11 [INFO] [stderr] | [INFO] [stderr] 149 | / match res.read_to_string(response_body) { [INFO] [stderr] 150 | | Ok(_) => (), Err(_) => () [INFO] [stderr] 151 | | } [INFO] [stderr] | |___________^ help: try this: `if let Ok(_) = res.read_to_string(response_body) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:165:43 [INFO] [stderr] | [INFO] [stderr] 165 | email.to = Some(vec![Recipient{email: to.clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 165 | email.to = Some(vec![Recipient{email: &(*to).clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 165 | email.to = Some(vec![Recipient{email: &str::clone(to).to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:178:22 [INFO] [stderr] | [INFO] [stderr] 178 | template_name: template_slug.clone().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 178 | template_name: &(*template_slug).clone().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 178 | template_name: &str::clone(template_slug).to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/email.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | let body = json::encode(&msg).unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/email.rs:242:11 [INFO] [stderr] | [INFO] [stderr] 242 | / match res.read_to_string(response_body) { [INFO] [stderr] 243 | | Ok(_) => (), Err(_) => () [INFO] [stderr] 244 | | } [INFO] [stderr] | |___________^ help: try this: `if let Ok(_) = res.read_to_string(response_body) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mandrill_sender`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | m.from_email = Some(from_email.clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 43 | m.from_email = Some(&(*from_email).clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 43 | m.from_email = Some(&str::clone(from_email).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | m.html = Some(message.clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 44 | m.html = Some(&(*message).clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 44 | m.html = Some(&str::clone(message).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | m.subject = Some(subject.clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 45 | m.subject = Some(&(*subject).clone().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 45 | m.subject = Some(&str::clone(subject).to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | m.to = Some(vec![Recipient{email: to.clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 46 | m.to = Some(vec![Recipient{email: &(*to).clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 46 | m.to = Some(vec![Recipient{email: &str::clone(to).to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/email.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | let body = json::encode(&msg).unwrap_or("".to_owned()).replace("\"_type\"", "\"type\""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/email.rs:149:11 [INFO] [stderr] | [INFO] [stderr] 149 | / match res.read_to_string(response_body) { [INFO] [stderr] 150 | | Ok(_) => (), Err(_) => () [INFO] [stderr] 151 | | } [INFO] [stderr] | |___________^ help: try this: `if let Ok(_) = res.read_to_string(response_body) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:165:43 [INFO] [stderr] | [INFO] [stderr] 165 | email.to = Some(vec![Recipient{email: to.clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 165 | email.to = Some(vec![Recipient{email: &(*to).clone().to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 165 | email.to = Some(vec![Recipient{email: &str::clone(to).to_owned(), name: None}]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/email.rs:178:22 [INFO] [stderr] | [INFO] [stderr] 178 | template_name: template_slug.clone().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 178 | template_name: &(*template_slug).clone().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 178 | template_name: &str::clone(template_slug).to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/email.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | let body = json::encode(&msg).unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/email.rs:242:11 [INFO] [stderr] | [INFO] [stderr] 242 | / match res.read_to_string(response_body) { [INFO] [stderr] 243 | | Ok(_) => (), Err(_) => () [INFO] [stderr] 244 | | } [INFO] [stderr] | |___________^ help: try this: `if let Ok(_) = res.read_to_string(response_body) { () }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mandrill_sender`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5498beb922dde8c9f4276e3892a1676a4e09b1823c44ea67195d6806920ba679"` [INFO] running `"docker" "rm" "-f" "5498beb922dde8c9f4276e3892a1676a4e09b1823c44ea67195d6806920ba679"` [INFO] [stdout] 5498beb922dde8c9f4276e3892a1676a4e09b1823c44ea67195d6806920ba679