[INFO] crate makeppkg 1.1.1 is already in cache
[INFO] extracting crate makeppkg 1.1.1 into work/ex/clippy-test-run/sources/stable/reg/makeppkg/1.1.1
[INFO] extracting crate makeppkg 1.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/makeppkg/1.1.1
[INFO] validating manifest of makeppkg-1.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of makeppkg-1.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing makeppkg-1.1.1
[INFO] finished frobbing makeppkg-1.1.1
[INFO] frobbed toml for makeppkg-1.1.1 written to work/ex/clippy-test-run/sources/stable/reg/makeppkg/1.1.1/Cargo.toml
[INFO] started frobbing makeppkg-1.1.1
[INFO] finished frobbing makeppkg-1.1.1
[INFO] frobbed toml for makeppkg-1.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/makeppkg/1.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting makeppkg-1.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/makeppkg/1.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aa3401d5a15b74d592ec72eea43c8d2a6b596194e4eca3ce84a3079a2da5fb95
[INFO] running `"docker" "start" "-a" "aa3401d5a15b74d592ec72eea43c8d2a6b596194e4eca3ce84a3079a2da5fb95"`
[INFO] [stderr]    Compiling winapi v0.3.6
[INFO] [stderr]     Checking os_pipe v0.7.0
[INFO] [stderr]     Checking md-5 v0.8.0
[INFO] [stderr]     Checking sha2 v0.8.0
[INFO] [stderr]     Checking sha-1 v0.8.1
[INFO] [stderr]     Checking shared_child v0.3.3
[INFO] [stderr]     Checking duct v0.11.1
[INFO] [stderr]     Checking makeppkg v1.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arg_parse.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return (options, Some((location, pkgbuild_path)));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(options, Some((location, pkgbuild_path)))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/arg_parse.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         if &value == &"-p" {
[INFO] [stderr] 51 | |             if iter.peek().is_some() {
[INFO] [stderr] 52 | |                 pkgbuild_path = PathBuf::from(iter.peek().unwrap().1);
[INFO] [stderr] 53 | |             }
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if &value == &"-p" && iter.peek().is_some() {
[INFO] [stderr] 51 |     pkgbuild_path = PathBuf::from(iter.peek().unwrap().1);
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/patch.rs:91:5
[INFO] [stderr]    |
[INFO] [stderr] 91 | /     return patch_path
[INFO] [stderr] 92 | |         .file_stem()
[INFO] [stderr] 93 | |         .unwrap()
[INFO] [stderr] 94 | |         .to_string_lossy()
[INFO] [stderr] 95 | |         .into_owned();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 91 |     patch_path
[INFO] [stderr] 92 |         .file_stem()
[INFO] [stderr] 93 |         .unwrap()
[INFO] [stderr] 94 |         .to_string_lossy()
[INFO] [stderr] 95 |         .into_owned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/patch.rs:232:16
[INFO] [stderr]     |
[INFO] [stderr] 232 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 233 | |             if line.ends_with(")") {
[INFO] [stderr] 234 | |                 end = number;
[INFO] [stderr] 235 | |                 break;
[INFO] [stderr] 236 | |             }
[INFO] [stderr] 237 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 232 |         } else if line.ends_with(")") {
[INFO] [stderr] 233 |     end = number;
[INFO] [stderr] 234 |     break;
[INFO] [stderr] 235 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/patch.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 | /         if prepare_start == 0 {
[INFO] [stderr] 259 | |             if line.starts_with("prepare() {") {
[INFO] [stderr] 260 | |                 prepare_start = number + 1;
[INFO] [stderr] 261 | |                 break;
[INFO] [stderr] 262 | |             }
[INFO] [stderr] 263 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 258 |         if prepare_start == 0 && line.starts_with("prepare() {") {
[INFO] [stderr] 259 |     prepare_start = number + 1;
[INFO] [stderr] 260 |     break;
[INFO] [stderr] 261 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/patch.rs:264:9
[INFO] [stderr]     |
[INFO] [stderr] 264 | /         if build_start == 0 {
[INFO] [stderr] 265 | |             if line.starts_with("build() {") {
[INFO] [stderr] 266 | |                 build_start = number + 1;
[INFO] [stderr] 267 | |             }
[INFO] [stderr] 268 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 264 |         if build_start == 0 && line.starts_with("build() {") {
[INFO] [stderr] 265 |     build_start = number + 1;
[INFO] [stderr] 266 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/arg_parse.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return (options, Some((location, pkgbuild_path)));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(options, Some((location, pkgbuild_path)))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/arg_parse.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         if &value == &"-p" {
[INFO] [stderr] 51 | |             if iter.peek().is_some() {
[INFO] [stderr] 52 | |                 pkgbuild_path = PathBuf::from(iter.peek().unwrap().1);
[INFO] [stderr] 53 | |             }
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if &value == &"-p" && iter.peek().is_some() {
[INFO] [stderr] 51 |     pkgbuild_path = PathBuf::from(iter.peek().unwrap().1);
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/patch.rs:91:5
[INFO] [stderr]    |
[INFO] [stderr] 91 | /     return patch_path
[INFO] [stderr] 92 | |         .file_stem()
[INFO] [stderr] 93 | |         .unwrap()
[INFO] [stderr] 94 | |         .to_string_lossy()
[INFO] [stderr] 95 | |         .into_owned();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 91 |     patch_path
[INFO] [stderr] 92 |         .file_stem()
[INFO] [stderr] 93 |         .unwrap()
[INFO] [stderr] 94 |         .to_string_lossy()
[INFO] [stderr] 95 |         .into_owned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/patch.rs:232:16
[INFO] [stderr]     |
[INFO] [stderr] 232 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 233 | |             if line.ends_with(")") {
[INFO] [stderr] 234 | |                 end = number;
[INFO] [stderr] 235 | |                 break;
[INFO] [stderr] 236 | |             }
[INFO] [stderr] 237 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 232 |         } else if line.ends_with(")") {
[INFO] [stderr] 233 |     end = number;
[INFO] [stderr] 234 |     break;
[INFO] [stderr] 235 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/patch.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 | /         if prepare_start == 0 {
[INFO] [stderr] 259 | |             if line.starts_with("prepare() {") {
[INFO] [stderr] 260 | |                 prepare_start = number + 1;
[INFO] [stderr] 261 | |                 break;
[INFO] [stderr] 262 | |             }
[INFO] [stderr] 263 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 258 |         if prepare_start == 0 && line.starts_with("prepare() {") {
[INFO] [stderr] 259 |     prepare_start = number + 1;
[INFO] [stderr] 260 |     break;
[INFO] [stderr] 261 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/patch.rs:264:9
[INFO] [stderr]     |
[INFO] [stderr] 264 | /         if build_start == 0 {
[INFO] [stderr] 265 | |             if line.starts_with("build() {") {
[INFO] [stderr] 266 | |                 build_start = number + 1;
[INFO] [stderr] 267 | |             }
[INFO] [stderr] 268 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 264 |         if build_start == 0 && line.starts_with("build() {") {
[INFO] [stderr] 265 |     build_start = number + 1;
[INFO] [stderr] 266 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/arg_parse.rs:37:56
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if blacklist.contains(&value.trim_left_matches("-")) {
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/arg_parse.rs:40:12
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if &value == &"-l" {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if value == "-l" {
[INFO] [stderr]    |            ^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/arg_parse.rs:37:56
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if blacklist.contains(&value.trim_left_matches("-")) {
[INFO] [stderr]    |                                                        ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/arg_parse.rs:40:12
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if &value == &"-l" {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/arg_parse.rs:50:12
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if &value == &"-p" {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr]    |
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if value == "-p" {
[INFO] [stderr]    |            ^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if value == "-l" {
[INFO] [stderr]    |            ^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/package_name.rs:1:30
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn package_name(srcinfo: &String) -> Result<String, String> {
[INFO] [stderr]   |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/arg_parse.rs:50:12
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if &value == &"-p" {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 50 |         if value == "-p" {
[INFO] [stderr]    |            ^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/package_name.rs:1:30
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn package_name(srcinfo: &String) -> Result<String, String> {
[INFO] [stderr]   |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/patch.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     srcinfo: &String,
[INFO] [stderr]    |              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/patch.rs:37:8
[INFO] [stderr]    |
[INFO] [stderr] 37 |     if patches.len() != 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patches.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/patch.rs:40:12
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if patches.len() != 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patches.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/patch.rs:53:45
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn find_patches(location: PathBuf, pkgname: &String) -> (Result<Vec<PatchFile>, String>) {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/patch.rs:28:14
[INFO] [stderr]    |
[INFO] [stderr] 28 |     srcinfo: &String,
[INFO] [stderr]    |              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/patch.rs:37:8
[INFO] [stderr]    |
[INFO] [stderr] 37 |     if patches.len() != 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patches.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/patch.rs:40:12
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if patches.len() != 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patches.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/patch.rs:53:45
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn find_patches(location: PathBuf, pkgname: &String) -> (Result<Vec<PatchFile>, String>) {
[INFO] [stderr]    |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/patch.rs:111:28
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn find_algorithm(srcinfo: &String) -> Result<Algorithm, String> {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/patch.rs:111:28
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn find_algorithm(srcinfo: &String) -> Result<Algorithm, String> {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/patch.rs:159:14
[INFO] [stderr]     |
[INFO] [stderr] 159 |     patches: &Vec<PatchFile>,
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^ help: change this to: `&[PatchFile]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/patch.rs:161:14
[INFO] [stderr]     |
[INFO] [stderr] 161 |     srcinfo: &String,
[INFO] [stderr]     |              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/patch.rs:159:14
[INFO] [stderr]     |
[INFO] [stderr] 159 |     patches: &Vec<PatchFile>,
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^ help: change this to: `&[PatchFile]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/patch.rs:161:14
[INFO] [stderr]     |
[INFO] [stderr] 161 |     srcinfo: &String,
[INFO] [stderr]     |              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/patch.rs:207:5
[INFO] [stderr]     |
[INFO] [stderr] 207 | /     write!(
[INFO] [stderr] 208 | |         &OpenOptions::new()
[INFO] [stderr] 209 | |             .read(false)
[INFO] [stderr] 210 | |             .write(true)
[INFO] [stderr] ...   |
[INFO] [stderr] 215 | |         updpkgbuild
[INFO] [stderr] 216 | |     );
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/patch.rs:220:31
[INFO] [stderr]     |
[INFO] [stderr] 220 | fn replace_array_string(text: &String, name: String, new_array: &Vec<String>) -> String {
[INFO] [stderr]     |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/patch.rs:220:65
[INFO] [stderr]     |
[INFO] [stderr] 220 | fn replace_array_string(text: &String, name: String, new_array: &Vec<String>) -> String {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/patch.rs:227:35
[INFO] [stderr]     |
[INFO] [stderr] 227 |                 if line.ends_with(")") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/patch.rs:233:31
[INFO] [stderr]     |
[INFO] [stderr] 233 |             if line.ends_with(")") {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/patch.rs:207:5
[INFO] [stderr]     |
[INFO] [stderr] 207 | /     write!(
[INFO] [stderr] 208 | |         &OpenOptions::new()
[INFO] [stderr] 209 | |             .read(false)
[INFO] [stderr] 210 | |             .write(true)
[INFO] [stderr] ...   |
[INFO] [stderr] 215 | |         updpkgbuild
[INFO] [stderr] 216 | |     );
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/patch.rs:254:55
[INFO] [stderr]     |
[INFO] [stderr] 254 | fn prepend_prepare_patches(pkgbuild: String, patches: &Vec<PatchFile>) -> String {
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^ help: change this to: `&[PatchFile]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/patch.rs:220:31
[INFO] [stderr]     |
[INFO] [stderr] 220 | fn replace_array_string(text: &String, name: String, new_array: &Vec<String>) -> String {
[INFO] [stderr]     |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/patch.rs:220:65
[INFO] [stderr]     |
[INFO] [stderr] 220 | fn replace_array_string(text: &String, name: String, new_array: &Vec<String>) -> String {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/patch.rs:227:35
[INFO] [stderr]     |
[INFO] [stderr] 227 |                 if line.ends_with(")") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/patch.rs:233:31
[INFO] [stderr]     |
[INFO] [stderr] 233 |             if line.ends_with(")") {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/patch.rs:254:55
[INFO] [stderr]     |
[INFO] [stderr] 254 | fn prepend_prepare_patches(pkgbuild: String, patches: &Vec<PatchFile>) -> String {
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^ help: change this to: `&[PatchFile]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.79s
[INFO] running `"docker" "inspect" "aa3401d5a15b74d592ec72eea43c8d2a6b596194e4eca3ce84a3079a2da5fb95"`
[INFO] running `"docker" "rm" "-f" "aa3401d5a15b74d592ec72eea43c8d2a6b596194e4eca3ce84a3079a2da5fb95"`
[INFO] [stdout] aa3401d5a15b74d592ec72eea43c8d2a6b596194e4eca3ce84a3079a2da5fb95