[INFO] crate mailparse 0.6.4 is already in cache [INFO] extracting crate mailparse 0.6.4 into work/ex/clippy-test-run/sources/stable/reg/mailparse/0.6.4 [INFO] extracting crate mailparse 0.6.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mailparse/0.6.4 [INFO] validating manifest of mailparse-0.6.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mailparse-0.6.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mailparse-0.6.4 [INFO] finished frobbing mailparse-0.6.4 [INFO] frobbed toml for mailparse-0.6.4 written to work/ex/clippy-test-run/sources/stable/reg/mailparse/0.6.4/Cargo.toml [INFO] started frobbing mailparse-0.6.4 [INFO] finished frobbing mailparse-0.6.4 [INFO] frobbed toml for mailparse-0.6.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mailparse/0.6.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mailparse-0.6.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mailparse/0.6.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9a06f7c26adc3e8ae451c4376c312be8c0b87ead668153cbffd4be77c60e7e2 [INFO] running `"docker" "start" "-a" "c9a06f7c26adc3e8ae451c4376c312be8c0b87ead668153cbffd4be77c60e7e2"` [INFO] [stderr] Checking quoted_printable v0.4.0 [INFO] [stderr] Checking mailparse v0.6.4 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dateparse.rs:194:20 [INFO] [stderr] | [INFO] [stderr] 194 | 1474842993); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_474_842_993` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dateparse.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | 4102485133); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_102_485_133` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dateparse.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | 4133894400); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_133_894_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dateparse.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | 13569379200); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `13_569_379_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dateparse.rs:202:20 [INFO] [stderr] | [INFO] [stderr] 202 | 13601001600); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `13_601_001_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dateparse.rs:203:70 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(dateparse("17 Sep 2016 16:05:38 -1000").unwrap(), 1474164338); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_474_164_338` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dateparse.rs:205:20 [INFO] [stderr] | [INFO] [stderr] 205 | 1354309043); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_354_309_043` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/lib.rs:845:5 [INFO] [stderr] | [INFO] [stderr] 845 | / fn parse_basic_header() { [INFO] [stderr] 846 | | let (parsed, _) = parse_header(b"Key: Value").unwrap(); [INFO] [stderr] 847 | | assert_eq!(parsed.key, b"Key"); [INFO] [stderr] 848 | | assert_eq!(parsed.get_key().unwrap(), "Key"); [INFO] [stderr] ... | [INFO] [stderr] 891 | | parse_header(b"Key\nBroken: Value").unwrap_err(); [INFO] [stderr] 892 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/lib.rs:967:5 [INFO] [stderr] | [INFO] [stderr] 967 | / fn parse_multiple_headers() { [INFO] [stderr] 968 | | let (parsed, _) = parse_headers(b"Key: Value\nTwo: Second").unwrap(); [INFO] [stderr] 969 | | assert_eq!(parsed.len(), 2); [INFO] [stderr] 970 | | assert_eq!(parsed[0].key, b"Key"); [INFO] [stderr] ... | [INFO] [stderr] 1055 | | assert_match!(parse_headers(b"K:V\nBad\nKey").unwrap_err(), MailParseError::Generic(_)); [INFO] [stderr] 1056 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1073:20 [INFO] [stderr] | [INFO] [stderr] 1073 | assert_eq!(ctype.params.get("boundary").unwrap(), "foo"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ctype.params["boundary"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/lib.rs:1097:5 [INFO] [stderr] | [INFO] [stderr] 1097 | / fn test_parse_mail() { [INFO] [stderr] 1098 | | let mail = parse_mail(b"Key: value\r\n\r\nSome body stuffs").unwrap(); [INFO] [stderr] 1099 | | assert_eq!(mail.headers.len(), 1); [INFO] [stderr] 1100 | | assert_eq!(mail.headers[0].get_key().unwrap(), "Key"); [INFO] [stderr] ... | [INFO] [stderr] 1150 | | assert_eq!(mail.get_body().unwrap(), "hello world"); [INFO] [stderr] 1151 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:1125:20 [INFO] [stderr] | [INFO] [stderr] 1125 | assert_eq!(mail.ctype.params.get("boundary").unwrap(), "myboundary"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&mail.ctype.params["boundary"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:1199:31 [INFO] [stderr] | [INFO] [stderr] 1199 | let mail = parse_mail("".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.56s [INFO] running `"docker" "inspect" "c9a06f7c26adc3e8ae451c4376c312be8c0b87ead668153cbffd4be77c60e7e2"` [INFO] running `"docker" "rm" "-f" "c9a06f7c26adc3e8ae451c4376c312be8c0b87ead668153cbffd4be77c60e7e2"` [INFO] [stdout] c9a06f7c26adc3e8ae451c4376c312be8c0b87ead668153cbffd4be77c60e7e2