[INFO] crate mailchecker 3.2.13 is already in cache [INFO] extracting crate mailchecker 3.2.13 into work/ex/clippy-test-run/sources/stable/reg/mailchecker/3.2.13 [INFO] extracting crate mailchecker 3.2.13 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mailchecker/3.2.13 [INFO] validating manifest of mailchecker-3.2.13 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mailchecker-3.2.13 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mailchecker-3.2.13 [INFO] finished frobbing mailchecker-3.2.13 [INFO] frobbed toml for mailchecker-3.2.13 written to work/ex/clippy-test-run/sources/stable/reg/mailchecker/3.2.13/Cargo.toml [INFO] started frobbing mailchecker-3.2.13 [INFO] finished frobbing mailchecker-3.2.13 [INFO] frobbed toml for mailchecker-3.2.13 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mailchecker/3.2.13/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mailchecker-3.2.13 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mailchecker/3.2.13:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6df49a2e23a6f4a1c44b61a95357bd6bed1515a1e8d198868ef96c7489ed0695 [INFO] running `"docker" "start" "-a" "6df49a2e23a6f4a1c44b61a95357bd6bed1515a1e8d198868ef96c7489ed0695"` [INFO] [stderr] Checking ascii_utils v0.9.3 [INFO] [stderr] Checking fast_chemail v0.9.5 [INFO] [stderr] Checking mailchecker v3.2.13 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | return !email_domain_is_in_blacklist; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!email_domain_is_in_blacklist` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | return BLACKLIST.contains(&domain) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BLACKLIST.contains(&domain)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:3 [INFO] [stderr] | [INFO] [stderr] 92 | return BLACKLIST.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BLACKLIST.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:64:3 [INFO] [stderr] | [INFO] [stderr] 64 | return !email_domain_is_in_blacklist; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!email_domain_is_in_blacklist` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | return BLACKLIST.contains(&domain) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BLACKLIST.contains(&domain)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:92:3 [INFO] [stderr] | [INFO] [stderr] 92 | return BLACKLIST.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BLACKLIST.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | let domains = email.split("@").skip(1).collect::(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | (1..domain_part.len()+1).map(|i| (domain_part[0..i]).iter().map(|&x| x).collect::>().join(".")).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=domain_part.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | (1..domain_part.len()+1).map(|i| (domain_part[0..i]).iter().map(|&x| x).collect::>().join(".")).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `(domain_part[0..i]).iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | let domains = email.split("@").skip(1).collect::(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | (1..domain_part.len()+1).map(|i| (domain_part[0..i]).iter().map(|&x| x).collect::>().join(".")).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=domain_part.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | (1..domain_part.len()+1).map(|i| (domain_part[0..i]).iter().map(|&x| x).collect::>().join(".")).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `(domain_part[0..i]).iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.42s [INFO] running `"docker" "inspect" "6df49a2e23a6f4a1c44b61a95357bd6bed1515a1e8d198868ef96c7489ed0695"` [INFO] running `"docker" "rm" "-f" "6df49a2e23a6f4a1c44b61a95357bd6bed1515a1e8d198868ef96c7489ed0695"` [INFO] [stdout] 6df49a2e23a6f4a1c44b61a95357bd6bed1515a1e8d198868ef96c7489ed0695