[INFO] crate mail-template 0.6.0 is already in cache [INFO] extracting crate mail-template 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/mail-template/0.6.0 [INFO] extracting crate mail-template 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-template/0.6.0 [INFO] validating manifest of mail-template-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mail-template-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mail-template-0.6.0 [INFO] finished frobbing mail-template-0.6.0 [INFO] frobbed toml for mail-template-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/mail-template/0.6.0/Cargo.toml [INFO] started frobbing mail-template-0.6.0 [INFO] finished frobbing mail-template-0.6.0 [INFO] frobbed toml for mail-template-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-template/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mail-template-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mail-template/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9509bc92b76ed8cb35fc4f745876421a4afe95a1c8e818e227db29ceadf4a690 [INFO] running `"docker" "start" "-a" "9509bc92b76ed8cb35fc4f745876421a4afe95a1c8e818e227db29ceadf4a690"` [INFO] [stderr] Checking soft-ascii-string v1.0.0 [INFO] [stderr] Checking vec-drain-where v1.0.0 [INFO] [stderr] Compiling checked_command v0.2.2 [INFO] [stderr] Checking quoted_printable v0.4.0 [INFO] [stderr] Checking maybe-owned v0.3.2 [INFO] [stderr] Checking lut v0.1.0-unstable [INFO] [stderr] Checking vec1 v1.1.0 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking total-order-multi-map v0.4.5 [INFO] [stderr] Checking media-type-impl-utils v0.3.0-unstable [INFO] [stderr] Checking media-type v0.4.0-unstable [INFO] [stderr] Checking mail-internals v0.2.0 [INFO] [stderr] Checking mail-headers v0.6.2 [INFO] [stderr] Checking mail-core v0.6.1 [INFO] [stderr] Checking mail-template v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Fail` [INFO] [stderr] --> src/lib.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | use failure::{Fail, Error}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/additional_cid.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Fail` [INFO] [stderr] --> src/lib.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | use failure::{Fail, Error}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/additional_cid.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/base_dir.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | .map_err(|err| D::Error::custom(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `D::Error::custom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/base_dir.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | .map_err(|err| S::Error::custom(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `S::Error::custom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/path_rebase.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / if let &mut Resource::Source(ref mut source) = self { [INFO] [stderr] 126 | | source.iri.rebase_to_include_base_dir(base_dir)?; [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | if let Resource::Source(ref mut source) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/path_rebase.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / if let &mut Resource::Source(ref mut source) = self { [INFO] [stderr] 135 | | source.iri.rebase_to_exclude_base_dir(base_dir)?; [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 134 | if let Resource::Source(ref mut source) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/base_dir.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | .map_err(|err| D::Error::custom(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `D::Error::custom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/base_dir.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | .map_err(|err| S::Error::custom(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `S::Error::custom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/path_rebase.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / if let &mut Resource::Source(ref mut source) = self { [INFO] [stderr] 126 | | source.iri.rebase_to_include_base_dir(base_dir)?; [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 125 | if let Resource::Source(ref mut source) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/path_rebase.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / if let &mut Resource::Source(ref mut source) = self { [INFO] [stderr] 135 | | source.iri.rebase_to_exclude_base_dir(base_dir)?; [INFO] [stderr] 136 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 134 | if let Resource::Source(ref mut source) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | fn render<'r, 'a>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/serde_impl.rs:311:9 [INFO] [stderr] | [INFO] [stderr] 311 | / if let &Resource::Source(ref source) = resource { [INFO] [stderr] 312 | | assert_eq!(source.iri.as_str(), iri); [INFO] [stderr] 313 | | } else { [INFO] [stderr] 314 | | panic!("unexpected resource expected resource with source and iri {:?} but got {:?}", iri, resource); [INFO] [stderr] 315 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 311 | if let Resource::Source(ref source) = *resource { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | fn render<'r, 'a>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.15s [INFO] running `"docker" "inspect" "9509bc92b76ed8cb35fc4f745876421a4afe95a1c8e818e227db29ceadf4a690"` [INFO] running `"docker" "rm" "-f" "9509bc92b76ed8cb35fc4f745876421a4afe95a1c8e818e227db29ceadf4a690"` [INFO] [stdout] 9509bc92b76ed8cb35fc4f745876421a4afe95a1c8e818e227db29ceadf4a690