[INFO] crate mail-smtp 0.2.0 is already in cache [INFO] extracting crate mail-smtp 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/mail-smtp/0.2.0 [INFO] extracting crate mail-smtp 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-smtp/0.2.0 [INFO] validating manifest of mail-smtp-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mail-smtp-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mail-smtp-0.2.0 [INFO] finished frobbing mail-smtp-0.2.0 [INFO] frobbed toml for mail-smtp-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/mail-smtp/0.2.0/Cargo.toml [INFO] started frobbing mail-smtp-0.2.0 [INFO] finished frobbing mail-smtp-0.2.0 [INFO] frobbed toml for mail-smtp-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-smtp/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mail-smtp-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mail-smtp/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b02321989bf1eac4a54ec046afe612bf235c57ad235f9cfbda2c3cdd99ccfae4 [INFO] running `"docker" "start" "-a" "b02321989bf1eac4a54ec046afe612bf235c57ad235f9cfbda2c3cdd99ccfae4"` [INFO] [stderr] Checking quoted-string v0.6.0 [INFO] [stderr] Compiling checked_command v0.2.2 [INFO] [stderr] Checking quoted_printable v0.4.0 [INFO] [stderr] Checking vec-drain-where v1.0.0 [INFO] [stderr] Checking soft-ascii-string v1.0.0 [INFO] [stderr] Checking vec1 v1.1.0 [INFO] [stderr] Checking lut v0.1.0-unstable [INFO] [stderr] Checking total-order-multi-map v0.4.5 [INFO] [stderr] Checking new-tokio-smtp v0.8.1 [INFO] [stderr] Checking media-type-impl-utils v0.3.0-unstable [INFO] [stderr] Checking media-type v0.4.0-unstable [INFO] [stderr] Checking mail-internals v0.2.0 [INFO] [stderr] Checking mail-headers v0.6.2 [INFO] [stderr] Checking mail-core v0.6.1 [INFO] [stderr] Checking mail-smtp v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/send_mail.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | fut [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/send_mail.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | let fut = encode(mail, ctx) [INFO] [stderr] | _______________^ [INFO] [stderr] 46 | | .then(move |envelop_res| Connection [INFO] [stderr] 47 | | ::connect_send_quit(conconf, one(envelop_res)) [INFO] [stderr] 48 | | .collect()) [INFO] [stderr] 49 | | .map(|mut results| results.pop().expect("[BUG] sending one mail expects one result")); [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/send_mail.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fut [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/send_mail.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | let fut = collect_res(stream::futures_ordered(iter)) [INFO] [stderr] | _______________^ [INFO] [stderr] 84 | | .map(move |vec_of_res| Connection::connect_send_quit(conconf, vec_of_res)) [INFO] [stderr] 85 | | .flatten_stream(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/resolve_all.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | .map(|fut| AltFuse::Future(fut)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AltFuse::Future` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/send_mail.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | stream.then(|res| Ok(res)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/send_mail.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | fut [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/send_mail.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | let fut = encode(mail, ctx) [INFO] [stderr] | _______________^ [INFO] [stderr] 46 | | .then(move |envelop_res| Connection [INFO] [stderr] 47 | | ::connect_send_quit(conconf, one(envelop_res)) [INFO] [stderr] 48 | | .collect()) [INFO] [stderr] 49 | | .map(|mut results| results.pop().expect("[BUG] sending one mail expects one result")); [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/send_mail.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | fut [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/send_mail.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | let fut = collect_res(stream::futures_ordered(iter)) [INFO] [stderr] | _______________^ [INFO] [stderr] 84 | | .map(move |vec_of_res| Connection::connect_send_quit(conconf, vec_of_res)) [INFO] [stderr] 85 | | .flatten_stream(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/resolve_all.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | .map(|fut| AltFuse::Future(fut)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AltFuse::Future` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/send_mail.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | stream.then(|res| Ok(res)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.50s [INFO] running `"docker" "inspect" "b02321989bf1eac4a54ec046afe612bf235c57ad235f9cfbda2c3cdd99ccfae4"` [INFO] running `"docker" "rm" "-f" "b02321989bf1eac4a54ec046afe612bf235c57ad235f9cfbda2c3cdd99ccfae4"` [INFO] [stdout] b02321989bf1eac4a54ec046afe612bf235c57ad235f9cfbda2c3cdd99ccfae4