[INFO] crate mail-internals 0.2.0 is already in cache [INFO] extracting crate mail-internals 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/mail-internals/0.2.0 [INFO] extracting crate mail-internals 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-internals/0.2.0 [INFO] validating manifest of mail-internals-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mail-internals-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mail-internals-0.2.0 [INFO] finished frobbing mail-internals-0.2.0 [INFO] frobbed toml for mail-internals-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/mail-internals/0.2.0/Cargo.toml [INFO] started frobbing mail-internals-0.2.0 [INFO] finished frobbing mail-internals-0.2.0 [INFO] frobbed toml for mail-internals-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-internals/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mail-internals-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mail-internals/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03ee7edb150d3bccd0bc321c54149afb25dba1a6f11f290ff530de2bf0698a63 [INFO] running `"docker" "start" "-a" "03ee7edb150d3bccd0bc321c54149afb25dba1a6f11f290ff530de2bf0698a63"` [INFO] [stderr] Checking soft-ascii-string v1.0.0 [INFO] [stderr] Checking vec1 v1.1.0 [INFO] [stderr] Checking media-type v0.4.0-unstable [INFO] [stderr] Checking mail-internals v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:113:10 [INFO] [stderr] | [INFO] [stderr] 113 | (b & 0b11000000) == 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils/mod.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | (b & 0b11000000) == 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grammar.rs:313:17 [INFO] [stderr] | [INFO] [stderr] 313 | return Err((EncodingErrorKind::Malformed, mail_type).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err((EncodingErrorKind::Malformed, mail_type).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grammar.rs:316:17 [INFO] [stderr] | [INFO] [stderr] 316 | return Err((EncodingErrorKind::Malformed, mail_type).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err((EncodingErrorKind::Malformed, mail_type).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grammar.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/encoder/mod.rs:716:9 [INFO] [stderr] | [INFO] [stderr] 716 | / if self.current_line_byte_length() >= LINE_LEN_SOFT_LIMIT { [INFO] [stderr] 717 | | if !self.break_line_on_fws() { [INFO] [stderr] 718 | | if self.buffer.len() == LINE_LEN_HARD_LIMIT { [INFO] [stderr] 719 | | ec_bail!( [INFO] [stderr] ... | [INFO] [stderr] 724 | | } [INFO] [stderr] 725 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 716 | if self.current_line_byte_length() >= LINE_LEN_SOFT_LIMIT && !self.break_line_on_fws() { [INFO] [stderr] 717 | if self.buffer.len() == LINE_LEN_HARD_LIMIT { [INFO] [stderr] 718 | ec_bail!( [INFO] [stderr] 719 | mail_type: self.mail_type(), [INFO] [stderr] 720 | kind: HardLineLengthLimitBreached [INFO] [stderr] 721 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/encoder/mod.rs:717:13 [INFO] [stderr] | [INFO] [stderr] 717 | / if !self.break_line_on_fws() { [INFO] [stderr] 718 | | if self.buffer.len() == LINE_LEN_HARD_LIMIT { [INFO] [stderr] 719 | | ec_bail!( [INFO] [stderr] 720 | | mail_type: self.mail_type(), [INFO] [stderr] ... | [INFO] [stderr] 723 | | } [INFO] [stderr] 724 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 717 | if !self.break_line_on_fws() && self.buffer.len() == LINE_LEN_HARD_LIMIT { [INFO] [stderr] 718 | ec_bail!( [INFO] [stderr] 719 | mail_type: self.mail_type(), [INFO] [stderr] 720 | kind: HardLineLengthLimitBreached [INFO] [stderr] 721 | ); [INFO] [stderr] 722 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: testing needs feature `traceing` to be enabled [INFO] [stderr] --> src/lib.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | compile_error! { "testing needs feature `traceing` to be enabled" } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mail-internals`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utils/mod.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | let res: &EXP = unsafe { mem::transmute::<&GOT, &EXP>(inp) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(inp as *const GOT as *const EXP)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utils/mod.rs:71:38 [INFO] [stderr] | [INFO] [stderr] 71 | let res: &mut EXP = unsafe { mem::transmute::<&mut GOT, &mut EXP>(inp) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(inp as *mut GOT as *mut EXP)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/utils/mod.rs:123:36 [INFO] [stderr] | [INFO] [stderr] 123 | let insertion_point = unsafe { target.as_mut_ptr().offset(idx as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/utils/mod.rs:130:22 [INFO] [stderr] | [INFO] [stderr] 130 | /*dest*/insertion_point.offset(insertion_len as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `insertion_point.add(insertion_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mail_type.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn is_internationalized(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mail_type.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn supports_8bit_bodies( &self ) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/grammar.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | 0 < s.len() && s.chars().all(is_token_char) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/grammar.rs:260:28 [INFO] [stderr] | [INFO] [stderr] 260 | fn char_validator( &self ) -> fn(char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/grammar.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn try_parse_encoded_word_parts( [INFO] [stderr] 284 | | word: &str, [INFO] [stderr] 285 | | ctx: EncodedWordContext, [INFO] [stderr] 286 | | mail_type: MailType [INFO] [stderr] ... | [INFO] [stderr] 318 | | } [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/grammar.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | / if iter.next().is_none() { [INFO] [stderr] 374 | | return true; [INFO] [stderr] 375 | | } else { [INFO] [stderr] 376 | | return false; [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `return iter.next().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bind/encoded_word/mod.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn acronym(&self) -> &'static SoftAsciiStr { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bind/encoded_word/mod.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn encode(&self, input: R, out: &mut O) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bind/base64.rs:65:20 [INFO] [stderr] | [INFO] [stderr] 65 | debug_assert!( USE_PADDING == true, "size calculation is tailored for padding"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `USE_PADDING` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bind/base64.rs:100:48 [INFO] [stderr] | [INFO] [stderr] 100 | extern_base64::encode_config_buf(this, config.clone(), &mut buff); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bind/base64.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if rest.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/bind/quoted_printable.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn encoded_word_encode_utf8<'a, O>(word: &str, writer: &mut O ) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `buf`. [INFO] [stderr] --> src/bind/quoted_printable.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | for idx in 0..buf_idx { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 145 | for in buf.iter().take(buf_idx) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "03ee7edb150d3bccd0bc321c54149afb25dba1a6f11f290ff530de2bf0698a63"` [INFO] running `"docker" "rm" "-f" "03ee7edb150d3bccd0bc321c54149afb25dba1a6f11f290ff530de2bf0698a63"` [INFO] [stdout] 03ee7edb150d3bccd0bc321c54149afb25dba1a6f11f290ff530de2bf0698a63