[INFO] crate mail-headers 0.6.2 is already in cache [INFO] extracting crate mail-headers 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/mail-headers/0.6.2 [INFO] extracting crate mail-headers 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-headers/0.6.2 [INFO] validating manifest of mail-headers-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mail-headers-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mail-headers-0.6.2 [INFO] finished frobbing mail-headers-0.6.2 [INFO] frobbed toml for mail-headers-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/mail-headers/0.6.2/Cargo.toml [INFO] started frobbing mail-headers-0.6.2 [INFO] finished frobbing mail-headers-0.6.2 [INFO] frobbed toml for mail-headers-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-headers/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mail-headers-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mail-headers/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8babdfa8cbf31ea4732da580e987b9af53031f4ed1088fe4047c1be2a9a692e1 [INFO] running `"docker" "start" "-a" "8babdfa8cbf31ea4732da580e987b9af53031f4ed1088fe4047c1be2a9a692e1"` [INFO] [stderr] Checking quoted-string v0.6.0 [INFO] [stderr] Checking soft-ascii-string v1.0.0 [INFO] [stderr] Checking vec1 v1.1.0 [INFO] [stderr] Checking vec-drain-where v1.0.0 [INFO] [stderr] Checking lut v0.1.0-unstable [INFO] [stderr] Checking total-order-multi-map v0.4.5 [INFO] [stderr] Checking media-type-impl-utils v0.3.0-unstable [INFO] [stderr] Checking media-type v0.4.0-unstable [INFO] [stderr] Checking mail-internals v0.2.0 [INFO] [stderr] Checking mail-headers v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header_components/media_type.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | media_type: media_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `media_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header_components/media_type.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | media_type: media_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `media_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: testing needs feature `traceing` to be enabled [INFO] [stderr] --> src/lib.rs:141:1 [INFO] [stderr] | [INFO] [stderr] 141 | compile_error! { "testing needs feature `traceing` to be enabled" } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mail-headers`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/header_components/disposition.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | return Err(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/name.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | if name.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/data/inner_item.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Debug, Clone, Hash, Eq)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/data/inner_item.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129| / impl PartialEq for $name { [INFO] [stderr] 130| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 131| | let me: &$borrowed_form = &*self; [INFO] [stderr] 132| | let other: &$borrowed_form = &*other; [INFO] [stderr] 133| | me == other [INFO] [stderr] 134| | } [INFO] [stderr] 135| | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 145| inner_impl!{ InnerAscii, SoftAsciiString, SoftAsciiStr } [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/data/inner_item.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | #[derive(Debug, Clone, Hash, Eq)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/data/inner_item.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129| / impl PartialEq for $name { [INFO] [stderr] 130| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 131| | let me: &$borrowed_form = &*self; [INFO] [stderr] 132| | let other: &$borrowed_form = &*other; [INFO] [stderr] 133| | me == other [INFO] [stderr] 134| | } [INFO] [stderr] 135| | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 146| inner_impl!{ InnerUtf8, String, str } [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: item `map::HeaderMap` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/map/mod.rs:166:1 [INFO] [stderr] | [INFO] [stderr] 166 | / impl HeaderMap { [INFO] [stderr] 167 | | [INFO] [stderr] 168 | | /// create a new empty header map [INFO] [stderr] 169 | | pub fn new() -> Self { [INFO] [stderr] ... | [INFO] [stderr] 461 | | [INFO] [stderr] 462 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map/mod.rs:648:22 [INFO] [stderr] | [INFO] [stderr] 648 | fn identity_repr(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header_components/utils/text_partition.rs:22:8 [INFO] [stderr] | [INFO] [stderr] 22 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/header_components/email.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | let index = shared.find( "@" ) [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/header_components/email.rs:209:31 [INFO] [stderr] | [INFO] [stderr] 209 | if domain.starts_with("[") && domain.ends_with("]") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/header_components/email.rs:209:56 [INFO] [stderr] | [INFO] [stderr] 209 | if domain.starts_with("[") && domain.ends_with("]") { [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/header_components/transfer_encoding.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | Box::new(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/header_components/unstructured.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if text.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/header_components/media_type.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mail-headers`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8babdfa8cbf31ea4732da580e987b9af53031f4ed1088fe4047c1be2a9a692e1"` [INFO] running `"docker" "rm" "-f" "8babdfa8cbf31ea4732da580e987b9af53031f4ed1088fe4047c1be2a9a692e1"` [INFO] [stdout] 8babdfa8cbf31ea4732da580e987b9af53031f4ed1088fe4047c1be2a9a692e1