[INFO] crate mail-core 0.6.0 is already in cache
[INFO] extracting crate mail-core 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/mail-core/0.6.0
[INFO] extracting crate mail-core 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-core/0.6.0
[INFO] validating manifest of mail-core-0.6.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mail-core-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mail-core-0.6.0
[INFO] finished frobbing mail-core-0.6.0
[INFO] frobbed toml for mail-core-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/mail-core/0.6.0/Cargo.toml
[INFO] started frobbing mail-core-0.6.0
[INFO] finished frobbing mail-core-0.6.0
[INFO] frobbed toml for mail-core-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mail-core/0.6.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mail-core-0.6.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mail-core/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 566ebfb08969a5841ac7e66600484dbbff2a67b5b30e9d989c121989ecb64579
[INFO] running `"docker" "start" "-a" "566ebfb08969a5841ac7e66600484dbbff2a67b5b30e9d989c121989ecb64579"`
[INFO] [stderr]     Checking quoted-string v0.6.0
[INFO] [stderr]    Compiling checked_command v0.2.2
[INFO] [stderr]     Checking quoted_printable v0.4.0
[INFO] [stderr]     Checking soft-ascii-string v1.0.0
[INFO] [stderr]     Checking vec1 v1.1.0
[INFO] [stderr]     Checking vec-drain-where v1.0.0
[INFO] [stderr]     Checking lut v0.1.0-unstable
[INFO] [stderr]     Checking media-type-impl-utils v0.3.0-unstable
[INFO] [stderr]     Checking total-order-multi-map v0.4.5
[INFO] [stderr]     Checking media-type v0.4.0-unstable
[INFO] [stderr]     Checking mail-internals v0.2.0
[INFO] [stderr]     Checking mail-headers v0.6.2
[INFO] [stderr]     Checking mail-core v0.6.0 (/opt/crater/workdir)
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/resource/loading.rs:179:48
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let InnerFuture { mut container, keys, futs:_ } = self.inner.take().unwrap();
[INFO] [stderr]     |                                                ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `InnerFuture { mut container, keys, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/encode.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         MultipleBodies { hidden_text:_, bodies:_ } => {}
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `MultipleBodies { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/compose.rs:199:9
[INFO] [stderr]     |
[INFO] [stderr] 199 |         mail
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/compose.rs:193:13
[INFO] [stderr]     |
[INFO] [stderr] 193 | /             if attachments.is_empty() {
[INFO] [stderr] 194 | |                 mail
[INFO] [stderr] 195 | |             } else {
[INFO] [stderr] 196 | |                 mail.wrap_with_mixed(attachments)
[INFO] [stderr] 197 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/resource/loading.rs:179:48
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let InnerFuture { mut container, keys, futs:_ } = self.inner.take().unwrap();
[INFO] [stderr]     |                                                ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `InnerFuture { mut container, keys, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]    --> src/encode.rs:111:9
[INFO] [stderr]     |
[INFO] [stderr] 111 |         MultipleBodies { hidden_text:_, bodies:_ } => {}
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Try with `MultipleBodies { .. }` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/compose.rs:199:9
[INFO] [stderr]     |
[INFO] [stderr] 199 |         mail
[INFO] [stderr]     |         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/compose.rs:193:13
[INFO] [stderr]     |
[INFO] [stderr] 193 | /             if attachments.is_empty() {
[INFO] [stderr] 194 | |                 mail
[INFO] [stderr] 195 | |             } else {
[INFO] [stderr] 196 | |                 mail.wrap_with_mixed(attachments)
[INFO] [stderr] 197 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/context.rs:29:24
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn to_resource(self) -> Resource {
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/resource/loading.rs:82:35
[INFO] [stderr]    |
[INFO] [stderr] 82 | impl ContainedResourcesAccess for HashMap<String, Resource> {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 82 | impl<S: ::std::hash::BuildHasher> ContainedResourcesAccess for HashMap<String, Resource, S> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/resource/loading.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 | /             if let &Resource::Source(ref source) = resource {
[INFO] [stderr] 145 | |                 let fut = ctx.load_resource(source);
[INFO] [stderr] 146 | |                 futs.push(fut);
[INFO] [stderr] 147 | |                 keys.push(key.to_owned());
[INFO] [stderr] 148 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 144 |             if let Resource::Source(ref source) = *resource {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/resource/mod.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match self {
[INFO] [stderr] 188 | |             &Resource::Source(..) => None,
[INFO] [stderr] 189 | |             &Resource::Data(ref data) => Some(data.content_id()),
[INFO] [stderr] 190 | |             &Resource::EncData(ref enc_data) => Some(enc_data.content_id())
[INFO] [stderr] 191 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 187 |         match *self {
[INFO] [stderr] 188 |             Resource::Source(..) => None,
[INFO] [stderr] 189 |             Resource::Data(ref data) => Some(data.content_id()),
[INFO] [stderr] 190 |             Resource::EncData(ref enc_data) => Some(enc_data.content_id())
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/encode.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |           let ignored_header = !top &&
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 92 | |             !(name_as_str.starts_with("Content-")
[INFO] [stderr] 93 | |                 || name_as_str.starts_with("X-") );
[INFO] [stderr]    | |__________________________________________________^ help: try: `!(name_as_str.starts_with("X-") || name_as_str.starts_with("Content-") || top)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/encode.rs:155:16
[INFO] [stderr]     |
[INFO] [stderr] 155 |             if hidden_text.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hidden_text.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/encode.rs:191:16
[INFO] [stderr]     |
[INFO] [stderr] 191 |             if bodies.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bodies.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/mail.rs:326:9
[INFO] [stderr]     |
[INFO] [stderr] 326 | /         match self.body() {
[INFO] [stderr] 327 | |             &MailBody::SingleBody { .. } => {},
[INFO] [stderr] 328 | |             &MailBody::MultipleBodies { ref bodies, .. } => {
[INFO] [stderr] 329 | |                 for body in bodies {
[INFO] [stderr] ...   |
[INFO] [stderr] 332 | |             }
[INFO] [stderr] 333 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 326 |         match *self.body() {
[INFO] [stderr] 327 |             MailBody::SingleBody { .. } => {},
[INFO] [stderr] 328 |             MailBody::MultipleBodies { ref bodies, .. } => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/mail.rs:428:5
[INFO] [stderr]     |
[INFO] [stderr] 428 | /     Loading {
[INFO] [stderr] 429 | |         mail: Mail,
[INFO] [stderr] 430 | |         pending: future::JoinAll<Vec<SendBoxFuture<EncData, ResourceLoadingError>>>,
[INFO] [stderr] 431 | |         ctx: C
[INFO] [stderr] 432 | |     },
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]    --> src/mail.rs:428:5
[INFO] [stderr]     |
[INFO] [stderr] 428 | /     Loading {
[INFO] [stderr] 429 | |         mail: Mail,
[INFO] [stderr] 430 | |         pending: future::JoinAll<Vec<SendBoxFuture<EncData, ResourceLoadingError>>>,
[INFO] [stderr] 431 | |         ctx: C
[INFO] [stderr] 432 | |     },
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/mail.rs:568:5
[INFO] [stderr]     |
[INFO] [stderr] 568 | /     match resource {
[INFO] [stderr] 569 | |         &Resource::EncData(ref ed) => ed,
[INFO] [stderr] 570 | |         _ => panic!("[BUG] auto gen/encode should only be called on all resources are loaded")
[INFO] [stderr] 571 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 568 |     match *resource {
[INFO] [stderr] 569 |         Resource::EncData(ref ed) => ed,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/mail.rs:576:5
[INFO] [stderr]     |
[INFO] [stderr] 576 | /     match body {
[INFO] [stderr] 577 | |         &mut MailBody::SingleBody { ref mut body } => {
[INFO] [stderr] 578 | |             if let Some(Ok(disposition)) = headers.get_single_mut(ContentDisposition) {
[INFO] [stderr] 579 | |                 let current_file_meta_mut = disposition.file_meta_mut();
[INFO] [stderr] ...   |
[INFO] [stderr] 598 | |         }
[INFO] [stderr] 599 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 576 |     match *body {
[INFO] [stderr] 577 |         MailBody::SingleBody { ref mut body } => {
[INFO] [stderr] 578 |             if let Some(Ok(disposition)) = headers.get_single_mut(ContentDisposition) {
[INFO] [stderr] 579 |                 let current_file_meta_mut = disposition.file_meta_mut();
[INFO] [stderr] 580 |                 let data = assume_encoded(body);
[INFO] [stderr] 581 |                 current_file_meta_mut.replace_empty_fields_with(data.file_meta())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/default_impl/message_id_gen.rs:100:8
[INFO] [stderr]     |
[INFO] [stderr] 100 |        self.generate_message_id().into()
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.generate_message_id()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/default_impl/simple_context.rs:72:18
[INFO] [stderr]    |
[INFO] [stderr] 72 |         .map_err(|err| ContextSetupError::ReadingEnv(err))?;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ContextSetupError::ReadingEnv`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/default_impl/simple_context.rs:78:18
[INFO] [stderr]    |
[INFO] [stderr] 78 |         .map_err(|err| ContextSetupError::PunyCodingDomain(err))?;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ContextSetupError::PunyCodingDomain`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/mime.rs:87:38
[INFO] [stderr]    |
[INFO] [stderr] 87 |             assert!(!out.starts_with("\""));
[INFO] [stderr]    |                                      ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/mime.rs:88:36
[INFO] [stderr]    |
[INFO] [stderr] 88 |             assert!(!out.ends_with("\""));
[INFO] [stderr]    |                                    ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/context.rs:29:24
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn to_resource(self) -> Resource {
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/resource/loading.rs:82:35
[INFO] [stderr]    |
[INFO] [stderr] 82 | impl ContainedResourcesAccess for HashMap<String, Resource> {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 82 | impl<S: ::std::hash::BuildHasher> ContainedResourcesAccess for HashMap<String, Resource, S> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/resource/loading.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 | /             if let &Resource::Source(ref source) = resource {
[INFO] [stderr] 145 | |                 let fut = ctx.load_resource(source);
[INFO] [stderr] 146 | |                 futs.push(fut);
[INFO] [stderr] 147 | |                 keys.push(key.to_owned());
[INFO] [stderr] 148 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 144 |             if let Resource::Source(ref source) = *resource {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/resource/mod.rs:187:9
[INFO] [stderr]     |
[INFO] [stderr] 187 | /         match self {
[INFO] [stderr] 188 | |             &Resource::Source(..) => None,
[INFO] [stderr] 189 | |             &Resource::Data(ref data) => Some(data.content_id()),
[INFO] [stderr] 190 | |             &Resource::EncData(ref enc_data) => Some(enc_data.content_id())
[INFO] [stderr] 191 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 187 |         match *self {
[INFO] [stderr] 188 |             Resource::Source(..) => None,
[INFO] [stderr] 189 |             Resource::Data(ref data) => Some(data.content_id()),
[INFO] [stderr] 190 |             Resource::EncData(ref enc_data) => Some(enc_data.content_id())
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/encode.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |           let ignored_header = !top &&
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 92 | |             !(name_as_str.starts_with("Content-")
[INFO] [stderr] 93 | |                 || name_as_str.starts_with("X-") );
[INFO] [stderr]    | |__________________________________________________^ help: try: `!(name_as_str.starts_with("X-") || name_as_str.starts_with("Content-") || top)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/encode.rs:155:16
[INFO] [stderr]     |
[INFO] [stderr] 155 |             if hidden_text.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hidden_text.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/encode.rs:191:16
[INFO] [stderr]     |
[INFO] [stderr] 191 |             if bodies.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bodies.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/mail.rs:326:9
[INFO] [stderr]     |
[INFO] [stderr] 326 | /         match self.body() {
[INFO] [stderr] 327 | |             &MailBody::SingleBody { .. } => {},
[INFO] [stderr] 328 | |             &MailBody::MultipleBodies { ref bodies, .. } => {
[INFO] [stderr] 329 | |                 for body in bodies {
[INFO] [stderr] ...   |
[INFO] [stderr] 332 | |             }
[INFO] [stderr] 333 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 326 |         match *self.body() {
[INFO] [stderr] 327 |             MailBody::SingleBody { .. } => {},
[INFO] [stderr] 328 |             MailBody::MultipleBodies { ref bodies, .. } => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]    --> src/mail.rs:428:5
[INFO] [stderr]     |
[INFO] [stderr] 428 | /     Loading {
[INFO] [stderr] 429 | |         mail: Mail,
[INFO] [stderr] 430 | |         pending: future::JoinAll<Vec<SendBoxFuture<EncData, ResourceLoadingError>>>,
[INFO] [stderr] 431 | |         ctx: C
[INFO] [stderr] 432 | |     },
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]    --> src/mail.rs:428:5
[INFO] [stderr]     |
[INFO] [stderr] 428 | /     Loading {
[INFO] [stderr] 429 | |         mail: Mail,
[INFO] [stderr] 430 | |         pending: future::JoinAll<Vec<SendBoxFuture<EncData, ResourceLoadingError>>>,
[INFO] [stderr] 431 | |         ctx: C
[INFO] [stderr] 432 | |     },
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/mail.rs:568:5
[INFO] [stderr]     |
[INFO] [stderr] 568 | /     match resource {
[INFO] [stderr] 569 | |         &Resource::EncData(ref ed) => ed,
[INFO] [stderr] 570 | |         _ => panic!("[BUG] auto gen/encode should only be called on all resources are loaded")
[INFO] [stderr] 571 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 568 |     match *resource {
[INFO] [stderr] 569 |         Resource::EncData(ref ed) => ed,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/mail.rs:576:5
[INFO] [stderr]     |
[INFO] [stderr] 576 | /     match body {
[INFO] [stderr] 577 | |         &mut MailBody::SingleBody { ref mut body } => {
[INFO] [stderr] 578 | |             if let Some(Ok(disposition)) = headers.get_single_mut(ContentDisposition) {
[INFO] [stderr] 579 | |                 let current_file_meta_mut = disposition.file_meta_mut();
[INFO] [stderr] ...   |
[INFO] [stderr] 598 | |         }
[INFO] [stderr] 599 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 576 |     match *body {
[INFO] [stderr] 577 |         MailBody::SingleBody { ref mut body } => {
[INFO] [stderr] 578 |             if let Some(Ok(disposition)) = headers.get_single_mut(ContentDisposition) {
[INFO] [stderr] 579 |                 let current_file_meta_mut = disposition.file_meta_mut();
[INFO] [stderr] 580 |                 let data = assume_encoded(body);
[INFO] [stderr] 581 |                 current_file_meta_mut.replace_empty_fields_with(data.file_meta())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/mail.rs:724:17
[INFO] [stderr]     |
[INFO] [stderr] 724 | /                 if let &Resource::Data(ref body) = body {
[INFO] [stderr] 725 | |                     assert_eq!(
[INFO] [stderr] 726 | |                         [ "r1", "r2", "r3"][body_count].as_bytes(),
[INFO] [stderr] 727 | |                         body.buffer().as_ref()
[INFO] [stderr] ...   |
[INFO] [stderr] 730 | |                     panic!("unexpected body: {:?}", body);
[INFO] [stderr] 731 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 724 |                 if let Resource::Data(ref body) = *body {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/mail.rs:875:23
[INFO] [stderr]     |
[INFO] [stderr] 875 |                 Date: provided_date.clone()
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provided_date`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/default_impl/message_id_gen.rs:100:8
[INFO] [stderr]     |
[INFO] [stderr] 100 |        self.generate_message_id().into()
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.generate_message_id()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/default_impl/simple_context.rs:72:18
[INFO] [stderr]    |
[INFO] [stderr] 72 |         .map_err(|err| ContextSetupError::ReadingEnv(err))?;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ContextSetupError::ReadingEnv`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/default_impl/simple_context.rs:78:18
[INFO] [stderr]    |
[INFO] [stderr] 78 |         .map_err(|err| ContextSetupError::PunyCodingDomain(err))?;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ContextSetupError::PunyCodingDomain`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 21.57s
[INFO] running `"docker" "inspect" "566ebfb08969a5841ac7e66600484dbbff2a67b5b30e9d989c121989ecb64579"`
[INFO] running `"docker" "rm" "-f" "566ebfb08969a5841ac7e66600484dbbff2a67b5b30e9d989c121989ecb64579"`
[INFO] [stdout] 566ebfb08969a5841ac7e66600484dbbff2a67b5b30e9d989c121989ecb64579