[INFO] crate mai 0.1.0 is already in cache [INFO] extracting crate mai 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mai/0.1.0 [INFO] extracting crate mai 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mai/0.1.0 [INFO] validating manifest of mai-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mai-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mai-0.1.0 [INFO] finished frobbing mai-0.1.0 [INFO] frobbed toml for mai-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mai/0.1.0/Cargo.toml [INFO] started frobbing mai-0.1.0 [INFO] finished frobbing mai-0.1.0 [INFO] frobbed toml for mai-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mai/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mai-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mai/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9abcb2ec243a033378b5b942eaa2517800b427e884ca414a1337e3327b1816b9 [INFO] running `"docker" "start" "-a" "9abcb2ec243a033378b5b942eaa2517800b427e884ca414a1337e3327b1816b9"` [INFO] [stderr] Checking lifeguard v0.5.2 [INFO] [stderr] Checking mai v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:254:7 [INFO] [stderr] | [INFO] [stderr] 254 | buffer_pool: buffer_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:255:7 [INFO] [stderr] | [INFO] [stderr] 255 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:256:7 [INFO] [stderr] | [INFO] [stderr] 256 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:257:7 [INFO] [stderr] | [INFO] [stderr] 257 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:41:7 [INFO] [stderr] | [INFO] [stderr] 41 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:42:7 [INFO] [stderr] | [INFO] [stderr] 42 | bytes_read: bytes_read [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:124:7 [INFO] [stderr] | [INFO] [stderr] 124 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:126:7 [INFO] [stderr] | [INFO] [stderr] 126 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:128:7 [INFO] [stderr] | [INFO] [stderr] 128 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:129:7 [INFO] [stderr] | [INFO] [stderr] 129 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:174:7 [INFO] [stderr] | [INFO] [stderr] 174 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:175:7 [INFO] [stderr] | [INFO] [stderr] 175 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:176:7 [INFO] [stderr] | [INFO] [stderr] 176 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:177:7 [INFO] [stderr] | [INFO] [stderr] 177 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:178:7 [INFO] [stderr] | [INFO] [stderr] 178 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/remote.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | command_sender: command_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/remote.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | receiver: receiver [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timeout.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timeout.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_id.rs:12:7 [INFO] [stderr] | [INFO] [stderr] 12 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_id.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | token: token [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_session.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_session.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | session: session [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:254:7 [INFO] [stderr] | [INFO] [stderr] 254 | buffer_pool: buffer_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:255:7 [INFO] [stderr] | [INFO] [stderr] 255 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:256:7 [INFO] [stderr] | [INFO] [stderr] 256 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol_engine.rs:257:7 [INFO] [stderr] | [INFO] [stderr] 257 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:41:7 [INFO] [stderr] | [INFO] [stderr] 41 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec.rs:42:7 [INFO] [stderr] | [INFO] [stderr] 42 | bytes_read: bytes_read [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:39:7 [INFO] [stderr] | [INFO] [stderr] 39 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:53:15 [INFO] [stderr] | [INFO] [stderr] 53 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:124:7 [INFO] [stderr] | [INFO] [stderr] 124 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:126:7 [INFO] [stderr] | [INFO] [stderr] 126 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:128:7 [INFO] [stderr] | [INFO] [stderr] 128 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:129:7 [INFO] [stderr] | [INFO] [stderr] 129 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:174:7 [INFO] [stderr] | [INFO] [stderr] 174 | event_loop: event_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:175:7 [INFO] [stderr] | [INFO] [stderr] 175 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:176:7 [INFO] [stderr] | [INFO] [stderr] 176 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:177:7 [INFO] [stderr] | [INFO] [stderr] 177 | outbox_pool: outbox_pool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outbox_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context.rs:178:7 [INFO] [stderr] | [INFO] [stderr] 178 | command_sender: command_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/remote.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | command_sender: command_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/remote.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | receiver: receiver [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timeout.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timeout.rs:21:11 [INFO] [stderr] | [INFO] [stderr] 21 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_id.rs:12:7 [INFO] [stderr] | [INFO] [stderr] 12 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_id.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | token: token [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_session.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | efs: efs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `efs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_session.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | session: session [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evented_byte_stream.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(bytes_available); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes_available)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evented_byte_stream.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(total_bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(total_bytes_written)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evented_byte_stream.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(bytes_available); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes_available)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/evented_byte_stream.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return Ok(total_bytes_written); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(total_bytes_written)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Evented` [INFO] [stderr] --> src/protocol_engine.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | use mio::{Evented, EventSet, PollOpt, Token}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Recycleable` [INFO] [stderr] --> src/protocol_engine.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | use lifeguard::{self, Recycleable, Pool, StartingSize, MaxSize, Supplier}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/protocol_engine.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{self, Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/protocol_engine.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{self, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/evented_frame_stream.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | let mut outbox = self.outbox(outbox_pool); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol_engine.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | let mut stream_session: &mut StreamSession
= stream_session.unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol_engine.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | let (mut efs, mut session) = stream_session.components(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol_engine.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | let (mut efs, mut session) = stream_session.components(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused import: `Evented` [INFO] [stderr] --> src/protocol_engine.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | use mio::{Evented, EventSet, PollOpt, Token}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Recycleable` [INFO] [stderr] --> src/protocol_engine.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | use lifeguard::{self, Recycleable, Pool, StartingSize, MaxSize, Supplier}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/protocol_engine.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{self, Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/protocol_engine.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{self, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol_engine.rs:531:26 [INFO] [stderr] | [INFO] [stderr] 531 | let (codec, _stream, mut write_buffer, outbox) = efs.writing_toolset(buffer_pool, outbox_pool); [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/evented_frame_stream.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | let mut outbox = self.outbox(outbox_pool); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/protocol_engine.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | let mut stream_session: &mut StreamSession
= stream_session.unwrap();
[INFO] [stderr] | ----^^^^^^^^^^^^^^
[INFO] [stderr] | |
[INFO] [stderr] | help: remove this `mut`
[INFO] [stderr]
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr] --> src/protocol_engine.rs:133:22
[INFO] [stderr] |
[INFO] [stderr] 133 | let (mut efs, mut session) = stream_session.components();
[INFO] [stderr] | ----^^^^^^^
[INFO] [stderr] | |
[INFO] [stderr] | help: remove this `mut`
[INFO] [stderr]
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr] --> src/protocol_engine.rs:133:13
[INFO] [stderr] |
[INFO] [stderr] 133 | let (mut efs, mut session) = stream_session.components();
[INFO] [stderr] | ----^^^
[INFO] [stderr] | |
[INFO] [stderr] | help: remove this `mut`
[INFO] [stderr]
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr] --> src/evented_frame_stream.rs:91:5
[INFO] [stderr] |
[INFO] [stderr] 91 | / (!self.write_buffer.is_none() && self.write_buffer.as_ref().unwrap().len() > 0)
[INFO] [stderr] 92 | | // or frames waiting to be serialized and written
[INFO] [stderr] 93 | | || (!self.outbox.is_none() && self.outbox.as_ref().unwrap().len() > 0)
[INFO] [stderr] | |______________________________________________________________________________^ help: try: `self.write_buffer.is_some() && self.write_buffer.as_ref().unwrap().len() > 0 || self.outbox.is_some() && self.outbox.as_ref().unwrap().len() > 0`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr]
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr] --> src/evented_frame_stream.rs:184:3
[INFO] [stderr] |
[INFO] [stderr] 184 | / pub fn on_error(
[INFO] [stderr] 185 | | &mut self,
[INFO] [stderr] 186 | | event_loop: &mut EventLoop ,
[INFO] [stderr] ... |
[INFO] [stderr] 350 | | }
[INFO] [stderr] 351 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr] --> src/protocol_engine.rs:353:3
[INFO] [stderr] |
[INFO] [stderr] 353 | / fn read(event_loop: &mut MioEventLoop ,
[INFO] [stderr] ... |
[INFO] [stderr] 407 | | Ok(())
[INFO] [stderr] 408 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr] --> src/protocol_engine.rs:531:26
[INFO] [stderr] |
[INFO] [stderr] 531 | let (codec, _stream, mut write_buffer, outbox) = efs.writing_toolset(buffer_pool, outbox_pool);
[INFO] [stderr] | ----^^^^^^^^^^^^
[INFO] [stderr] | |
[INFO] [stderr] | help: remove this `mut`
[INFO] [stderr]
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr] --> src/protocol_engine.rs:468:3
[INFO] [stderr] |
[INFO] [stderr] 468 | / fn on_writable(event_loop: &mut MioEventLoop ,
[INFO] [stderr] ... |
[INFO] [stderr] 492 | | }
[INFO] [stderr] 493 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/protocol_engine.rs:538:11
[INFO] [stderr] |
[INFO] [stderr] 538 | while outbox.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!outbox.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/codec.rs:25:9
[INFO] [stderr] |
[INFO] [stderr] 25 | / match error.kind() {
[INFO] [stderr] 26 | | WriteZero => return EncodingError::InsufficientBuffer,
[INFO] [stderr] 27 | | _ => {}
[INFO] [stderr] 28 | | }
[INFO] [stderr] | |_________^ help: try this: `if let WriteZero = error.kind() { return EncodingError::InsufficientBuffer }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr]
[INFO] [stderr] warning: item `buffer::Buffer` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr] --> src/buffer.rs:28:1
[INFO] [stderr] |
[INFO] [stderr] 28 | / impl Buffer {
[INFO] [stderr] 29 | | pub fn new() -> Buffer {
[INFO] [stderr] 30 | | Buffer::with_capacity(DEFAULT_BUFFER_SIZE)
[INFO] [stderr] 31 | | }
[INFO] [stderr] ... |
[INFO] [stderr] 102 | | }
[INFO] [stderr] 103 | | }
[INFO] [stderr] | |_^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `buffer::Buffer`
[INFO] [stderr] --> src/buffer.rs:29:3
[INFO] [stderr] |
[INFO] [stderr] 29 | / pub fn new() -> Buffer {
[INFO] [stderr] 30 | | Buffer::with_capacity(DEFAULT_BUFFER_SIZE)
[INFO] [stderr] 31 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 6 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/evented_byte_stream.rs:18:10
[INFO] [stderr] |
[INFO] [stderr] 18 | if raw_buffer.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_buffer.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/evented_byte_stream.rs:49:10
[INFO] [stderr] |
[INFO] [stderr] 49 | if working_buffer.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `working_buffer.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr] --> src/context.rs:133:3
[INFO] [stderr] |
[INFO] [stderr] 133 | / pub fn engine<'b>(&'b mut self) -> EngineHandle<'b, P> {
[INFO] [stderr] 134 | | let Context {
[INFO] [stderr] 135 | | ref mut event_loop,
[INFO] [stderr] 136 | | ref mut command_sender,
[INFO] [stderr] ... |
[INFO] [stderr] 142 | | }
[INFO] [stderr] 143 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr]
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr] --> src/evented_frame_stream.rs:91:5
[INFO] [stderr] |
[INFO] [stderr] 91 | / (!self.write_buffer.is_none() && self.write_buffer.as_ref().unwrap().len() > 0)
[INFO] [stderr] 92 | | // or frames waiting to be serialized and written
[INFO] [stderr] 93 | | || (!self.outbox.is_none() && self.outbox.as_ref().unwrap().len() > 0)
[INFO] [stderr] | |______________________________________________________________________________^ help: try: `self.write_buffer.is_some() && self.write_buffer.as_ref().unwrap().len() > 0 || self.outbox.is_some() && self.outbox.as_ref().unwrap().len() > 0`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr]
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr] --> src/token_bucket.rs:16:32
[INFO] [stderr] |
[INFO] [stderr] 16 | self.free_tokens.pop().map(|usize_token| Index::from_usize(usize_token))
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Index::from_usize`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `stream_manager::StreamManager `
[INFO] [stderr] --> src/stream_manager.rs:16:3
[INFO] [stderr] |
[INFO] [stderr] 16 | / pub fn new() -> StreamManager {
[INFO] [stderr] 17 | | StreamManager {
[INFO] [stderr] 18 | | streams: BTreeMap::new(),
[INFO] [stderr] 19 | | token_bucket: TokenBucket::new(),
[INFO] [stderr] 20 | | }
[INFO] [stderr] 21 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 15 | impl Default for stream_manager::StreamManager {
[INFO] [stderr] 16 | fn default() -> Self {
[INFO] [stderr] 17 | Self::new()
[INFO] [stderr] 18 | }
[INFO] [stderr] 19 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr] --> src/evented_frame_stream.rs:184:3
[INFO] [stderr] |
[INFO] [stderr] 184 | / pub fn on_error(
[INFO] [stderr] 185 | | &mut self,
[INFO] [stderr] 186 | | event_loop: &mut EventLoop ,
[INFO] [stderr] ... |
[INFO] [stderr] 350 | | }
[INFO] [stderr] 351 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr] --> src/protocol_engine.rs:353:3
[INFO] [stderr] |
[INFO] [stderr] 353 | / fn read(event_loop: &mut MioEventLoop ,
[INFO] [stderr] ... |
[INFO] [stderr] 407 | | Ok(())
[INFO] [stderr] 408 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr] --> src/protocol_engine.rs:468:3
[INFO] [stderr] |
[INFO] [stderr] 468 | / fn on_writable(event_loop: &mut MioEventLoop ,
[INFO] [stderr] ... |
[INFO] [stderr] 492 | | }
[INFO] [stderr] 493 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/protocol_engine.rs:538:11
[INFO] [stderr] |
[INFO] [stderr] 538 | while outbox.len() > 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!outbox.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr] --> src/codec.rs:25:9
[INFO] [stderr] |
[INFO] [stderr] 25 | / match error.kind() {
[INFO] [stderr] 26 | | WriteZero => return EncodingError::InsufficientBuffer,
[INFO] [stderr] 27 | | _ => {}
[INFO] [stderr] 28 | | }
[INFO] [stderr] | |_________^ help: try this: `if let WriteZero = error.kind() { return EncodingError::InsufficientBuffer }`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr]
[INFO] [stderr] warning: item `buffer::Buffer` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr] --> src/buffer.rs:28:1
[INFO] [stderr] |
[INFO] [stderr] 28 | / impl Buffer {
[INFO] [stderr] 29 | | pub fn new() -> Buffer {
[INFO] [stderr] 30 | | Buffer::with_capacity(DEFAULT_BUFFER_SIZE)
[INFO] [stderr] 31 | | }
[INFO] [stderr] ... |
[INFO] [stderr] 102 | | }
[INFO] [stderr] 103 | | }
[INFO] [stderr] | |_^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr]
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `buffer::Buffer`
[INFO] [stderr] --> src/buffer.rs:29:3
[INFO] [stderr] |
[INFO] [stderr] 29 | / pub fn new() -> Buffer {
[INFO] [stderr] 30 | | Buffer::with_capacity(DEFAULT_BUFFER_SIZE)
[INFO] [stderr] 31 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 6 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/evented_byte_stream.rs:18:10
[INFO] [stderr] |
[INFO] [stderr] 18 | if raw_buffer.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_buffer.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr] --> src/evented_byte_stream.rs:49:10
[INFO] [stderr] |
[INFO] [stderr] 49 | if working_buffer.len() == 0 {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `working_buffer.is_empty()`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr]
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr] --> src/context.rs:133:3
[INFO] [stderr] |
[INFO] [stderr] 133 | / pub fn engine<'b>(&'b mut self) -> EngineHandle<'b, P> {
[INFO] [stderr] 134 | | let Context {
[INFO] [stderr] 135 | | ref mut event_loop,
[INFO] [stderr] 136 | | ref mut command_sender,
[INFO] [stderr] ... |
[INFO] [stderr] 142 | | }
[INFO] [stderr] 143 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr]
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr] --> src/token_bucket.rs:16:32
[INFO] [stderr] |
[INFO] [stderr] 16 | self.free_tokens.pop().map(|usize_token| Index::from_usize(usize_token))
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Index::from_usize`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `stream_manager::StreamManager `
[INFO] [stderr] --> src/stream_manager.rs:16:3
[INFO] [stderr] |
[INFO] [stderr] 16 | / pub fn new() -> StreamManager {
[INFO] [stderr] 17 | | StreamManager {
[INFO] [stderr] 18 | | streams: BTreeMap::new(),
[INFO] [stderr] 19 | | token_bucket: TokenBucket::new(),
[INFO] [stderr] 20 | | }
[INFO] [stderr] 21 | | }
[INFO] [stderr] | |___^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 15 | impl Default for stream_manager::StreamManager {
[INFO] [stderr] 16 | fn default() -> Self {
[INFO] [stderr] 17 | Self::new()
[INFO] [stderr] 18 | }
[INFO] [stderr] 19 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr] --> src/lib.rs:51:17
[INFO] [stderr] |
[INFO] [stderr] 51 | event_loop: EventLoop::new().ok().expect("EventLoop creation failed."),
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr]
[INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.98s
[INFO] running `"docker" "inspect" "9abcb2ec243a033378b5b942eaa2517800b427e884ca414a1337e3327b1816b9"`
[INFO] running `"docker" "rm" "-f" "9abcb2ec243a033378b5b942eaa2517800b427e884ca414a1337e3327b1816b9"`
[INFO] [stdout] 9abcb2ec243a033378b5b942eaa2517800b427e884ca414a1337e3327b1816b9