[INFO] crate maddr 0.3.1 is already in cache [INFO] extracting crate maddr 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/maddr/0.3.1 [INFO] extracting crate maddr 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maddr/0.3.1 [INFO] validating manifest of maddr-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of maddr-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing maddr-0.3.1 [INFO] finished frobbing maddr-0.3.1 [INFO] frobbed toml for maddr-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/maddr/0.3.1/Cargo.toml [INFO] started frobbing maddr-0.3.1 [INFO] finished frobbing maddr-0.3.1 [INFO] frobbed toml for maddr-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/maddr/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting maddr-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/maddr/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0d6cf220d6bfa7c1009e0f17c6d8667336677e5885b5b9fcece8d6f9692dc2e [INFO] running `"docker" "start" "-a" "a0d6cf220d6bfa7c1009e0f17c6d8667336677e5885b5b9fcece8d6f9692dc2e"` [INFO] [stderr] Checking varmint v0.1.3 [INFO] [stderr] Checking bs58 v0.2.2 [INFO] [stderr] Checking mhash v0.3.0 [INFO] [stderr] Checking maddr v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multiaddr.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/multiaddr.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/read.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | 0b10100101, 0b00000011, 34, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0101` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/read.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | 0b10100101, 0b00000011, 34, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/write.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | 0b10100101, 0b00000011, 34, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/write.rs:137:25 [INFO] [stderr] | [INFO] [stderr] 137 | 0b10100101, 0b00000011, 34, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/write.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | fn write_ipv4addr(&mut self, addr: &Ipv4Addr) -> io::Result<()>; [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/write.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | fn write_ipv4addr(&mut self, addr: &Ipv4Addr) -> io::Result<()>; [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.15s [INFO] running `"docker" "inspect" "a0d6cf220d6bfa7c1009e0f17c6d8667336677e5885b5b9fcece8d6f9692dc2e"` [INFO] running `"docker" "rm" "-f" "a0d6cf220d6bfa7c1009e0f17c6d8667336677e5885b5b9fcece8d6f9692dc2e"` [INFO] [stdout] a0d6cf220d6bfa7c1009e0f17c6d8667336677e5885b5b9fcece8d6f9692dc2e