[INFO] crate macroclassrender 0.0.2 is already in cache [INFO] extracting crate macroclassrender 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/macroclassrender/0.0.2 [INFO] extracting crate macroclassrender 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/macroclassrender/0.0.2 [INFO] validating manifest of macroclassrender-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of macroclassrender-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing macroclassrender-0.0.2 [INFO] finished frobbing macroclassrender-0.0.2 [INFO] frobbed toml for macroclassrender-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/macroclassrender/0.0.2/Cargo.toml [INFO] started frobbing macroclassrender-0.0.2 [INFO] finished frobbing macroclassrender-0.0.2 [INFO] frobbed toml for macroclassrender-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/macroclassrender/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting macroclassrender-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/macroclassrender/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5988826dd5162bdd58bd8909db619cab75ef2cc3aa22a02d994c1c5006f54635 [INFO] running `"docker" "start" "-a" "5988826dd5162bdd58bd8909db619cab75ef2cc3aa22a02d994c1c5006f54635"` [INFO] [stderr] Checking macroclassrender v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mut_getters.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const ATTRIBUTE_NAME: &'static str = "get_mut"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mut_getters.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const FN_NAME_PREFIX: &'static str = "get_mut"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mut_getters.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/getters.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const ATTRIBUTE_NAME: &'static str = "get"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/getters.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const FN_NAME_PREFIX: &'static str = "get"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/getters.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/setters.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const ATTRIBUTE_NAME: &'static str = "set"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/setters.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const FN_NAME_PREFIX: &'static str = "set"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/setters.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constructor.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const ATTRIBUTE_NAME: &'static str = "__constructor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constructor.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | const FN_NAME_PREFIX: &'static str = "__constructor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constructor.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return tmp; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return s_slice; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `s_slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(mm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return trim_parenthese(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_parenthese(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return trim_parenthese(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_parenthese(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return trim_string(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_string(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return vars; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | return Ident::from(varsname); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ident::from(varsname)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | return Ident::from(varsname); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ident::from(varsname)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | return Ident::from(varsname); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ident::from(varsname)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/functions.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const ATTRIBUTE_NAME: &'static str = "__function"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(mm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return split; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `split` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return trim_braket(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_braket(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | return split; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `split` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return split; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `split` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | return trimmed; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `trimmed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mut_getters.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const ATTRIBUTE_NAME: &'static str = "get_mut"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mut_getters.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const FN_NAME_PREFIX: &'static str = "get_mut"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/mut_getters.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/getters.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const ATTRIBUTE_NAME: &'static str = "get"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/getters.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const FN_NAME_PREFIX: &'static str = "get"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/getters.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/setters.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | const ATTRIBUTE_NAME: &'static str = "set"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/setters.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | const FN_NAME_PREFIX: &'static str = "set"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classname` [INFO] [stderr] --> src/functions.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let classname = Ident::from(impl_generics.clone()); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classname` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/setters.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constructor.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const ATTRIBUTE_NAME: &'static str = "__constructor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constructor.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | const FN_NAME_PREFIX: &'static str = "__constructor"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constructor.rs:8:24 [INFO] [stderr] | [INFO] [stderr] 8 | const FN_NAME_SUFFIX: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return tmp; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return s_slice; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `s_slice` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(mm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return trim_parenthese(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_parenthese(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | return trim_parenthese(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_parenthese(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return trim_string(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_string(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | return vars; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | return Ident::from(varsname); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ident::from(varsname)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | return Ident::from(varsname); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ident::from(varsname)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/constructor.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | return Ident::from(varsname); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ident::from(varsname)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/functions.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | const ATTRIBUTE_NAME: &'static str = "__function"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(mm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | return split; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `split` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | return String::from(s_slice); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(s_slice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return trim_braket(&split); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `trim_braket(&split)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | return split; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `split` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | return split; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `split` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/functions.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | return trimmed; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `trimmed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:10:48 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn implement(field: &Field, impl_generics: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 10 | pub fn implement(field: &Field, impl_generics: &str) -> Tokens { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `impl_generics.clone()` to [INFO] [stderr] | [INFO] [stderr] 27 | let classname = Ident::from(impl_generics.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `impl_generics.clone()` to [INFO] [stderr] | [INFO] [stderr] 30 | let top_const_var : String = get_contructor_types(&s, &impl_generics.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn add_reference_string(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn string_to_str(s : &String) -> &str { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn trim_string(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn trim_parenthese(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:98:34 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:98:48 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/constructor.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `mm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn get_fn_top(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_contructor_types(s : &String, classname : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:111:54 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_contructor_types(s : &String, classname : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn get_fn_contents(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:128:37 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn get_contructor_arguments(s : &String) -> Vec<&str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:129:40 [INFO] [stderr] | [INFO] [stderr] 129 | let mut vars : Vec<&str> = s.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:131:14 [INFO] [stderr] | [INFO] [stderr] 131 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 131 | for in &mut vars { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:132:46 [INFO] [stderr] | [INFO] [stderr] 132 | let svar : Vec<&str> = vars[i].split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | if svar[1].contains("&") { [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constructor.rs:145:45 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn get_vars_name_for_constructor(vars : &Vec<&str>) -> Ident { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 148 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/constructor.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | if varsname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!varsname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:159:50 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn get_vars_name_for_constructor_two(types : &String) -> Ident { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:161:40 [INFO] [stderr] | [INFO] [stderr] 161 | let vars : Vec<&str> = types.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 163 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:164:46 [INFO] [stderr] | [INFO] [stderr] 164 | let svar : Vec<&str> = vars[i].split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/constructor.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if varsname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!varsname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constructor.rs:194:29 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn get_vars_name(vars : &Vec<&str>) -> Ident { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:197:14 [INFO] [stderr] | [INFO] [stderr] 197 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 197 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/constructor.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | if varsname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!varsname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:8:48 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn implement(field: &Field, impl_generics: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:21:52 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn workerfun(attr : &Attribute, impl_generics: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 21 | pub fn workerfun(attr : &Attribute, impl_generics: &str) -> Tokens { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `impl_generics.clone()` to [INFO] [stderr] | [INFO] [stderr] 29 | let classname = Ident::from(impl_generics.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / let mut ref_self = String::from("&"); [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | if fn_mutable == true { [INFO] [stderr] 45 | | ref_self = String::from("&mut"); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let ref_self = if fn_mutable == true { String::from("&mut") } else { String::from("&") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | / let mut ifn_pub = Ident::from(""); [INFO] [stderr] 68 | | [INFO] [stderr] 69 | | if fn_pub == true { [INFO] [stderr] 70 | | ifn_pub = Ident::from("pub"); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let ifn_pub = if fn_pub == true { Ident::from("pub") } else { Ident::from("") };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if fn_mutable == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `fn_mutable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | if fn_pub == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `fn_pub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:94:34 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:94:48 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/functions.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `mm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn get_fn_top(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn trim_braket(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn trim_parenthese(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:125:28 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn get_fn_contents(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:126:42 [INFO] [stderr] | [INFO] [stderr] 126 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn is_fn_public(s : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:133:42 [INFO] [stderr] | [INFO] [stderr] 133 | let split1 : Vec<&str> = s.splitn(3, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:142:26 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn is_fn_mutable(s : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:143:42 [INFO] [stderr] | [INFO] [stderr] 143 | let split1 : Vec<&str> = s.splitn(3, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn get_fn_type(s : &String, ispub : bool, ismut : bool) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / let mut index = 0; [INFO] [stderr] 155 | | [INFO] [stderr] 156 | | if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { [INFO] [stderr] 157 | | index = 1; [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let index = if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:153:42 [INFO] [stderr] | [INFO] [stderr] 153 | let split1 : Vec<&str> = s.splitn(4, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:156:8 [INFO] [stderr] | [INFO] [stderr] 156 | if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:162:8 [INFO] [stderr] | [INFO] [stderr] 162 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn get_fn_name(s : &String, ispub : bool, ismut : bool) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / let mut index = 1; [INFO] [stderr] 175 | | [INFO] [stderr] 176 | | if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { [INFO] [stderr] 177 | | index = 2; [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let index = if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { 2 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:171:42 [INFO] [stderr] | [INFO] [stderr] 171 | let split0 : Vec<&str> = s.splitn(3, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:172:38 [INFO] [stderr] | [INFO] [stderr] 172 | let split1 : Vec<&str> = s.split("(").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:173:50 [INFO] [stderr] | [INFO] [stderr] 173 | let split2 : Vec<&str> = split1[0].splitn(5, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:176:8 [INFO] [stderr] | [INFO] [stderr] 176 | if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:182:8 [INFO] [stderr] | [INFO] [stderr] 182 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:190:29 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn get_fn_arguments(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:191:38 [INFO] [stderr] | [INFO] [stderr] 191 | let split1 : Vec<&str> = s.split("(").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `classname` [INFO] [stderr] --> src/functions.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let classname = Ident::from(impl_generics.clone()); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_classname` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:10:48 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn implement(field: &Field, impl_generics: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 10 | pub fn implement(field: &Field, impl_generics: &str) -> Tokens { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `impl_generics.clone()` to [INFO] [stderr] | [INFO] [stderr] 27 | let classname = Ident::from(impl_generics.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `impl_generics.clone()` to [INFO] [stderr] | [INFO] [stderr] 30 | let top_const_var : String = get_contructor_types(&s, &impl_generics.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn add_reference_string(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn string_to_str(s : &String) -> &str { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn trim_string(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:89:28 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn trim_parenthese(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:98:34 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:98:48 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/constructor.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `mm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:103:23 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn get_fn_top(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_contructor_types(s : &String, classname : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:111:54 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_contructor_types(s : &String, classname : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:112:42 [INFO] [stderr] | [INFO] [stderr] 112 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:121:28 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn get_fn_contents(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:128:37 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn get_contructor_arguments(s : &String) -> Vec<&str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:129:40 [INFO] [stderr] | [INFO] [stderr] 129 | let mut vars : Vec<&str> = s.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:131:14 [INFO] [stderr] | [INFO] [stderr] 131 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 131 | for in &mut vars { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:132:46 [INFO] [stderr] | [INFO] [stderr] 132 | let svar : Vec<&str> = vars[i].split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | if svar[1].contains("&") { [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constructor.rs:145:45 [INFO] [stderr] | [INFO] [stderr] 145 | pub fn get_vars_name_for_constructor(vars : &Vec<&str>) -> Ident { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:148:14 [INFO] [stderr] | [INFO] [stderr] 148 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 148 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/constructor.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | if varsname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!varsname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/constructor.rs:159:50 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn get_vars_name_for_constructor_two(types : &String) -> Ident { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:161:40 [INFO] [stderr] | [INFO] [stderr] 161 | let vars : Vec<&str> = types.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 163 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/constructor.rs:164:46 [INFO] [stderr] | [INFO] [stderr] 164 | let svar : Vec<&str> = vars[i].split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/constructor.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if varsname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!varsname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constructor.rs:194:29 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn get_vars_name(vars : &Vec<&str>) -> Ident { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vars`. [INFO] [stderr] --> src/constructor.rs:197:14 [INFO] [stderr] | [INFO] [stderr] 197 | for i in 0..vars.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 197 | for in &vars { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/constructor.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | if varsname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!varsname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:8:48 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn implement(field: &Field, impl_generics: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:21:52 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn workerfun(attr : &Attribute, impl_generics: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 21 | pub fn workerfun(attr : &Attribute, impl_generics: &str) -> Tokens { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `impl_generics.clone()` to [INFO] [stderr] | [INFO] [stderr] 29 | let classname = Ident::from(impl_generics.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / let mut ref_self = String::from("&"); [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | if fn_mutable == true { [INFO] [stderr] 45 | | ref_self = String::from("&mut"); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let ref_self = if fn_mutable == true { String::from("&mut") } else { String::from("&") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | / let mut ifn_pub = Ident::from(""); [INFO] [stderr] 68 | | [INFO] [stderr] 69 | | if fn_pub == true { [INFO] [stderr] 70 | | ifn_pub = Ident::from("pub"); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let ifn_pub = if fn_pub == true { Ident::from("pub") } else { Ident::from("") };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if fn_mutable == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `fn_mutable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | if fn_pub == true { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `fn_pub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:94:20 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:94:34 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:94:48 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn replace(s : &String, s1 : &String, s2 : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/functions.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | return String::from(mm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `mm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:99:23 [INFO] [stderr] | [INFO] [stderr] 99 | pub fn get_fn_top(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn trim_braket(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn trim_parenthese(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:125:28 [INFO] [stderr] | [INFO] [stderr] 125 | pub fn get_fn_contents(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:126:42 [INFO] [stderr] | [INFO] [stderr] 126 | let split1 : Vec<&str> = s.splitn(2, "{").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:132:25 [INFO] [stderr] | [INFO] [stderr] 132 | pub fn is_fn_public(s : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:133:42 [INFO] [stderr] | [INFO] [stderr] 133 | let split1 : Vec<&str> = s.splitn(3, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:142:26 [INFO] [stderr] | [INFO] [stderr] 142 | pub fn is_fn_mutable(s : &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:143:42 [INFO] [stderr] | [INFO] [stderr] 143 | let split1 : Vec<&str> = s.splitn(3, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn get_fn_type(s : &String, ispub : bool, ismut : bool) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / let mut index = 0; [INFO] [stderr] 155 | | [INFO] [stderr] 156 | | if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { [INFO] [stderr] 157 | | index = 1; [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let index = if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:153:42 [INFO] [stderr] | [INFO] [stderr] 153 | let split1 : Vec<&str> = s.splitn(4, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:156:8 [INFO] [stderr] | [INFO] [stderr] 156 | if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | if ispub == true || ismut == true || split1[0] == "private" || split1[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:162:8 [INFO] [stderr] | [INFO] [stderr] 162 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn get_fn_name(s : &String, ispub : bool, ismut : bool) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/functions.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | / let mut index = 1; [INFO] [stderr] 175 | | [INFO] [stderr] 176 | | if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { [INFO] [stderr] 177 | | index = 2; [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let index = if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { 2 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:171:42 [INFO] [stderr] | [INFO] [stderr] 171 | let split0 : Vec<&str> = s.splitn(3, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:172:38 [INFO] [stderr] | [INFO] [stderr] 172 | let split1 : Vec<&str> = s.split("(").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:173:50 [INFO] [stderr] | [INFO] [stderr] 173 | let split2 : Vec<&str> = split1[0].splitn(5, " ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:176:8 [INFO] [stderr] | [INFO] [stderr] 176 | if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | if ispub == true || ismut == true || split0[0] == "private" || split0[0] == "local" { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:182:8 [INFO] [stderr] | [INFO] [stderr] 182 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ispub` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/functions.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | if ispub == true && ismut == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `ismut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/functions.rs:190:29 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn get_fn_arguments(s : &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/functions.rs:191:38 [INFO] [stderr] | [INFO] [stderr] 191 | let split1 : Vec<&str> = s.split("(").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.25s [INFO] running `"docker" "inspect" "5988826dd5162bdd58bd8909db619cab75ef2cc3aa22a02d994c1c5006f54635"` [INFO] running `"docker" "rm" "-f" "5988826dd5162bdd58bd8909db619cab75ef2cc3aa22a02d994c1c5006f54635"` [INFO] [stdout] 5988826dd5162bdd58bd8909db619cab75ef2cc3aa22a02d994c1c5006f54635