[INFO] crate machine 0.1.0 is already in cache [INFO] extracting crate machine 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/machine/0.1.0 [INFO] extracting crate machine 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/machine/0.1.0 [INFO] validating manifest of machine-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of machine-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing machine-0.1.0 [INFO] finished frobbing machine-0.1.0 [INFO] frobbed toml for machine-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/machine/0.1.0/Cargo.toml [INFO] started frobbing machine-0.1.0 [INFO] finished frobbing machine-0.1.0 [INFO] frobbed toml for machine-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/machine/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting machine-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/machine/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f05ae80adb85e9ba56b2e027ef852013bd38eff473bdde80b9295dbf736691f4 [INFO] running `"docker" "start" "-a" "f05ae80adb85e9ba56b2e027ef852013bd38eff473bdde80b9295dbf736691f4"` [INFO] [stderr] Checking machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/prototype.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / return Machine { [INFO] [stderr] 40 | | state: SB { b: 1 }, [INFO] [stderr] 41 | | counter: self.counter [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | Machine { [INFO] [stderr] 40 | state: SB { b: 1 }, [INFO] [stderr] 41 | counter: self.counter [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/prototype.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / return Machine { [INFO] [stderr] 50 | | state: SC, [INFO] [stderr] 51 | | counter: 0 [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | Machine { [INFO] [stderr] 50 | state: SC, [INFO] [stderr] 51 | counter: 0 [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/prototype.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / return Machine { [INFO] [stderr] 59 | | state: SA, [INFO] [stderr] 60 | | counter: 0 [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Machine { [INFO] [stderr] 59 | state: SA, [INFO] [stderr] 60 | counter: 0 [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/prototype.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / return Machine { [INFO] [stderr] 69 | | state: SA, [INFO] [stderr] 70 | | counter: 0 [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 68 | Machine { [INFO] [stderr] 69 | state: SA, [INFO] [stderr] 70 | counter: 0 [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> tests/traffic_light.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | self.cars = self.cars + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cars += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.04s [INFO] running `"docker" "inspect" "f05ae80adb85e9ba56b2e027ef852013bd38eff473bdde80b9295dbf736691f4"` [INFO] running `"docker" "rm" "-f" "f05ae80adb85e9ba56b2e027ef852013bd38eff473bdde80b9295dbf736691f4"` [INFO] [stdout] f05ae80adb85e9ba56b2e027ef852013bd38eff473bdde80b9295dbf736691f4