[INFO] crate machina 0.6.1 is already in cache
[INFO] extracting crate machina 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/machina/0.6.1
[INFO] extracting crate machina 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/machina/0.6.1
[INFO] validating manifest of machina-0.6.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of machina-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing machina-0.6.1
[INFO] finished frobbing machina-0.6.1
[INFO] frobbed toml for machina-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/machina/0.6.1/Cargo.toml
[INFO] started frobbing machina-0.6.1
[INFO] finished frobbing machina-0.6.1
[INFO] frobbed toml for machina-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/machina/0.6.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting machina-0.6.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/machina/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 009586d9c1d76fc6d20acde27a565ef2ff5b01aee08e7ed562f5001bcb5b62c1
[INFO] running `"docker" "start" "-a" "009586d9c1d76fc6d20acde27a565ef2ff5b01aee08e7ed562f5001bcb5b62c1"`
[INFO] [stderr]     Checking sam v0.2.0
[INFO] [stderr]     Checking aligned_alloc v0.1.3
[INFO] [stderr]     Checking region v0.1.1
[INFO] [stderr]     Checking machina v0.6.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cache.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             asm: asm,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `asm`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cache.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             asm: asm,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `asm`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cache.rs:86:13
[INFO] [stderr]    |
[INFO] [stderr] 86 |             asm: asm,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `asm`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cache.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             asm: asm,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `asm`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/memory.rs:159:28
[INFO] [stderr]     |
[INFO] [stderr] 159 |         self.emit32((asm & 0xFFFFFFFF) as u32);
[INFO] [stderr]     |                            ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/memory.rs:160:36
[INFO] [stderr]     |
[INFO] [stderr] 160 |         self.emit32(((asm >> 32) & 0xFFFFFFFF) as u32);
[INFO] [stderr]     |                                    ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/cache.rs:9:25
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const STUB: usize = 0x13371337;
[INFO] [stderr]   |                         ^^^^^^^^^^ help: consider: `0x1337_1337`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer to a pointer
[INFO] [stderr]   --> src/memory.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |             memory = mem::transmute(ptr);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *mut u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `self`.
[INFO] [stderr]   --> src/memory.rs:69:18
[INFO] [stderr]    |
[INFO] [stderr] 69 |         for i in 0..self.memory_size {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 69 |         for <item> in self.iter_mut().take(self.memory_size) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/memory.rs:187:20
[INFO] [stderr]     |
[INFO] [stderr] 187 |         unsafe { &*self.memory.offset(_index as isize) }
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.add(_index)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/memory.rs:193:24
[INFO] [stderr]     |
[INFO] [stderr] 193 |         unsafe { &mut *self.memory.offset(_index as isize) }
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.add(_index)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::Cache`
[INFO] [stderr]   --> src/cache.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn new() -> Cache {
[INFO] [stderr] 49 | |         Cache {
[INFO] [stderr] 50 | |             stub: STUB,
[INFO] [stderr] 51 | |             cache: HashMap::<String, Entry>::new(),
[INFO] [stderr] 52 | |         }
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 |         self.cache.get(&name).unwrap().asm.to_owned()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.cache[&name]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:175:23
[INFO] [stderr]     |
[INFO] [stderr] 175 |         let mut asm = self.cache.get(&name).unwrap().asm.to_owned();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.cache[&name]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `-`
[INFO] [stderr]    --> src/cache.rs:179:62
[INFO] [stderr]     |
[INFO] [stderr] 179 |             asm[pos..pos + 4].clone_from_slice(&actual_bytes[(pos - pos)..(pos + 4 - pos)]);
[INFO] [stderr]     |                                                              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]  --> src/optimized_cache.rs:1:10
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[derive(Hash)]
[INFO] [stderr]   |          ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]  --> src/optimized_cache.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | / impl PartialEq for OptimizedCache {
[INFO] [stderr] 10| |     fn eq(&self, other: &OptimizedCache) -> bool {
[INFO] [stderr] 11| |         self.name == other.name && self.value == other.value
[INFO] [stderr] 12| |     }
[INFO] [stderr] 13| | }
[INFO] [stderr]   | |_^
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `machina`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/memory.rs:159:28
[INFO] [stderr]     |
[INFO] [stderr] 159 |         self.emit32((asm & 0xFFFFFFFF) as u32);
[INFO] [stderr]     |                            ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/memory.rs:160:36
[INFO] [stderr]     |
[INFO] [stderr] 160 |         self.emit32(((asm >> 32) & 0xFFFFFFFF) as u32);
[INFO] [stderr]     |                                    ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> src/cache.rs:9:25
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub const STUB: usize = 0x13371337;
[INFO] [stderr]   |                         ^^^^^^^^^^ help: consider: `0x1337_1337`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: transmute from a pointer to a pointer
[INFO] [stderr]   --> src/memory.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |             memory = mem::transmute(ptr);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *mut u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `self`.
[INFO] [stderr]   --> src/memory.rs:69:18
[INFO] [stderr]    |
[INFO] [stderr] 69 |         for i in 0..self.memory_size {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 69 |         for <item> in self.iter_mut().take(self.memory_size) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/memory.rs:187:20
[INFO] [stderr]     |
[INFO] [stderr] 187 |         unsafe { &*self.memory.offset(_index as isize) }
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.add(_index)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_offset_with_cast)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stderr]    --> src/memory.rs:193:24
[INFO] [stderr]     |
[INFO] [stderr] 193 |         unsafe { &mut *self.memory.offset(_index as isize) }
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.add(_index)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::Cache`
[INFO] [stderr]   --> src/cache.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 | /     pub fn new() -> Cache {
[INFO] [stderr] 49 | |         Cache {
[INFO] [stderr] 50 | |             stub: STUB,
[INFO] [stderr] 51 | |             cache: HashMap::<String, Entry>::new(),
[INFO] [stderr] 52 | |         }
[INFO] [stderr] 53 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 |         self.cache.get(&name).unwrap().asm.to_owned()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.cache[&name]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/cache.rs:175:23
[INFO] [stderr]     |
[INFO] [stderr] 175 |         let mut asm = self.cache.get(&name).unwrap().asm.to_owned();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.cache[&name]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `-`
[INFO] [stderr]    --> src/cache.rs:179:62
[INFO] [stderr]     |
[INFO] [stderr] 179 |             asm[pos..pos + 4].clone_from_slice(&actual_bytes[(pos - pos)..(pos + 4 - pos)]);
[INFO] [stderr]     |                                                              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]  --> src/optimized_cache.rs:1:10
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[derive(Hash)]
[INFO] [stderr]   |          ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]  --> src/optimized_cache.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | / impl PartialEq for OptimizedCache {
[INFO] [stderr] 10| |     fn eq(&self, other: &OptimizedCache) -> bool {
[INFO] [stderr] 11| |         self.name == other.name && self.value == other.value
[INFO] [stderr] 12| |     }
[INFO] [stderr] 13| | }
[INFO] [stderr]   | |_^
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `machina`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "009586d9c1d76fc6d20acde27a565ef2ff5b01aee08e7ed562f5001bcb5b62c1"`
[INFO] running `"docker" "rm" "-f" "009586d9c1d76fc6d20acde27a565ef2ff5b01aee08e7ed562f5001bcb5b62c1"`
[INFO] [stdout] 009586d9c1d76fc6d20acde27a565ef2ff5b01aee08e7ed562f5001bcb5b62c1