[INFO] crate lzw 0.10.0 is already in cache [INFO] extracting crate lzw 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/lzw/0.10.0 [INFO] extracting crate lzw 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzw/0.10.0 [INFO] validating manifest of lzw-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lzw-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lzw-0.10.0 [INFO] finished frobbing lzw-0.10.0 [INFO] frobbed toml for lzw-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/lzw/0.10.0/Cargo.toml [INFO] started frobbing lzw-0.10.0 [INFO] finished frobbing lzw-0.10.0 [INFO] frobbed toml for lzw-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzw/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lzw-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lzw/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ebeb4a95bf3aa477cf9e687e0c272dff6ad1b78afc8142bc69bfebe67d07cc7b [INFO] running `"docker" "start" "-a" "ebeb4a95bf3aa477cf9e687e0c272dff6ad1b78afc8142bc69bfebe67d07cc7b"` [INFO] [stderr] Checking lzw v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | c: c, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | min_size: min_size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | min_code_size: min_code_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_code_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | code_size: code_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | min_size: min_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | c: c, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | min_size: min_size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `min_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | dict: dict, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | min_code_size: min_code_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_code_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lzw.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | code_size: code_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `code_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lzw.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | data [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lzw.rs:180:36 [INFO] [stderr] | [INFO] [stderr] 180 | let data = if code == next_code { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 181 | | let cha = try!(self.table.reconstruct(prev))[0]; [INFO] [stderr] 182 | | self.table.push(prev, cha); [INFO] [stderr] 183 | | try!(self.table.reconstruct(Some(code))) [INFO] [stderr] ... | [INFO] [stderr] 190 | | unreachable!() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lzw.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | data [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lzw.rs:180:36 [INFO] [stderr] | [INFO] [stderr] 180 | let data = if code == next_code { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 181 | | let cha = try!(self.table.reconstruct(prev))[0]; [INFO] [stderr] 182 | | self.table.push(prev, cha); [INFO] [stderr] 183 | | try!(self.table.reconstruct(Some(code))) [INFO] [stderr] ... | [INFO] [stderr] 190 | | unreachable!() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lzw.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | data [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lzw.rs:180:36 [INFO] [stderr] | [INFO] [stderr] 180 | let data = if code == next_code { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 181 | | let cha = try!(self.table.reconstruct(prev))[0]; [INFO] [stderr] 182 | | self.table.push(prev, cha); [INFO] [stderr] 183 | | try!(self.table.reconstruct(Some(code))) [INFO] [stderr] ... | [INFO] [stderr] 190 | | unreachable!() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lzw.rs:192:25 [INFO] [stderr] | [INFO] [stderr] 192 | data [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lzw.rs:180:36 [INFO] [stderr] | [INFO] [stderr] 180 | let data = if code == next_code { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 181 | | let cha = try!(self.table.reconstruct(prev))[0]; [INFO] [stderr] 182 | | self.table.push(prev, cha); [INFO] [stderr] 183 | | try!(self.table.reconstruct(Some(code))) [INFO] [stderr] ... | [INFO] [stderr] 190 | | unreachable!() [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] ... [INFO] [stderr] 214 | / define_decoder_struct!{ [INFO] [stderr] 215 | | Decoder, 0, #[doc = "Decoder for a LZW compressed stream (this algorithm is used for GIF files)."]; [INFO] [stderr] 216 | | DecoderEarlyChange, 1, #[doc = "Decoder for a LZW compressed stream using an “early change” algorithm (used in TIFF files)."]; [INFO] [stderr] 217 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/lzw.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:308:39 [INFO] [stderr] | [INFO] [stderr] 308 | Some(self.search_initials(c as Code)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | self.table[i as usize].c as Code [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.table[i as usize].c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:339:43 [INFO] [stderr] | [INFO] [stderr] 339 | i = Some(dict.search_initials(c as Code)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:411:48 [INFO] [stderr] | [INFO] [stderr] 411 | *i = Some(dict.search_initials(c as Code)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bitstream::LsbReader` [INFO] [stderr] --> src/bitstream.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> $name { [INFO] [stderr] 44 | | $name { [INFO] [stderr] 45 | | bits: 0, [INFO] [stderr] 46 | | acc: 0, [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 58 | / define_bit_readers!{ [INFO] [stderr] 59 | | LsbReader, #[doc = "Reads bits from a byte stream, LSB first."]; [INFO] [stderr] 60 | | MsbReader, #[doc = "Reads bits from a byte stream, MSB first."]; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bitstream::MsbReader` [INFO] [stderr] --> src/bitstream.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> $name { [INFO] [stderr] 44 | | $name { [INFO] [stderr] 45 | | bits: 0, [INFO] [stderr] 46 | | acc: 0, [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 58 | / define_bit_readers!{ [INFO] [stderr] 59 | | LsbReader, #[doc = "Reads bits from a byte stream, LSB first."]; [INFO] [stderr] 60 | | MsbReader, #[doc = "Reads bits from a byte stream, MSB first."]; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bitstream.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | self.acc |= (byte as u32) << self.bits; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bitstream.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | let byte = if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | self.acc |= (byte as u32) << (24 - self.bits); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | try!(self.write_bits(byte as u16, 8)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 174 | / define_bit_writers!{ [INFO] [stderr] 175 | | LsbWriter, #[doc = "Writes bits to a byte stream, LSB first."]; [INFO] [stderr] 176 | | MsbWriter, #[doc = "Writes bits to a byte stream, MSB first."]; [INFO] [stderr] 177 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | self.acc |= (v as u32) << self.bits; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | self.acc |= (v as u32) << (32 - n - self.bits); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/lzw.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:308:39 [INFO] [stderr] | [INFO] [stderr] 308 | Some(self.search_initials(c as Code)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | self.table[i as usize].c as Code [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.table[i as usize].c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:339:43 [INFO] [stderr] | [INFO] [stderr] 339 | i = Some(dict.search_initials(c as Code)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lzw.rs:411:48 [INFO] [stderr] | [INFO] [stderr] 411 | *i = Some(dict.search_initials(c as Code)) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lzw.rs:475:11 [INFO] [stderr] | [INFO] [stderr] 475 | while compressed.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!compressed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lzw.rs:478:22 [INFO] [stderr] | [INFO] [stderr] 478 | data2.extend(bytes.iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bitstream::LsbReader` [INFO] [stderr] --> src/bitstream.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> $name { [INFO] [stderr] 44 | | $name { [INFO] [stderr] 45 | | bits: 0, [INFO] [stderr] 46 | | acc: 0, [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 58 | / define_bit_readers!{ [INFO] [stderr] 59 | | LsbReader, #[doc = "Reads bits from a byte stream, LSB first."]; [INFO] [stderr] 60 | | MsbReader, #[doc = "Reads bits from a byte stream, MSB first."]; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bitstream::MsbReader` [INFO] [stderr] --> src/bitstream.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new() -> $name { [INFO] [stderr] 44 | | $name { [INFO] [stderr] 45 | | bits: 0, [INFO] [stderr] 46 | | acc: 0, [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 58 | / define_bit_readers!{ [INFO] [stderr] 59 | | LsbReader, #[doc = "Reads bits from a byte stream, LSB first."]; [INFO] [stderr] 60 | | MsbReader, #[doc = "Reads bits from a byte stream, MSB first."]; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bitstream.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | let byte = if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | self.acc |= (byte as u32) << self.bits; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bitstream.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | let byte = if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | self.acc |= (byte as u32) << (24 - self.bits); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:154:38 [INFO] [stderr] | [INFO] [stderr] 154 | try!(self.write_bits(byte as u16, 8)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 174 | / define_bit_writers!{ [INFO] [stderr] 175 | | LsbWriter, #[doc = "Writes bits to a byte stream, LSB first."]; [INFO] [stderr] 176 | | MsbWriter, #[doc = "Writes bits to a byte stream, MSB first."]; [INFO] [stderr] 177 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | self.acc |= (v as u32) << self.bits; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bitstream.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | self.acc |= (v as u32) << (32 - n - self.bits); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/lzw-decompress.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "ebeb4a95bf3aa477cf9e687e0c272dff6ad1b78afc8142bc69bfebe67d07cc7b"` [INFO] running `"docker" "rm" "-f" "ebeb4a95bf3aa477cf9e687e0c272dff6ad1b78afc8142bc69bfebe67d07cc7b"` [INFO] [stdout] ebeb4a95bf3aa477cf9e687e0c272dff6ad1b78afc8142bc69bfebe67d07cc7b