[INFO] crate lzma-rs 0.1.0 is already in cache [INFO] extracting crate lzma-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/lzma-rs/0.1.0 [INFO] extracting crate lzma-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzma-rs/0.1.0 [INFO] validating manifest of lzma-rs-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lzma-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lzma-rs-0.1.0 [INFO] finished frobbing lzma-rs-0.1.0 [INFO] frobbed toml for lzma-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/lzma-rs/0.1.0/Cargo.toml [INFO] started frobbing lzma-rs-0.1.0 [INFO] finished frobbing lzma-rs-0.1.0 [INFO] frobbed toml for lzma-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lzma-rs/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lzma-rs-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lzma-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 223e7ead529382288f66fb44efc9d4f8849ec98382956265480968c9e95b6def [INFO] running `"docker" "start" "-a" "223e7ead529382288f66fb44efc9d4f8849ec98382956265480968c9e95b6def"` [INFO] [stderr] Checking lzma-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode/rangecoder.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode/util.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | write: write, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | lc: lc, [INFO] [stderr] | ^^^^^^ help: replace it with: `lc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | lp: lp, [INFO] [stderr] | ^^^^^^ help: replace it with: `lp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | pb: pb, [INFO] [stderr] | ^^^^^^ help: replace it with: `pb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | dict_size: dict_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dict_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | unpacked_size: unpacked_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unpacked_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | lc: lc, [INFO] [stderr] | ^^^^^^ help: replace it with: `lc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | lp: lp, [INFO] [stderr] | ^^^^^^ help: replace it with: `lp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | pb: pb, [INFO] [stderr] | ^^^^^^ help: replace it with: `pb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | unpacked_size: unpacked_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unpacked_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzbuffer.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzbuffer.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzbuffer.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | dict_size: dict_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dict_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/rangecoder.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/rangecoder.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | num_bits: num_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/util.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/util.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/util.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode/rangecoder.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode/util.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | write: write, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | lc: lc, [INFO] [stderr] | ^^^^^^ help: replace it with: `lc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | lp: lp, [INFO] [stderr] | ^^^^^^ help: replace it with: `lp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | pb: pb, [INFO] [stderr] | ^^^^^^ help: replace it with: `pb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | dict_size: dict_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dict_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | unpacked_size: unpacked_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unpacked_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | lc: lc, [INFO] [stderr] | ^^^^^^ help: replace it with: `lc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | lp: lp, [INFO] [stderr] | ^^^^^^ help: replace it with: `lp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | pb: pb, [INFO] [stderr] | ^^^^^^ help: replace it with: `pb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzma.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | unpacked_size: unpacked_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unpacked_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzbuffer.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzbuffer.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/lzbuffer.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | dict_size: dict_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dict_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/rangecoder.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/rangecoder.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | num_bits: num_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/util.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/util.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | read: read, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/util.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/dumbencoder.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | let dict_size = 0x800000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/rangecoder.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | while self.range < 0x1000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decode/lzma.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 235 | | if self.state < 10 { [INFO] [stderr] 236 | | self.state - 3 [INFO] [stderr] 237 | | } else { [INFO] [stderr] 238 | | self.state - 6 [INFO] [stderr] 239 | | } [INFO] [stderr] 240 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 234 | } else if self.state < 10 { [INFO] [stderr] 235 | self.state - 3 [INFO] [stderr] 236 | } else { [INFO] [stderr] 237 | self.state - 6 [INFO] [stderr] 238 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decode/lzma.rs:267:28 [INFO] [stderr] | [INFO] [stderr] 267 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 268 | | if !rangecoder.decode_bit(&mut self.is_rep_g2[self.state])? { [INFO] [stderr] 269 | | idx = 2; [INFO] [stderr] 270 | | } else { [INFO] [stderr] 271 | | idx = 3; [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | } else if !rangecoder.decode_bit(&mut self.is_rep_g2[self.state])? { [INFO] [stderr] 268 | idx = 2; [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | idx = 3; [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/rangecoder.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | if self.range < 0x1000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decode/rangecoder.rs:189:16 [INFO] [stderr] | [INFO] [stderr] 189 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 190 | | if !rangecoder.decode_bit(&mut self.choice2)? { [INFO] [stderr] 191 | | Ok(self.mid_coder[pos_state].parse(rangecoder)? as usize + 8) [INFO] [stderr] 192 | | } else { [INFO] [stderr] 193 | | Ok(self.high_coder.parse(rangecoder)? as usize + 16) [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 189 | } else if !rangecoder.decode_bit(&mut self.choice2)? { [INFO] [stderr] 190 | Ok(self.mid_coder[pos_state].parse(rangecoder)? as usize + 8) [INFO] [stderr] 191 | } else { [INFO] [stderr] 192 | Ok(self.high_coder.parse(rangecoder)? as usize + 16) [INFO] [stderr] 193 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/dumbencoder.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | let dict_size = 0x800000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/rangecoder.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | while self.range < 0x1000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decode/lzma.rs:234:24 [INFO] [stderr] | [INFO] [stderr] 234 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 235 | | if self.state < 10 { [INFO] [stderr] 236 | | self.state - 3 [INFO] [stderr] 237 | | } else { [INFO] [stderr] 238 | | self.state - 6 [INFO] [stderr] 239 | | } [INFO] [stderr] 240 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 234 | } else if self.state < 10 { [INFO] [stderr] 235 | self.state - 3 [INFO] [stderr] 236 | } else { [INFO] [stderr] 237 | self.state - 6 [INFO] [stderr] 238 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decode/lzma.rs:267:28 [INFO] [stderr] | [INFO] [stderr] 267 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 268 | | if !rangecoder.decode_bit(&mut self.is_rep_g2[self.state])? { [INFO] [stderr] 269 | | idx = 2; [INFO] [stderr] 270 | | } else { [INFO] [stderr] 271 | | idx = 3; [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | } else if !rangecoder.decode_bit(&mut self.is_rep_g2[self.state])? { [INFO] [stderr] 268 | idx = 2; [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | idx = 3; [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decode/rangecoder.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | if self.range < 0x1000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decode/rangecoder.rs:189:16 [INFO] [stderr] | [INFO] [stderr] 189 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 190 | | if !rangecoder.decode_bit(&mut self.choice2)? { [INFO] [stderr] 191 | | Ok(self.mid_coder[pos_state].parse(rangecoder)? as usize + 8) [INFO] [stderr] 192 | | } else { [INFO] [stderr] 193 | | Ok(self.high_coder.parse(rangecoder)? as usize + 16) [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 189 | } else if !rangecoder.decode_bit(&mut self.choice2)? { [INFO] [stderr] 190 | Ok(self.mid_coder[pos_state].parse(rangecoder)? as usize + 8) [INFO] [stderr] 191 | } else { [INFO] [stderr] 192 | Ok(self.high_coder.parse(rangecoder)? as usize + 16) [INFO] [stderr] 193 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode/xz.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | digested.write(&padding)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode/xz.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | output.write(padding.as_slice())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode/xz.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | digested.write(padding.as_slice())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encode/rangecoder.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | let bound: u32 = (self.range >> 11) * (*prob as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*prob)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode/rangecoder.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | self.low += bound as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(bound)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/lzma.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | let mut pb = props as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(props)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/decode/lzma.rs:214:20 [INFO] [stderr] | [INFO] [stderr] 214 | if let Some(_) = self.unpacked_size { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 215 | | if rangecoder.is_finished_ok()? { [INFO] [stderr] 216 | | break; [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____________- help: try this: `if self.unpacked_size.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode/lzma2.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | let unpacked_size = ((((status & 0x1F) as u64) << 16) | (unpacked_size as u64)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(status & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode/lzma2.rs:93:61 [INFO] [stderr] | [INFO] [stderr] 93 | let unpacked_size = ((((status & 0x1F) as u64) << 16) | (unpacked_size as u64)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unpacked_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/lzma2.rs:127:18 [INFO] [stderr] | [INFO] [stderr] 127 | pb = props as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(props)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode/xz.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | digested.write(&padding)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode/xz.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | output.write(padding.as_slice())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | format!("Unexpected data after last XZ block"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unexpected data after last XZ block".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/decode/xz.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | records: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Record]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/encode/xz.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | digested.write(padding.as_slice())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | format!("Invalid index padding, must be null bytes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid index padding, must be null bytes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encode/rangecoder.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | let bound: u32 = (self.range >> 11) * (*prob as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*prob)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode/rangecoder.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | self.low += bound as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(bound)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode/xz.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | let header_size = ((header_size as u64) << 2) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/lzma.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | let mut pb = props as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(props)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | format!("Invalid block padding, must be null bytes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid block padding, must be null bytes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/decode/lzma.rs:214:20 [INFO] [stderr] | [INFO] [stderr] 214 | if let Some(_) = self.unpacked_size { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 215 | | if rangecoder.is_finished_ok()? { [INFO] [stderr] 216 | | break; [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____________- help: try this: `if self.unpacked_size.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | format!("Invalid block header padding, must be null bytes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid block header padding, must be null bytes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode/xz.rs:502:19 [INFO] [stderr] | [INFO] [stderr] 502 | result ^= ((byte & 0x7F) as u64) << (i * 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:509:9 [INFO] [stderr] | [INFO] [stderr] 509 | format!("Invalid multi-byte encoding"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid multi-byte encoding".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/decode/rangecoder.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn is_finished_ok(&mut self) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/rangecoder.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | self.code = (self.code << 8) ^ (self.stream.read_u8()? as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.stream.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] [INFO] [stderr] --> src/decode/lzma2.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | let unpacked_size = ((((status & 0x1F) as u64) << 16) | (unpacked_size as u64)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(status & 0x1F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode/lzma2.rs:93:61 [INFO] [stderr] | [INFO] [stderr] 93 | let unpacked_size = ((((status & 0x1F) as u64) << 16) | (unpacked_size as u64)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unpacked_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/lzma2.rs:127:18 [INFO] [stderr] | [INFO] [stderr] 127 | pb = props as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(props)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/rangecoder.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | let bound: u32 = (self.range >> 11) * (*prob as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*prob)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decode/util.rs:12:8 [INFO] [stderr] | [INFO] [stderr] 12 | Ok(buf.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | format!("Unexpected data after last XZ block"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unexpected data after last XZ block".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/decode/xz.rs:142:14 [INFO] [stderr] | [INFO] [stderr] 142 | records: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Record]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | format!("Invalid index padding, must be null bytes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid index padding, must be null bytes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: Could not compile `lzma-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode/xz.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | let header_size = ((header_size as u64) << 2) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | format!("Invalid block padding, must be null bytes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid block padding, must be null bytes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | format!("Invalid block header padding, must be null bytes"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid block header padding, must be null bytes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decode/xz.rs:502:19 [INFO] [stderr] | [INFO] [stderr] 502 | result ^= ((byte & 0x7F) as u64) << (i * 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/decode/xz.rs:509:9 [INFO] [stderr] | [INFO] [stderr] 509 | format!("Invalid multi-byte encoding"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid multi-byte encoding".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/decode/rangecoder.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn is_finished_ok(&mut self) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/rangecoder.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | self.code = (self.code << 8) ^ (self.stream.read_u8()? as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.stream.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/rangecoder.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | let bound: u32 = (self.range >> 11) * (*prob as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(*prob)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decode/util.rs:12:8 [INFO] [stderr] | [INFO] [stderr] 12 | Ok(buf.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lzma-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "223e7ead529382288f66fb44efc9d4f8849ec98382956265480968c9e95b6def"` [INFO] running `"docker" "rm" "-f" "223e7ead529382288f66fb44efc9d4f8849ec98382956265480968c9e95b6def"` [INFO] [stdout] 223e7ead529382288f66fb44efc9d4f8849ec98382956265480968c9e95b6def